Bug#525209: Layout messed up in daily images
Quoting Nicolas François (nicolas.franc...@centraliens.net): If somebody knows how to test it in a daily image, please do (I don't know how to do this). - Checkout D-I SVN svn+ssh://svn.debian.org/svn/d-i/trunk (the installer/ subdir might be enough, indeed) - cd installer/ - dpkg-checkbuilddeps - install whatever needed - rebuild cdebconf with your changes - put the udeb package in build/localudebs - cd build - make build_netboot That should give you a mini.iso image in build/dest signature.asc Description: Digital signature
Processed: Re: Bug#525209: Layout messed up in daily images
Processing commands for cont...@bugs.debian.org: tags 525209 pending Bug#525209: Layout messed up in daily images There were no tags set. Tags added: pending thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#525209: Layout messed up in daily images
tags 525209 pending thanks On Thu, Apr 23, 2009 at 08:23:29AM +0200, bubu...@debian.org wrote: Quoting Nicolas François (nicolas.franc...@centraliens.net): If somebody knows how to test it in a daily image, please do (I don't know how to do this). [...] That should give you a mini.iso image in build/dest Thanks. I could test the patch on a virtualbox and committed an updated version. With the patch committed, I could make a complete install without noticing any glitches in the installer screen. Best Regards, -- Nekral -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#525209: Layout messed up in daily images
Hello Nicolas, 2009/4/23 Nicolas François nicolas.franc...@centraliens.net: tags 525209 pending thanks On Thu, Apr 23, 2009 at 08:23:29AM +0200, bubu...@debian.org wrote: Quoting Nicolas François (nicolas.franc...@centraliens.net): If somebody knows how to test it in a daily image, please do (I don't know how to do this). [...] That should give you a mini.iso image in build/dest Thanks. I could test the patch on a virtualbox and committed an updated version. With the patch committed, I could make a complete install without noticing any glitches in the installer screen. You're welcome to upload it then. Just be careful to follow the instructions at http://svn.debian.org/viewsvn/d-i/trunk/installer/doc/devel/package-upload.txt?view=markup Thanks a lot by handling it fastly :-) Cheers, -- Otavio Salvador O.S. Systems E-mail: ota...@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#525209: Layout messed up in daily images
On Thursday 23 April 2009, Frans Pop wrote: This is almost certainly a result of the cdebconf changes committed by Nicolas François (CCed). Although the new version of newt uploaded a few days ago could also be a factor (and possibly even the slightly older slang2 update). -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#525209: Layout messed up in daily images
On Thu, Apr 23, 2009 at 12:32:28AM +0200, elen...@planet.nl wrote:
This is almost certainly a result of the cdebconf changes committed by
Nicolas François (CCed).
Yes.
It looks like I assumed there were no Go Back button in those case.
Here is a patch.
I tested it just a little bit. It seems to solve the issue without
re-introducing the previous issue.
If somebody knows how to test it in a daily image, please do (I don't know
how to do this).
If urgent, somebody can commit it and upload.
Otherwise, I will try to test it more this week-end.
Best Regards,
--
Nekral
Index: src/modules/frontend/newt/newt.c
===
--- src/modules/frontend/newt/newt.c (révision 58334)
+++ src/modules/frontend/newt/newt.c (copie de travail)
@@ -777,13 +777,15 @@
t_height = newtTextboxGetNumLines(textbox);
newtTextboxSetHeight(textbox, t_height);
newtFormAddComponent(form, textbox);
-b_height = 0; // A Go Back button is not necessary
select_list_top = 1+t_height+1;
} else {
t_height = 0;
-b_height = 1;
select_list_top = 1; // No description. Only insert a blank line.
}
+if (obj-methods.can_go_back(obj, q))
+b_height = 1;
+else
+b_height = 0;
free(full_description);
win_height = t_height + sel_height + b_height;
//3 == First blank line + blanks before and after select
