Bug#535968: asterisk: Recording speed too fast with BRI cards
Hi! * Tzafrir Cohen tzafrir.co...@xorcom.com [2009-09-12 23:00:55 CEST]: fixed 535968 1:1.6.1.0~dfsg~rc3-1 tag 535968 +lenny thanks This issue has already been fixed upstream. Thus it is Lenny-specific. So far, so good. Now, what to do about it in lenny? Can you please coordinate an update for stable with the release team to get this fixed in stable? This is still affecting lenny which is a supported release. Thanks in advance, Rhonda -- Lediglich 11 Prozent der Arbeitgeber sind der Meinung, dass jeder Mensch auch ein Privatleben haben sollte. -- http://www.karriere.at/artikel/884/ -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#535968: asterisk: Recording speed too fast with BRI cards
Rhonda, hi, Gerfried Fuchs wrote: * Tzafrir Cohen tzafrir.co...@xorcom.com [2009-09-12 23:00:55 CEST]: fixed 535968 1:1.6.1.0~dfsg~rc3-1 tag 535968 +lenny thanks This issue has already been fixed upstream. Thus it is Lenny-specific. So far, so good. Now, what to do about it in lenny? Can you please coordinate an update for stable with the release team to get this fixed in stable? This is still affecting lenny which is a supported release. We do have a fix for this, along with several important other ones, in a SPU upload that we've been preparing for a while: http://svn.debian.org/wsvn/pkg-voip/asterisk/branches/lenny Unfortunately, lack of time and of a test setup has prevented me from asking from proposing it to RMs. Perhaps you could help? Thanks, Faidon -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Processed: Re: Bug#535968: asterisk: Recording speed too fast with BRI cards
Processing commands for cont...@bugs.debian.org: fixed 535968 1:1.6.1.0~dfsg~rc3-1 Bug #535968 [asterisk] asterisk: Recording speed too fast with BRI cards There is no source info for the package 'asterisk' at version '1:1.6.1.0~dfsg~rc3-1' with architecture '' Unable to make a source version for version '1:1.6.1.0~dfsg~rc3-1' Bug Marked as fixed in versions 1:1.6.1.0~dfsg~rc3-1. tag 535968 +lenny Bug #535968 [asterisk] asterisk: Recording speed too fast with BRI cards Added tag(s) lenny. thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#535968: asterisk: Recording speed too fast with BRI cards
fixed 535968 1:1.6.1.0~dfsg~rc3-1 tag 535968 +lenny thanks This issue has already been fixed upstream. Thus it is Lenny-specific. -- Tzafrir Cohen icq#16849755 jabber:tzafrir.co...@xorcom.com +972-50-7952406 mailto:tzafrir.co...@xorcom.com http://www.xorcom.com iax:gu...@local.xorcom.com/tzafrir -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#535968: asterisk: Recording speed too fast with BRI cards
Package: asterisk Version: 1:1.4.21.2~dfsg-3 Severity: grave Tags: fixed-upstream Justification: causes non-serious data loss Recorded calls using MixMonitor() result in data loss, since the recordings are (recorded and) played back at high speed. You won't know of this data loss unless you try to recover one of the recordings (and then it's too late). Fixed upstream (https://issues.asterisk.org/view.php?id=13005) -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#535968: asterisk: Recording speed too fast with BRI cards
On Mon, Jul 06, 2009 at 03:44:02PM +0300, Fotos Georgiadis wrote:
Recorded calls using MixMonitor() result in data loss,
since the recordings are (recorded and) played back at high speed.
You won't know of this data loss unless you try to recover
one of the recordings (and then it's too late).
Fixed upstream (https://issues.asterisk.org/view.php?id=13005)
This issue appears at first glance (from looking at the bug report) to
be specific to 1.4. That is: to the version in Lenny, and thus not to
apply to the version in Squeeze.
I attach the patch from the bug report. It applies to our Lenny package.
I have not checked any further.
--
Tzafrir Cohen
icq#16849755 jabber:tzafrir.co...@xorcom.com
+972-50-7952406 mailto:tzafrir.co...@xorcom.com
http://www.xorcom.com iax:gu...@local.xorcom.com/tzafrir
commit 4f7500247c2eab9642b08afbb1fd609b52224fbf
Author: mmichelson mmichel...@f38db490-d61c-443f-a65b-d21fe96a405b
Date: Tue Oct 14 23:00:01 2008 +
Add a tolerance period for sync-triggered audiohooks
so that if packetization of audio is close (but not equal)
we don't end up flushing the audiohooks over small
inconsistencies in synchronization.
Related to issue #13005, and solves the issue
for most people who were experiencing the problem.
However, a small number of people are still experiencing
the problem on long calls, so I am not closing
the issue yet
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1...@149204 f38db490-d61c-443f-a65b-d21fe96a405b
diff --git a/include/asterisk/audiohook.h b/include/asterisk/audiohook.h
index 5f79d83..3375906 100644
--- a/include/asterisk/audiohook.h
+++ b/include/asterisk/audiohook.h
@@ -56,6 +56,8 @@ enum ast_audiohook_flags {
AST_AUDIOHOOK_TRIGGER_SYNC = (1 2), /*! Audiohook wants to be triggered when both sides have combined audio available */
};
+#define AST_AUDIOHOOK_SYNC_TOLERANCE 100 /* Tolerance in milliseconds for audiohooks synchronization */
+
struct ast_audiohook;
/*! \brief Callback function for manipulate audiohook type
diff --git a/main/audiohook.c b/main/audiohook.c
index 809c176..f15395b 100644
--- a/main/audiohook.c
+++ b/main/audiohook.c
@@ -130,12 +130,19 @@ int ast_audiohook_write_frame(struct ast_audiohook *audiohook, enum ast_audiohoo
struct ast_slinfactory *factory = (direction == AST_AUDIOHOOK_DIRECTION_READ ? audiohook-read_factory : audiohook-write_factory);
struct ast_slinfactory *other_factory = (direction == AST_AUDIOHOOK_DIRECTION_READ ? audiohook-write_factory : audiohook-read_factory);
struct timeval *time = (direction == AST_AUDIOHOOK_DIRECTION_READ ? audiohook-read_time : audiohook-write_time), previous_time = *time;
+ int our_factory_ms;
+ int other_factory_samples;
+ int other_factory_ms;
/* Update last feeding time to be current */
*time = ast_tvnow();
+ our_factory_ms = ast_tvdiff_ms(*time, previous_time) + (ast_slinfactory_available(factory) / 8);
+ other_factory_samples = ast_slinfactory_available(other_factory);
+ other_factory_ms = other_factory_samples / 8;
+
/* If we are using a sync trigger and this factory suddenly got audio fed in after a lapse, then flush both factories to ensure they remain in sync */
- if (ast_test_flag(audiohook, AST_AUDIOHOOK_TRIGGER_SYNC) ast_slinfactory_available(other_factory) (ast_tvdiff_ms(*time, previous_time) (ast_slinfactory_available(other_factory) / 8))) {
+ if (ast_test_flag(audiohook, AST_AUDIOHOOK_TRIGGER_SYNC) other_factory_samples (our_factory_ms - other_factory_ms AST_AUDIOHOOK_SYNC_TOLERANCE)) {
if (option_debug)
ast_log(LOG_DEBUG, Flushing audiohook %p so it remains in sync\n, audiohook);
ast_slinfactory_flush(factory);
Bug#535968: asterisk: Recording speed too fast with BRI cards
On Jul 6, 2009, at 17:43 , Tzafrir Cohen wrote: I attach the patch from the bug report. It applies to our Lenny package. I have not checked any further. I can confirm that the patch applies cleanly in Lenny and that the patch indeed solves the problem (as reported and in the upstream issue report). IMHO this is a serious bug that results in unusable recordings when using BRI ISDN cards (common setup). -fotos -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
