Bug#536285: half-selected images
Hi, It will be fixed soon. Im about to upload a new version fixing 5-6 opened bugs. It should be done middle of the next week. Thanks all for investing this issue. I will apply evgeni's patch and contact upstream. Greetings, -- ,''`. Xavier Oswald (xosw...@debian.org) : :' : GNU/LINUX Debian Developer http://www.debian.org `. `' GPG Key: 1024D/88BBB51E `- 938D D715 6915 8860 9679 4A0C A430 C6AA 88BB B51E signature.asc Description: Digital signature
Bug#536285: half-selected images
Hey, On Sun, Jan 31, 2010 at 08:21:36PM +0100, Xavier Oswald wrote: Im about to upload a new version fixing 5-6 opened bugs. It should be done middle of the next week. You said that last week on the other patch I submitted ;) *poke* Thanks all for investing this issue. I will apply evgeni's patch and contact upstream. :) Hope upstream likes my patch Regards Evgeni -- Bruce Schneier can read and understand Perl programs. -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#536285: half-selected images
This seems to happen when mirage loads a cached image and does not update self.currimg_name. The attached patched updates this and thus fixes the bug. However I do not think this is the best way to fix this. ;) Regards Evgeni -- System Information: Debian Release: squeeze/sid APT prefers unstable APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 2.6.31-1-amd64 (SMP w/2 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages mirage depends on: ii libc6 2.10.2-5 Embedded GNU C Library: Shared lib ii libx11-6 2:1.3.3-1 X11 client-side library ii python2.5.4-6An interactive high-level object-o ii python-gtk2 2.16.0-1 Python bindings for the GTK+ widge ii python-support1.0.6 automated rebuilding support for P mirage recommends no packages. mirage suggests no packages. --- mirage-0.9.3/mirage.py 2008-03-27 05:05:28.0 +0100 +++ mirage-0.9.3.patched/mirage.py 2010-01-23 13:53:30.0 +0100 @@ -3892,6 +3892,7 @@ self.last_image_action_was_smart_fit = False elif self.open_mode == self.open_mode_1to1 or (self.open_mode == self.open_mode_last and self.last_mode == self.open_mode_1to1): self.last_image_action_was_fit = False + self.currimg_name = str(self.image_list[self.curr_img_in_list]) else: # Need to load the current image self.currimg_pixbuf = None
Bug#536285: half-selected images
* Evgeni Golov evg...@debian.org, 2010-01-23, 14:04: This seems to happen when mirage loads a cached image and does not update self.currimg_name. The attached patched updates this and thus fixes the bug. However I do not think this is the best way to fix this. ;) I tried to debug this issue some time ago, and I came into conclusion that this whole cache system is broken beyond all repair. I can't remember details, but all “obvious” solutions I tried triggered other, more or less subtle, bugs. I don't claim that your patch doesn't work, but I urge you to test it thoroughly before uploading. -- Jakub Wilk signature.asc Description: Digital signature
Bug#536285: half-selected images
Hi Jakub, On Sat, Jan 23, 2010 at 03:15:21PM +0100, Jakub Wilk wrote: * Evgeni Golov evg...@debian.org, 2010-01-23, 14:04: This seems to happen when mirage loads a cached image and does not update self.currimg_name. The attached patched updates this and thus fixes the bug. However I do not think this is the best way to fix this. ;) I tried to debug this issue some time ago, and I came into conclusion that this whole cache system is broken beyond all repair. I can't remember details, but all “obvious” solutions I tried triggered other, more or less subtle, bugs. I don't claim that your patch doesn't work, but I urge you to test it thoroughly before uploading. Well, until now I only tested that the patch fixes the issue you described in the bug and mirage still works for displaying random images :) Could you forward this to upstream? I do not have a berlios account. Let's see what he thinks. I'll test in the meantime, that everything works. Regards Evgeni -- Bruce Schneier can read and understand Perl programs. -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#536285: half-selected images
* Evgeni Golov evg...@debian.org, 2010-01-23, 15:54: This seems to happen when mirage loads a cached image and does not update self.currimg_name. The attached patched updates this and thus fixes the bug. However I do not think this is the best way to fix this. ;) I tried to debug this issue some time ago, and I came into conclusion that this whole cache system is broken beyond all repair. I can't remember details, but all “obvious” solutions I tried triggered other, more or less subtle, bugs. I don't claim that your patch doesn't work, but I urge you to test it thoroughly before uploading. Well, until now I only tested that the patch fixes the issue you described in the bug and mirage still works for displaying random images :) I played around with patched mirage, and it indeed works fine. I didn't notice anything unusual. :) Could you forward this to upstream? I do not have a berlios account. Let's see what he thinks. I'll test in the meantime, that everything works. Done. However, upstream looks a bit dead, so I wouldn't expect any feedback. BTW, There's another upstream report about the very same bug: http://developer.berlios.de/bugs/?func=detailbugbug_id=16676group_id=6637 -- Jakub Wilk signature.asc Description: Digital signature
