Bug#558755: [Pkg-cups-devel] Bug#558755: I don't think it's a poppler defect
Hey Joss, Tomáš Janoušek [2009-11-30 22:42 +0100]: Please note that poppler in Debian has been fixed: http://packages.qa.debian.org/p/poppler/news/20091130T170251Z.html Well, reverted. But I don't think that in the long run it is a good idea to ship with a permanently patched ABI/API in Debian. I think we might just need to bite the bullet and reintroduce the change in poppler, but please at least bump the shlibs version, so that dependencies will at least be correct in one direction. Thanks! Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#558755: [Pkg-cups-devel] Bug#558755: I don't think it's a poppler defect
Le mardi 01 décembre 2009 à 10:47 +0100, Martin Pitt a écrit : Hey Joss, Tomáš Janoušek [2009-11-30 22:42 +0100]: Please note that poppler in Debian has been fixed: http://packages.qa.debian.org/p/poppler/news/20091130T170251Z.html Well, reverted. But I don't think that in the long run it is a good idea to ship with a permanently patched ABI/API in Debian. I think we might just need to bite the bullet and reintroduce the change in poppler, but please at least bump the shlibs version, so that dependencies will at least be correct in one direction. It is of course not my intention to leave things as is. From now on, we can either: * wait until 0.14, which will probably change the SONAME again, to follow the ABI changes; * re-upload unpatched poppler 0.12.2 with a new binary package name (libpoppler5a). I’ll probably do the latter, but *after* the poppler migration to testing is complete. Otherwise Luk is going to kill me for good. Cheers, -- .''`. Josselin Mouette : :' : `. `' “I recommend you to learn English in hope that you in `- future understand things” -- Jörg Schilling signature.asc Description: Ceci est une partie de message numériquement signée
Bug#558755: I don't think it's a poppler defect
I'm sure that the cups maintainers are aware of all this, but it might be of interest to users who all of a sudden can't print, so I'm commenting on the defect. I was unable to locate a copy of the version 0.12.0-2.1 version of libpoppler5 to downgrade to, so I investigated the issue with the cups source, thinking there might be a simple patch I could apply to the cups source to get it all to work. To be specific, the issue that cups complains about is that it can't run the pdftopdf filter and, when run manually, that filter issues a message similar to this: undefined symbol: _ZN13GfxColorSpace5parseEP6Object Once I downloaded the cups source and figured out which command to issue to build it, the problem became obvious: The poppler guys have changed the function signature of GfxColorSpace::parse to include a pointer to a Gfx object. They also added a similar pointer to the calls to GfxPattern::parse, like is called by methods in P2PPattern.cxx Since it says that P2PGfx.cxx is derived from Gfx.cc from the poppler source, I thought it might prove useful to see what the Gfx.cc source passes to GfxColorSpace::parse, and it passes the this pointer in that place. Since the P2PGfx class is not derived from the Gfx class, passing the this pointer won't work and trying to derive P2PGfx from Gfx is more work than I'm willing to go to for a quick fix. I was able to get it to work (I could at least print my jobs) by passing NULL pointers in all three places where it expects extra object pointers. However, I expect that approach to be suboptimal. That parameter is likely used for something, although I'm not going to dig into just what at the moment. In any case, there is a version dependency. I don't know if libpoppler5 should have been versioned or what, but the 1.4.2 version of cups is clearly not compatible with it and I believe that the dependencies should be adjusted such that you can't have cups 1.4.2-2 installed at the same time as libpoppler5 0.12.2. !DSPAM:141,4b140dc940091780812483! -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#558755: [Pkg-cups-devel] Bug#558755: I don't think it's a poppler defect
Jonathan Guthrie [2009-11-30 12:23 -0600]: In any case, there is a version dependency. I don't know if libpoppler5 should have been versioned or what, but the 1.4.2 version of cups is clearly not compatible with it and I believe that the dependencies should be adjusted such that you can't have cups 1.4.2-2 installed at the same time as libpoppler5 0.12.2. This is indeed the part where poppler is at fault. If a new upstream version breaks the ABI, it should bump the SONAME. The new poppler in Debian didn't even bump the shlibs version, so all consumers have to set the dependencies manually, which is against the spirit and letter of the library policy. I'll rebuild cups against the new poppler now. Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#558755: [Pkg-cups-devel] Bug#558755: I don't think it's a poppler defect
Hello, On Mon, Nov 30, 2009 at 10:34:27PM +0100, Martin Pitt wrote: Jonathan Guthrie [2009-11-30 12:23 -0600]: In any case, there is a version dependency. I don't know if libpoppler5 should have been versioned or what, but the 1.4.2 version of cups is clearly not compatible with it and I believe that the dependencies should be adjusted such that you can't have cups 1.4.2-2 installed at the same time as libpoppler5 0.12.2. This is indeed the part where poppler is at fault. If a new upstream version breaks the ABI, it should bump the SONAME. The new poppler in Debian didn't even bump the shlibs version, so all consumers have to set the dependencies manually, which is against the spirit and letter of the library policy. I'll rebuild cups against the new poppler now. Please note that poppler in Debian has been fixed: http://packages.qa.debian.org/p/poppler/news/20091130T170251Z.html Rebuilding against what is on mirrors now would bring the same problem tomorrow. -- Tomáš Janoušek, a.k.a. Liskni_si, http://work.lisk.in/ -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#558755: [Pkg-cups-devel] Bug#558755: I don't think it's a poppler defect
Hello Tomáš, Tomáš Janoušek [2009-11-30 22:42 +0100]: Please note that poppler in Debian has been fixed: http://packages.qa.debian.org/p/poppler/news/20091130T170251Z.html Rebuilding against what is on mirrors now would bring the same problem tomorrow. Argh, sorry, but too late. I'll do yet another upload tomorrow then. Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
