Bug#566562: liblicense-dev: patch provided: needed Depends: hicolor-icon-theme
On Sat, 30 Jan 2010 12:28:27 +, Dennis Sheil wrote: The post-installation script of liblicense-dev touches /usr/share/icons/hicolor so as to regenerate GNOME's icon cache. The hicolor-icon-theme package is not a dependency though so liblicense-dev fails when it is not aready installed. Patch attached. 1) I don't see how adding hicolor-icon-theme to _Build_-Depends helps at installation time. 2) IMO the touch'ing in postinst is not needed; hicolor-icon-theme has a trigger on /usr/share/icons/hicolor anyway. And liblicense-_dev_ doesn't install anything into this directory. (Actually none of the binary packages does.) I suggest to remove this line from the postinst; but maybe I'm missing something ... Cheers, gregor -- .''`. http://info.comodo.priv.at/ -- GPG Key IDs: 0x8649AA06, 0x00F3CFE4 : :' : Debian GNU/Linux user, admin, developer - http://www.debian.org/ `. `' Member of VIBE!AT SPI, fellow of Free Software Foundation Europe `-NP: Tracy Chapman: Open Arms signature.asc Description: Digital signature
Bug#566562: liblicense-dev: patch provided: needed Depends: hicolor-icon-theme
On Thu, Feb 18, 2010 at 5:47 PM, gregor herrmann gre...@debian.org wrote: On Sat, 30 Jan 2010 12:28:27 +, Dennis Sheil wrote: The post-installation script of liblicense-dev touches /usr/share/icons/hicolor so as to regenerate GNOME's icon cache. The hicolor-icon-theme package is not a dependency though so liblicense-dev fails when it is not aready installed. Patch attached. 1) I don't see how adding hicolor-icon-theme to _Build_-Depends helps at installation time. 2) IMO the touch'ing in postinst is not needed; hicolor-icon-theme has a trigger on /usr/share/icons/hicolor anyway. And liblicense-_dev_ doesn't install anything into this directory. (Actually none of the binary packages does.) I suggest to remove this line from the postinst; but maybe I'm missing something ... Since the /usr/share/icons/hicolor directory is touched, hicolor-icon-theme needs to be installed for the touch to happen successfully. Otherwise the touch fails and thus the installation fails. This was the main problem, the installation failed. Of course, an if statement to check this directory exists before attempting to touch it will solve the problem as well. Or if a trigger exists like you say, the touch can be removed. The problem is the postinst touch is touching a directory that may not exist on the system, thus causing the installation to fail. If a trigger exists, and this line which breaks the installation is unnecessary and can be removed, so much the better. -- Dennis -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#566562: liblicense-dev: patch provided: needed Depends: hicolor-icon-theme
On Sat, 30 Jan 2010, Dennis Sheil wrote: Package: liblicense-dev Severity: normal The post-installation script of liblicense-dev touches /usr/share/icons/hicolor so as to regenerate GNOME's icon cache. The hicolor-icon-theme package is not a dependency though so liblicense-dev fails when it is not aready installed. Hi! You rule. Fixing shortly. Ping me in 3 days if it's not uploaded by then. -- Asheesh. -- Option Paralysis: The tendency, when given unlimited choices, to make none. -- Douglas Coupland, Generation X: Tales for an Accelerated Culture -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#566562: liblicense-dev: patch provided: needed Depends: hicolor-icon-theme
Package: liblicense-dev Severity: normal The post-installation script of liblicense-dev touches /usr/share/icons/hicolor so as to regenerate GNOME's icon cache. The hicolor-icon-theme package is not a dependency though so liblicense-dev fails when it is not aready installed. Patch attached. -- System Information: Debian Release: squeeze/sid APT prefers unstable APT policy: (500, 'unstable') Architecture: i386 (i686) Kernel: Linux 2.6.31-17-generic (SMP w/2 CPU cores) Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968) Shell: /bin/sh linked to /bin/dash Versions of packages liblicense-dev depends on: ii liblicense3 0.8-2.dws1 Stores and retrieves license infor liblicense-dev recommends no packages. liblicense-dev suggests no packages. -- no debconf information diff -u liblicense-0.8/debian/control liblicense-0.8/debian/control --- liblicense-0.8/debian/control +++ liblicense-0.8/debian/control @@ -3,7 +3,7 @@ Priority: extra Maintainer: Asheesh Laroia ashe...@asheesh.org DM-Upload-Allowed: yes -Build-Depends: debhelper (= 5.0.38), libcurl4-gnutls-dev, libvorbis-dev, libtag1-dev, libflac-dev, libraptor-dev, libexempi-dev, libid3-3.8.3-dev, libgsf-1-dev, python-all-dev (= 2.3.5-11), python-central (= 0.5.6), libglib2.0-dev, xsltproc, docbook-xsl, libtool, libexpat-dev +Build-Depends: debhelper (= 5.0.38), libcurl4-gnutls-dev, libvorbis-dev, libtag1-dev, libflac-dev, libraptor-dev, libexempi-dev, libid3-3.8.3-dev, libgsf-1-dev, python-all-dev (= 2.3.5-11), python-central (= 0.5.6), libglib2.0-dev, xsltproc, docbook-xsl, libtool, libexpat-dev, hicolor-icon-theme Standards-Version: 3.7.2 Section: libs
