Bug#586759: fails to install

2010-06-27 Thread Thijs Kinkhorst
tags 586759 moreinfo
thanks

Hi Holger,

On tiisdei 22 Juny 2010, Holger Levsen wrote:
 On Dienstag, 22. Juni 2010, Julien Cristau wrote:
  Why?  It's not configured, it won't work, why should it pretend the
  installation was successful?
 
 because you want the package in stable?
 
 having packages installable is a release goal, else packages are not
 suited  for a stable release.

A fix has been committed for this bug but I'm not convinced that this is the 
right one.

I don't think your reasoning quoted above is technically sound. We do not fix 
bugs 'because a release goal says so' but because we think the change is a 
technically better situation.

In my opinion the current situation is:

1) Package needs SQL database to function;
2) Package asks for SQL info in configuration stage;
3) Reporter does not supply apt SQL info;
4) Package is unable to contact database and cannot complete setup;
5) Package fails installation.

That seems correct to me, because the package is not useful without a 
configured database, and retrying configuring the package with correct 
database information would solve that problem. If we would instead just claim 
that installation is successful, where it in fact is not, we end up with a 
'successfully' installed package that doesn't work. That doesn't seem like an 
improvement to me.

Can you please clarify why you think we shouldn't abort installation when 
incorrect database info is provided?


Cheers,
Thijs


signature.asc
Description: This is a digitally signed message part.


Processed: Re: Bug#586759: fails to install

2010-06-27 Thread Debian Bug Tracking System
Processing commands for cont...@bugs.debian.org:

 tags 586759 moreinfo
Bug #586759 [phpbb3] fails to install
Added tag(s) moreinfo.
 thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
586759: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=586759
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#586759: fails to install

2010-06-27 Thread David Prévot
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Le 27/06/2010 07:00, Thijs Kinkhorst a écrit :
 Hi Holger,

Hi Holger, Thijs,

 On tiisdei 22 Juny 2010, Holger Levsen wrote:
 On Dienstag, 22. Juni 2010, Julien Cristau wrote:
 Why?  It's not configured, it won't work, why should it pretend the
 installation was successful?

 because you want the package in stable?

 having packages installable is a release goal, else packages are not
 suited  for a stable release.
 
 A fix has been committed for this bug but I'm not convinced that this is the 
 right one.
 
 I don't think your reasoning quoted above is technically sound. We do not fix 
 bugs 'because a release goal says so' but because we think the change is a 
 technically better situation.
 
 In my opinion the current situation is:
 
 1) Package needs SQL database to function;
 2) Package asks for SQL info in configuration stage;
 3) Reporter does not supply apt SQL info;
 4) Package is unable to contact database and cannot complete setup;
 5) Package fails installation.
 
 That seems correct to me, because the package is not useful without a 
 configured database, and retrying configuring the package with correct 
 database information would solve that problem. If we would instead just claim 
 that installation is successful, where it in fact is not, we end up with a 
 'successfully' installed package that doesn't work. That doesn't seem like an 
 improvement to me.

May I add a comment on this one: I usually don't let dbconfig-common
configure my databases, at least when I install phpbb3. I prefer to
configure each database in order to use the multiboard trick, and the
first board created in the postint script doesn't fit my needs, so I
guess that Jean-Marc fix for this one seems fine: let the package be
installed, and let the user read the README.* files in order to
configure phpbb3 the way that fits her needs.

Cheers

David

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAkwnOtUACgkQ18/WetbTC/oNEwCggqg2LjEXgPm57DGgkpVogdMj
Rz0AnAhA+uYJwvYBsoVQu6XycBrTzjAX
=vCDC
-END PGP SIGNATURE-



-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#586759: fails to install

2010-06-27 Thread J.M.Roth
Technically, the failure is trigged by the set -e of the maintainer
script, since dbc_go fails.

This is by no means a failure of the phpbb3 package, only a
consequence of the failure of dbconfig-common.

As far as debconf is concerned, people use db_go || true -- I have
seen no such call for dbc_go, however s9y uses an if-construct to
achieve the same goal, I believe.

However, in this case, I wonder why dbconfig-common failed -- there
should be a question if it is supposed to be used at all for that
package, which probably is what the bug reporter intended to (not) do,
and if properly answered with No it would not have been used and
therefore not have produced any errors -- not sure how piuparts
handles the part of configuring the package for test.



-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#586759: fails to install

2010-06-27 Thread Thijs Kinkhorst
On snein 27 Juny 2010, J.M.Roth wrote:
 Technically, the failure is trigged by the set -e of the maintainer
 script, since dbc_go fails.
 
 This is by no means a failure of the phpbb3 package, only a
 consequence of the failure of dbconfig-common.
 
 As far as debconf is concerned, people use db_go || true -- I have
 seen no such call for dbc_go, however s9y uses an if-construct to
 achieve the same goal, I believe.
 
 However, in this case, I wonder why dbconfig-common failed -- there
 should be a question if it is supposed to be used at all for that
 package, which probably is what the bug reporter intended to (not) do,
 and if properly answered with No it would not have been used and
 therefore not have produced any errors -- not sure how piuparts
 handles the part of configuring the package for test.

Actually, it seems that the issue is that Holger is using a non-interactive 
install, and that in such a case (in my opinion) dbconfig-common should 
default to No on the question on whether to use dbconfig-common.

This is another case of #542381 if you ask me. However, that bug is claimed to 
be fixed in the version that Holger used. More investigation needed.


Thijs


signature.asc
Description: This is a digitally signed message part.


Bug#586759: fails to install

2010-06-22 Thread Holger Levsen
Package: phpbb3
Version: 3.0.7-PL1-2
Severity: serious
User: debian...@lists.debian.org
Usertags: piuparts piuparts.d.o

Hi, 

during a test with piuparts I noticed your package failed to install. 

From the attached log (scroll to the bottom...):

  Setting up phpbb3 (3.0.7-PL1-2) ...
  dbconfig-common: writing config to /etc/dbconfig-common/phpbb3.conf
  
  Creating config file /etc/dbconfig-common/phpbb3.conf with new version
  
  Creating config file /etc/phpbb3/database.inc.php with new version
  ERROR 2002 (HY000): Can't connect to local MySQL server through 
socket '/var/run/mysqld/mysqld.sock' (2).
  unable to connect to mysql server.
  error encountered creating user:
  ERROR 2002 (HY000): Can't connect to local MySQL server through 
socket '/var/run/mysqld/mysqld.sock' (2)
  dbconfig-common: phpbb3 configure: noninteractive fail.
  dbconfig-common: phpbb3 configure: ignoring errors from here forwards
  populating database via sql...  done.
  dbconfig-common: flushing administrative password
  Setting admin password
  ERROR 2002 (HY000): Can't connect to local MySQL server through 
socket '/var/run/mysqld/mysqld.sock' (2)
  dpkg: error processing phpbb3 (--configure):
   subprocess installed post-installation script returned error exit status 1
  Errors were encountered while processing:
   phpbb3
  E: Sub-process /usr/bin/dpkg returned an error code (1)


cheers,
Holger
Start: 2010-06-20 04:02:42 UTC

Package: phpbb3
Priority: optional
Section: web
Installed-Size: 12732
Maintainer: Jeroen van Wolffelaar jer...@wolffelaar.nl
Architecture: all
Version: 3.0.7-PL1-2
Depends: libapache2-mod-php5 | php5-cgi | php5, php5-gd, php5-mysql | php5-pgsql | php5-sqlite | php5-odbc | php5-sybase, apache2 | httpd, mysql-client | postgresql-client | sqlite, dbconfig-common, ucf, php5-cli, debconf (= 0.5) | debconf-2.0
Recommends: exim4 | mail-transport-agent, php5-imagick
Suggests: phpbb3-l10n, mysql-server | postgresql
Filename: pool/main/p/phpbb3/phpbb3_3.0.7-PL1-2_all.deb
Size: 2299446
MD5sum: 368286e6c8de4fadf8557bdedba51e9e
SHA1: f94b98f773c98cc22fae2a20d3a6164480d35c19
SHA256: b699e35260a325b2097697e91d320dc04d2789406a28f1399f4d90ea61abd072
Description: full-featured, skinnable non-threaded web forum
 phpBB is a high powered, fully scalable, and highly customizable
 bulletin board, with a user-friendly interface, simple and
 straightforward administration panel, and helpful FAQ.
 .
 It supports a choice of database back-ends.
Homepage: http://www.phpbb.com
Tag: implemented-in::php, interface::web, role::program, scope::application, web::application, web::forum, works-with::db, works-with-format::html

Executing: sudo /org/piuparts.debian.org/sbin/piuparts --warn-symlinks --warn-on-others --warn-on-leftovers-after-purge --skip-logrotatefiles-test --scriptsdir /etc/piuparts/scripts/ --tmpdir /org/piuparts.debian.org/tmp -ad squeeze -b squeeze.tar.gz --mirror http://piatti.debian.org/debian/ phpbb3
Guessed: debian
0m0.0s INFO: --
0m0.0s INFO: To quickly glance what went wrong, scroll down to the bottom of this logfile.
0m0.0s INFO: FAQ available at http://wiki.debian.org/piuparts/FAQ
0m0.0s INFO: --
0m0.0s INFO: piuparts version 0.39~201005220948 starting up.
0m0.0s INFO: Command line arguments: /org/piuparts.debian.org/sbin/piuparts --warn-symlinks --warn-on-others --warn-on-leftovers-after-purge --skip-logrotatefiles-test --scriptsdir /etc/piuparts/scripts/ --tmpdir /org/piuparts.debian.org/tmp -ad squeeze -b squeeze.tar.gz --mirror http://piatti.debian.org/debian/ phpbb3
0m0.0s INFO: Running on: Linux piatti 2.6.32.14-dsa-amd64 #1 SMP Thu May 27 15:09:09 CEST 2010 x86_64
0m0.0s DEBUG: Created temporary directory /org/piuparts.debian.org/tmp/tmphbzfVV
0m0.0s DEBUG: Unpacking squeeze.tar.gz into /org/piuparts.debian.org/tmp/tmphbzfVV
0m0.0s DEBUG: Starting command: ['tar', '-C', '/org/piuparts.debian.org/tmp/tmphbzfVV', '-zxf', 'squeeze.tar.gz']
0m1.8s DEBUG: Command ok: ['tar', '-C', '/org/piuparts.debian.org/tmp/tmphbzfVV', '-zxf', 'squeeze.tar.gz']
0m1.8s DEBUG: Created policy-rc.d and chmodded it.
0m1.8s DEBUG: Starting command: ['chroot', '/org/piuparts.debian.org/tmp/tmphbzfVV', 'apt-get', 'update']
0m3.8s DUMP: 
  Get:1 http://piatti.debian.org squeeze Release.gpg [835B]
  Get:2 http://piatti.debian.org squeeze Release [89.5kB]
  Ign http://piatti.debian.org squeeze/main Packages/DiffIndex
  Ign http://piatti.debian.org squeeze/contrib Packages/DiffIndex
  Ign http://piatti.debian.org squeeze/non-free Packages/DiffIndex
  Get:3 http://piatti.debian.org squeeze/main Packages [8589kB]
  Get:4 http://piatti.debian.org squeeze/contrib Packages [62.3kB]
  Get:5 http://piatti.debian.org squeeze/non-free Packages [121kB]
  Fetched 8863kB in 1s (8562kB/s)
  Reading package lists...
0m3.8s DEBUG: Command ok: ['chroot', 

Bug#586759: fails to install

2010-06-22 Thread Julien Cristau
On Tue, Jun 22, 2010 at 11:41:55 +0200, Holger Levsen wrote:

 Package: phpbb3
 Version: 3.0.7-PL1-2
 Severity: serious
 User: debian...@lists.debian.org
 Usertags: piuparts piuparts.d.o
 
 Hi, 
 
 during a test with piuparts I noticed your package failed to install. 
 
It doesn't fail to install, it fails to configure.

 From the attached log (scroll to the bottom...):
 
   Setting up phpbb3 (3.0.7-PL1-2) ...
   dbconfig-common: writing config to /etc/dbconfig-common/phpbb3.conf
   
   Creating config file /etc/dbconfig-common/phpbb3.conf with new version
   
   Creating config file /etc/phpbb3/database.inc.php with new version
   ERROR 2002 (HY000): Can't connect to local MySQL server through 
 socket '/var/run/mysqld/mysqld.sock' (2).
   unable to connect to mysql server.
   error encountered creating user:
   ERROR 2002 (HY000): Can't connect to local MySQL server through 
 socket '/var/run/mysqld/mysqld.sock' (2)
   dbconfig-common: phpbb3 configure: noninteractive fail.
   dbconfig-common: phpbb3 configure: ignoring errors from here forwards
   populating database via sql...  done.
   dbconfig-common: flushing administrative password
   Setting admin password
   ERROR 2002 (HY000): Can't connect to local MySQL server through 
 socket '/var/run/mysqld/mysqld.sock' (2)
   dpkg: error processing phpbb3 (--configure):
subprocess installed post-installation script returned error exit status 1
   Errors were encountered while processing:
phpbb3
   E: Sub-process /usr/bin/dpkg returned an error code (1)
 
I'm not sure how you expect phpbb3 to configure successfully if you don't
tell it what sql server to use.

Cheers,
Julien


signature.asc
Description: Digital signature


Bug#586759: fails to install

2010-06-22 Thread Holger Levsen
Hi,

On Dienstag, 22. Juni 2010, Julien Cristau wrote:
  during a test with piuparts I noticed your package failed to install.
 It doesn't fail to install, it fails to configure.

While technically correct, the end result is the same: the installation fails, 
because the configure steps fails.

 I'm not sure how you expect phpbb3 to configure successfully if you don't
 tell it what sql server to use.

It wont. It just shouldnt fail to install.


cheers,
Holger


signature.asc
Description: This is a digitally signed message part.


Bug#586759: fails to install

2010-06-22 Thread Julien Cristau
On Tue, Jun 22, 2010 at 12:33:10 +0200, Holger Levsen wrote:

 Hi,
 
 On Dienstag, 22. Juni 2010, Julien Cristau wrote:
   during a test with piuparts I noticed your package failed to install.
  It doesn't fail to install, it fails to configure.
 
 While technically correct, the end result is the same: the installation 
 fails, 
 because the configure steps fails.
 
  I'm not sure how you expect phpbb3 to configure successfully if you don't
  tell it what sql server to use.
 
 It wont. It just shouldnt fail to install.
 
Why?  It's not configured, it won't work, why should it pretend the
installation was successful?

Cheers,
Julien


signature.asc
Description: Digital signature


Bug#586759: fails to install

2010-06-22 Thread Holger Levsen
On Dienstag, 22. Juni 2010, Julien Cristau wrote:
 Why?  It's not configured, it won't work, why should it pretend the
 installation was successful?

because you want the package in stable?

having packages installable is a release goal, else packages are not suited 
for a stable release.


cheers,
Holger


signature.asc
Description: This is a digitally signed message part.