Bug#650359: segmentation fault gmpc

2012-08-13 Thread Etienne Millon 
I'll push the following fix ASAP. It disables the whole LyrDB plugin,
which does not seem to work anymore.

-- 
Etienne Millon
From: Etienne Millon m...@emillon.org
Date: Mon, 13 Aug 2012 19:52:50 +0200
Subject: Disable LyrDB lyrics provider

LyrDB.com makes gmpc segfault, and there are other lyrics providers so disabling
it is a net profit.

Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=650359
---
 src/Tools/plugin-man.c |3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/Tools/plugin-man.c b/src/Tools/plugin-man.c
index 621bb00..197bcbd 100644
--- a/src/Tools/plugin-man.c
+++ b/src/Tools/plugin-man.c
@@ -116,9 +116,6 @@ void plugin_manager_load_internal_plugins(void)
 gmpc_provider_render_cover_new(),
 0, NULL);
 plugin_add_new((GmpcPluginBase *) 
-gmpc_provider_lyr_db_new(),
-0, NULL);
-plugin_add_new((GmpcPluginBase *) 
 gmpc_provider_chart_lyrics_new(),
 0, NULL);
 }

Bug#650359: segmentation fault gmpc

2012-07-30 Thread Etienne Millon 
* Etienne Millon etienne.mil...@gmail.com [120730 12:14]:
 It seems that the assert in gmpc_easy_handler_get_data_as_string
 causes a NULL pointer dereference (should have spotted that earlier,
 sorry). This patch disables the assert if data is NULL. Can you please
 test it and tell me if it solves the bug ?

Hi Dmitry,

I believe that the patch I posted would fix the error you reported,
but as I couldn't reproduce it I cannot be sure.

Can you please test it and tell me if it resolves your problem ?

Thank you,

-- 
Etienne Millon


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#650359: segmentation fault gmpc

2012-07-18 Thread Etienne Millon 
tag 650359 + patch
thanks

Hello,

It seems that the assert in gmpc_easy_handler_get_data_as_string
causes a NULL pointer dereference (should have spotted that earlier,
sorry). This patch disables the assert if data is NULL. Can you please
test it and tell me if it solves the bug ?

Thanks !

-- 
Etienne Millon
From c57d6d4a944bfc8b0a518f67ca357a5668c10596 Mon Sep 17 00:00:00 2001
From: Etienne Millon m...@emillon.org
Date: Wed, 18 Jul 2012 11:49:54 +0200
Subject: [PATCH] Fix NULL pointer dereference (#650359)

---
 debian/changelog   |6 +
 .../0009-Add-NULL-check-in-easy_download.patch |   27 
 debian/patches/series  |1 +
 3 files changed, 34 insertions(+)
 create mode 100644 debian/patches/0009-Add-NULL-check-in-easy_download.patch

diff --git a/debian/changelog b/debian/changelog
index 0262b67..b045e9c 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+gmpc (11.8.16-4) UNRELEASED; urgency=low
+
+  * New patch fixing a NULL pointer dereference (Closes: #650359)
+
+ -- Etienne Millon etienne.mil...@gmail.com  Wed, 18 Jul 2012 11:48:06 +0200
+
 gmpc (11.8.16-3) unstable; urgency=low
 
   * New patches :
diff --git a/debian/patches/0009-Add-NULL-check-in-easy_download.patch b/debian/patches/0009-Add-NULL-check-in-easy_download.patch
new file mode 100644
index 000..9a1bbdb
--- /dev/null
+++ b/debian/patches/0009-Add-NULL-check-in-easy_download.patch
@@ -0,0 +1,27 @@
+From: Etienne Millon m...@emillon.org
+Date: Wed, 18 Jul 2012 11:45:12 +0200
+Subject: Add NULL check in easy_download
+
+gmpc_easy_handler_get_data_as_string checks that data is nul-terminated, but
+this fails if data is NULL. This adds a check around the assert.
+
+Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=650359
+---
+ src/Tools/gmpc_easy_download.c |4 +++-
+ 1 file changed, 3 insertions(+), 1 deletion(-)
+
+diff --git a/src/Tools/gmpc_easy_download.c b/src/Tools/gmpc_easy_download.c
+index db5398a..1b9c9cd 100644
+--- a/src/Tools/gmpc_easy_download.c
 b/src/Tools/gmpc_easy_download.c
+@@ -499,7 +499,9 @@ const guchar *gmpc_easy_handler_get_data_vala_wrap(const GEADAsyncHandler * hand
+ const char *gmpc_easy_handler_get_data_as_string(const GEADAsyncHandler * handle)
+ {
+ 	_GEADAsyncHandler *d = (_GEADAsyncHandler *) handle;
+-	g_assert(d-data[d-length] == '\0');
++	if (d-data != NULL) {
++		g_assert(d-data[d-length] == '\0');
++	}
+ 	return (gchar *) d-data;
+ }
+ void gmpc_easy_handler_set_user_data(const GEADAsyncHandler * handle, gpointer user_data)
diff --git a/debian/patches/series b/debian/patches/series
index 63b924d..d2855b4 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -6,3 +6,4 @@
 0006-Fix-MetaData-object-vala-binding.-fix-vala-13.3-buil.patch
 0007-Fix-timeout-when-connecting-to-a-slow-mpd.patch
 0008-Fix-build-with-valac-0.16.patch
+0009-Add-NULL-check-in-easy_download.patch
-- 
1.7.10.4

Processed: Re: Bug#650359: segmentation fault gmpc

2012-07-18 Thread Debian Bug Tracking System 
Processing commands for cont...@bugs.debian.org:

 tag 650359 + patch
Bug #650359 [gmpc] segmentation fault gmpc
Added tag(s) patch.
 thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
650359: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=650359
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems


--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#650359: segmentation fault gmpc

2012-06-17 Thread Etienne Millon 
tag 650359 + unreproducible
thanks

Hello,

I can't reproduce this bug on my machine. I'll try running gmpc in
longer sessions, where the bug may be triggered.

If anyone else is affected, please let me know !

glyr  the new version of gmpc probably won't make it into wheezy, so
fixing this bug is now a priority of mine :)

Have a nice day.

-- 
Etienne Millon



-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Processed: Re: Bug#650359: segmentation fault gmpc

2012-06-17 Thread Debian Bug Tracking System 
Processing commands for cont...@bugs.debian.org:

 tag 650359 + unreproducible
Bug #650359 [gmpc] segmentation fault gmpc
Added tag(s) unreproducible.
 thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
650359: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=650359
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems


--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#650359: segmentation fault gmpc

2012-06-17 Thread Dmitry E. Oboukhov 
 tag 650359 + unreproducible
 thanks

 Hello,

 I can't reproduce this bug on my machine. I'll try running gmpc in
 longer sessions, where the bug may be triggered.

 If anyone else is affected, please let me know !

 glyr  the new version of gmpc probably won't make it into wheezy, so
 fixing this bug is now a priority of mine :)

since I removed gpmc's cache it crashes rarely. But crashes from time to
time.
-- 

. ''`.   Dmitry E. Oboukhov
: :’  :   email: un...@debian.org jabber://un...@uvw.ru
`. `~’  GPGKey: 1024D / F8E26537 2006-11-21
  `- 1B23 D4F8 8EC0 D902 0555  E438 AB8C 00CF F8E2 6537


signature.asc
Description: Digital signature

Bug#650359: segmentation fault gmpc

2011-12-28 Thread Dmitry E. Oboukhov 

 Hi!

 After removing ~/.cache/gmpc gmpc began to work fine. Now is the
 second day it is started :)

 If it crashes I'll report the bug :)

It was a mistake.

After removing ~/.cache/gmpc gmpc crashes, too. But it crashes rarely
than before removing. So the bug is still reproducible.
-- 

. ''`.   Dmitry E. Oboukhov
: :’  :   email: un...@debian.org jabber://un...@uvw.ru
`. `~’  GPGKey: 1024D / F8E26537 2006-11-21
  `- 1B23 D4F8 8EC0 D902 0555  E438 AB8C 00CF F8E2 6537


signature.asc
Description: Digital signature

Bug#650359: segmentation fault gmpc

2011-12-16 Thread Dmitry E. Oboukhov 
 I've just upgraded gmpc upto 11.8.16-1. It always crashes.
 The bug is reproducible in a few hosts (desktop, notebook, the other
 desktop).
 
 Hello !
 
 Thanks a lot for the backtrace, that helps. I have a few questions to
 narrow a bit htis bug :
 
 * Do you have gmpc-plugins installed too (and which version) ? If
 so, does the problem occur when you launch gmpc with the
 --disable-plugins switch ?
 
 That was the first thing that I tried to do.
 When it chrashed the first time, I deleted gmpc-plugins.
 It crashes with plugins. It crashes without plugins.
 :(

 Thanks for the trace. Did you also try to remove (after making a
 backup) ~/.cache/gmpc (or $XDG_CACHE_HOME/gmpc) ?

 I am preparing gmyr (ITP #651416) in order to package a newer git
 snapshot, where the provider code has disappeared.


Hi!

After removing ~/.cache/gmpc gmpc began to work fine. Now is the
second day it is started :)

If it crashes I'll report the bug :)

-- 

. ''`.   Dmitry E. Oboukhov
: :’  :   email: un...@debian.org jabber://un...@uvw.ru
`. `~’  GPGKey: 1024D / F8E26537 2006-11-21
  `- 1B23 D4F8 8EC0 D902 0555  E438 AB8C 00CF F8E2 6537


signature.asc
Description: Digital signature

Bug#650359: segmentation fault gmpc

2011-12-15 Thread Etienne Millon 
* Dmitry E. Oboukhov un...@debian.org [29 10:25]:
  Hi!
  
  I've just upgraded gmpc upto 11.8.16-1. It always crashes.
  The bug is reproducible in a few hosts (desktop, notebook, the other
  desktop).
 
  Hello !
 
  Thanks a lot for the backtrace, that helps. I have a few questions to
  narrow a bit htis bug :
 
  * Do you have gmpc-plugins installed too (and which version) ? If
  so, does the problem occur when you launch gmpc with the
  --disable-plugins switch ?
 
 That was the first thing that I tried to do.
 When it chrashed the first time, I deleted gmpc-plugins.
 It crashes with plugins. It crashes without plugins.
 :(

Thanks for the trace. Did you also try to remove (after making a
backup) ~/.cache/gmpc (or $XDG_CACHE_HOME/gmpc) ?

I am preparing gmyr (ITP #651416) in order to package a newer git
snapshot, where the provider code has disappeared.

Have a nice day,
-- 
Etienne Millon



-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#650359: segmentation fault gmpc

2011-11-29 Thread Etienne Millon 
* Dmitry E. Oboukhov un...@debian.org [29 09:15]:
 Hi!
 
 I've just upgraded gmpc upto 11.8.16-1. It always crashes.
 The bug is reproducible in a few hosts (desktop, notebook, the other
 desktop).

Hello !

Thanks a lot for the backtrace, that helps. I have a few questions to
narrow a bit htis bug :

  * Do you have gmpc-plugins installed too (and which version) ? If
so, does the problem occur when you launch gmpc with the
--disable-plugins switch ?

  * Can you attach a (maybe anonymized) trace of gmpc started with
--debug-level 3 ?

This seems to be caused by the old lyrics providers, which are being
deprecated upstream. I'll prepare a package without those for you to
test.

-- 
Etienne Millon



-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#650359: segmentation fault gmpc

2011-11-29 Thread Dmitry E. Oboukhov 
 Hi!
 
 I've just upgraded gmpc upto 11.8.16-1. It always crashes.
 The bug is reproducible in a few hosts (desktop, notebook, the other
 desktop).

 Hello !

 Thanks a lot for the backtrace, that helps. I have a few questions to
 narrow a bit htis bug :

 * Do you have gmpc-plugins installed too (and which version) ? If
 so, does the problem occur when you launch gmpc with the
 --disable-plugins switch ?

That was the first thing that I tried to do.
When it chrashed the first time, I deleted gmpc-plugins.
It crashes with plugins. It crashes without plugins.
:(

 * Can you attach a (maybe anonymized) trace of gmpc started with
 --debug-level 3 ?

 This seems to be caused by the old lyrics providers, which are being
 deprecated upstream. I'll prepare a package without those for you to
 test.


apache:[~]$ gmpc --disable-plugins --debug-level 3
(gmpc:26433): Gmpc-DEBUG: Initializing gtk 
(gmpc:26433): Gmpc.Misc-DEBUG: /home/dimka/.config/gmpc exist and is directory
(gmpc:26433): Gmpc.Misc-DEBUG: /home/dimka/.cache/gmpc/metadata exist and is 
directory
(gmpc:26433): Gmpc-DEBUG: Trying to open the config file: 
/home/dimka/.config/gmpc/gmpc.cfg
(gmpc:26433): Config-DEBUG: Config /home/dimka/.config/gmpc/gmpc.cfg: 
allocated: 68910

(gmpc:26433): Config-DEBUG: Config /home/dimka/.config/gmpc/profiles.cfg: 
allocated: 1030

(gmpc:26433): MetaDataCacheSqlite-DEBUG: Database integrity check: valid
(gmpc:26433): PixbufCache-DEBUG: Create pixbuf cache
(gmpc:26433): Gmpc-DEBUG: Loading stock icons
29/11/11 13:21:11: INFO:libmpd.c mpd_new_default():#275:creating a new 
mpdInt object
(gmpc:26433): Gmpc.Plugin.Manager-DEBUG: Initializing 'Database'
(gmpc:26433): Gmpc.Plugin.Manager-DEBUG: Initializing 'Play Queue'
(gmpc:26433): Gmpc.Plugin.Manager-DEBUG: Initializing 'Упрощённые команды Gmpc'
(gmpc:26433): Gmpc.Plugin.Manager-DEBUG: Initializing 'Search Browser'
(gmpc:26433): Gmpc.Plugin.Manager-DEBUG: Initializing 'Connection'
(gmpc:26433): Gmpc.Plugin.Manager-DEBUG: Initializing 'Server Settings'
(gmpc:26433): Gmpc.Plugin.Manager-DEBUG: Initializing 'Interface'
(gmpc:26433): Gmpc.Plugin.Manager-DEBUG: Initializing 'Tag based browser'
(gmpc:26433): Gmpc.Plugin.Manager-DEBUG: Initializing 'Multimedia Keys'
(gmpc:26433): Gmpc.Plugin.Manager-DEBUG: Initializing 'Notification'
(gmpc:26433): Gmpc.Plugin.Manager-DEBUG: Initializing 'Playlist Editor'
(gmpc:26433): Gmpc.Plugin.Manager-DEBUG: Initializing 'Server Information'
(gmpc:26433): Gmpc.Plugin.Manager-DEBUG: Initializing 'Metadata Handler'
(gmpc:26433): Gmpc.Plugin.Manager-DEBUG: Initializing 'Proxy'
(gmpc:26433): Gmpc.Plugin.Manager-DEBUG: Initializing 'Internal Extra Playlist 
View'
(gmpc:26433): Gmpc.Plugin.Manager-DEBUG: Initializing 'Metadata Browser'
(gmpc:26433): Gmpc.Plugin.Manager-DEBUG: Initializing 'Metadata pre-fetcher'
(gmpc:26433): Gmpc.Plugin.Manager-DEBUG: Initializing 'Database Update Tracker'
(gmpc:26433): Gmpc.Plugin.Manager-DEBUG: Initializing 'Now Playing'
(gmpc:26433): Gmpc.Plugin.Manager-DEBUG: Initializing 'Metadata Appearance'
(gmpc:26433): Gmpc.Plugin.Manager-DEBUG: Initializing 'Playlist3 Messages'
(gmpc:26433): Gmpc.Plugin.Manager-DEBUG: Initializing 'DiscoGS Artist and Album 
Image Fetcher (internal)'
(gmpc:26433): Gmpc.Plugin.Manager-DEBUG: Initializing 'Last FM metadata fetcher 
(internal)'
(gmpc:26433): Gmpc.Plugin.Manager-DEBUG: Initializing 'Music Tree Provider'
(gmpc:26433): Gmpc.Plugin.Manager-DEBUG: Initializing 'Home Theater Backdrops'
(gmpc:26433): Gmpc.Plugin.Manager-DEBUG: Initializing 'Backdrop Renderer'
(gmpc:26433): Gmpc.Plugin.Manager-DEBUG: Initializing 'Lyrics DB Plugin'
(gmpc:26433): Gmpc.Plugin.Manager-DEBUG: Initializing 'ChartLyrics Plugin'

(gmpc:26433): Gtk-WARNING **: Attempting to add a widget with type GtkImage to 
a GtkButton, but as a GtkBin subclass a GtkButton can only contain one widget 
at a time; it already contains a widget of type GtkLabel

(gmpc:26433): Gtk-WARNING **: Attempting to add a widget with type GtkImage to 
a GtkButton, but as a GtkBin subclass a GtkButton can only contain one widget 
at a time; it already contains a widget of type GtkLabel

(gmpc:26433): Gtk-WARNING **: Attempting to add a widget with type GtkImage to 
a GtkButton, but as a GtkBin subclass a GtkButton can only contain one widget 
at a time; it already contains a widget of type GtkLabel

(gmpc:26433): Gtk-WARNING **: Attempting to add a widget with type GtkImage to 
a GtkButton, but as a GtkBin subclass a GtkButton can only contain one widget 
at a time; it already contains a widget of type GtkLabel
29/11/11 13:21:11: WARNING: libmpd-player.c mpd_player_get_state():#34: not 
connected
(gmpc:26433): Gmpc.Favorites-DEBUG: gmpc-favorites.vala:42: Favorites object 
created
29/11/11 13:21:11: WARNING: libmpd-playlist.c 
mpd_playlist_get_current_song():#241: Not Connected
29/11/11 13:21:11: WARNING: libmpd-player.c mpd_player_get_state():#34: not 
connected
29/11/11 13:21:11: WARNING: libmpd-playlist.c

Bug#650359: Info received (Bug#650359: segmentation fault gmpc)

2011-11-29 Thread Dmitry E. Oboukhov 

Sorry. It eaten tail of log

...

(gmpc:27557): Gmpc.Plugin.Manager-DEBUG: Status changed plugin: DiscoGS Artist 
and Album Image Fetcher (internal)

(gmpc:27557): Gmpc.Plugin.Manager-DEBUG: Status changed plugin: Last FM 
metadata fetcher (internal)

(gmpc:27557): Gmpc.Plugin.Manager-DEBUG: Status changed plugin: Music Tree 
Provider

(gmpc:27557): Gmpc.Plugin.Manager-DEBUG: Status changed plugin: Home Theater 
Backdrops

(gmpc:27557): Gmpc.Plugin.Manager-DEBUG: Status changed plugin: Backdrop 
Renderer

(gmpc:27557): Gmpc.Plugin.Manager-DEBUG: Status changed plugin: Lyrics DB Plugin

(gmpc:27557): Gmpc.Plugin.Manager-DEBUG: Status changed plugin: ChartLyrics 
Plugin

(gmpc:27557): EasyDownload-DEBUG: Expected download length: 0
zsh: segmentation fault  gmpc --disable-plugins --debug-level 3
-- 

. ''`.   Dmitry E. Oboukhov
: :’  :   email: un...@debian.org jabber://un...@uvw.ru
`. `~’  GPGKey: 1024D / F8E26537 2006-11-21
  `- 1B23 D4F8 8EC0 D902 0555  E438 AB8C 00CF F8E2 6537


signature.asc
Description: Digital signature

Bug#650359: segmentation fault gmpc

2011-11-28 Thread Dmitry E. Oboukhov 
Package: gmpc
Version: 11.8.16-1
Severity: grave

Hi!

I've just upgraded gmpc upto 11.8.16-1. It always crashes.
The bug is reproducible in a few hosts (desktop, notebook, the other
desktop).

Backtrace:

apache:[~]$ gdb gmpc core
GNU gdb (GDB) 7.3-debian
Copyright (C) 2011 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later http://gnu.org/licenses/gpl.html
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type show copying
and show warranty for details.
This GDB was configured as x86_64-linux-gnu.
For bug reporting instructions, please see:
http://www.gnu.org/software/gdb/bugs/...
Reading symbols from /usr/bin/gmpc...Reading symbols from 
/usr/lib/debug/usr/bin/gmpc...done.
done.
[New LWP 22022]
[New LWP 22050]

warning: Can't read pathname for load map: Ошибка ввода/вывода.
[Thread debugging using libthread_db enabled]
Core was generated by `gmpc'.
Program terminated with signal 11, Segmentation fault.
#0  0x0046016c in gmpc_easy_handler_get_data_as_string (
handle=0x15158b0) at Tools/gmpc_easy_download.c:502
502 Tools/gmpc_easy_download.c: Нет такого файла или каталога.
in Tools/gmpc_easy_download.c
(gdb) bt
#0  0x0046016c in gmpc_easy_handler_get_data_as_string (
handle=0x15158b0) at Tools/gmpc_easy_download.c:502
#1  0x00470f3d in gmpc_provider_lyr_db_handle_download (d=0x1631d40, 
status=optimized out, handle=optimized out, self=0x12bf1c0)
at Providers/LyrDB.c:459
#2  _gmpc_provider_lyr_db_handle_download_gmpc_async_download_callback_vala (
handle=optimized out, status=optimized out, p=0x1631d40, 
self=0x12bf1c0) at Providers/LyrDB.c:495
#3  0x0045f85d in temp_callback (handle=optimized out, 
status=GEAD_DONE, user_data=0x12ce570) at Tools/gmpc_easy_download.c:611
#4  0x0045fbf0 in gmpc_easy_async_callback (session=optimized out, 
msg=optimized out, data=0x15158b0) at Tools/gmpc_easy_download.c:448
#5  0x7f19207a936a in ?? () from /usr/lib/libsoup-2.4.so.1
#6  0x7f19207a95c0 in ?? () from /usr/lib/libsoup-2.4.so.1
#7  0x7f19207a9c13 in ?? () from /usr/lib/libsoup-2.4.so.1
#8  0x7f191db9fedd in g_main_context_dispatch () from /lib/libglib-2.0.so.0
#9  0x7f191dba06b8 in ?? () from /lib/libglib-2.0.so.0
#10 0x7f191dba0cfa in g_main_loop_run () from /lib/libglib-2.0.so.0
#11 0x7f191f4fb717 in gtk_main ()
   from /usr/lib/x86_64-linux-gnu/libgtk-x11-2.0.so.0
#12 0x00428754 in main (argc=1, argv=0x7fff0545c348) at main.c:592
(gdb)
-- 

. ''`.   Dmitry E. Oboukhov
: :’  :   email: un...@debian.org jabber://un...@uvw.ru
`. `~’  GPGKey: 1024D / F8E26537 2006-11-21
  `- 1B23 D4F8 8EC0 D902 0555  E438 AB8C 00CF F8E2 6537


signature.asc
Description: Digital signature