Bug#657047: Is this FTBFS reproducible on hplip/3.12.2-1?
The attached patch should fix the build issue. The logic is : if readlink -f fails, then the link is absolute and the file is to be found in debian/tmp. This logic fixed the issue in the previous version of the package. Please test the patch and report back. Nicolas, thank you very much for this patch! When applied, hplip builds again in a pbuilder chroot. Unfortunately, I see some strange errors at the end of the build process: --8 dh_fixperms -a dh_makeshlibs -a dh_python2 -a --no-guessing-versions E: tools:94: cannot open debian/hplip/usr/sbin/hpssd E: tools:94: cannot open debian/hplip/usr/bin/hp-colorcal E: tools:94: cannot open debian/hplip/usr/bin/hp-hpdio E: tools:94: cannot open debian/hplip/usr/bin/hp-setup E: tools:94: cannot open debian/hplip/usr/bin/hp-testpage E: tools:94: cannot open debian/hplip/usr/bin/hp-unload E: tools:94: cannot open debian/hplip/usr/bin/hp-timedate E: tools:94: cannot open debian/hplip/usr/bin/hp-query E: tools:94: cannot open debian/hplip/usr/bin/hp-clean E: tools:94: cannot open debian/hplip/usr/bin/hp-plugin E: tools:94: cannot open debian/hplip/usr/bin/hp-scan E: tools:94: cannot open debian/hplip/usr/bin/hp-info E: tools:94: cannot open debian/hplip/usr/bin/hp-check E: tools:94: cannot open debian/hplip/usr/bin/hp-pkservice E: tools:94: cannot open debian/hplip/usr/bin/hp-firmware E: tools:94: cannot open debian/hplip/usr/bin/hp-probe E: tools:94: cannot open debian/hplip/usr/bin/hp-levels E: tools:94: cannot open debian/hplip/usr/bin/hp-makeuri E: tools:94: cannot open debian/hplip/usr/bin/hp-align dh_installdeb -a --8 I really wonder how hplip can correctly build in sid without Nicolas's patch when debian/tmp/usr/bin/hp-hpdio points to the non-existing /usr/share/hplip/hpdio.py Someone dare to explain? Best regards Ronny -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#657047: Is this FTBFS reproducible on hplip/3.12.2-1?
Hi, I came across this bug during the Paris BSP, and I could reproduce it in hplip/3.11.12-2. In the meantime, the maintainer made an upload of a new upstream release (hplip/3.12.2-1), and I can't reproduce the failure anymore. Would you care to check if you can reproduce the build failure? Thanks, -- Nicolas Dandrimont -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#657047: Is this FTBFS reproducible on hplip/3.12.2-1?
I came across this bug during the Paris BSP, and I could reproduce it in hplip/3.11.12-2. In the meantime, the maintainer made an upload of a new upstream release (hplip/3.12.2-1), and I can't reproduce the failure anymore. Would you care to check if you can reproduce the build failure? I just tried backporting hplip-3.12.2-1 to squeeze and the bug is still there when trying to build the package within a clean pbuilder chroot. Best regards Ronny Standtke -- erreichbar von Mo-Fr, Büro B.105 Fachhochschule Nordwestschweiz Pädagogische Hochschule Institut Weiterbildung und Beratung Ronny Standtke Dozent für Medienpädagogik Obere Sternengasse 7 4500 Solothurn T +41 32 628 67 08 M +41 79 786 81 82 F +41 32 627 28 64 ronny.stand...@fhnw.ch mailto:ronny.stand...@fhnw.ch http://www.imedias.ch -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#657047: Is this FTBFS reproducible on hplip/3.12.2-1?
tags 657047 + patch thanks Le 18/02/2012 à 19:06, Ronny Standtke ronny.stand...@fhnw.ch écrivit : I came across this bug during the Paris BSP, and I could reproduce it in hplip/3.11.12-2. In the meantime, the maintainer made an upload of a new upstream release (hplip/3.12.2-1), and I can't reproduce the failure anymore. Would you care to check if you can reproduce the build failure? I just tried backporting hplip-3.12.2-1 to squeeze and the bug is still there when trying to build the package within a clean pbuilder chroot. The attached patch should fix the build issue. The logic is : if readlink -f fails, then the link is absolute and the file is to be found in debian/tmp. This logic fixed the issue in the previous version of the package. Please test the patch and report back. Thanks, -- Nicolas Dandrimont diff -u hplip-3.12.2/debian/rules hplip-3.12.2/debian/rules --- hplip-3.12.2/debian/rules +++ hplip-3.12.2/debian/rules @@ -268,8 +268,12 @@ ln -s /usr/share/hplip/hpssd.py ./debian/tmp/usr/sbin/hpssd # Correct Python interpreter path in all executables - for file in ./debian/tmp/usr/bin/* ./debian/tmp/usr/sbin/* ./debian/tmp/usr/lib/cups/*/*; do \ - perl -p -i -e 's:^\s*\#\!/usr/bin/env\s+python.*:#!/usr/bin/python:' `readlink -f $$file`; \ + set -e; for file in ./debian/tmp/usr/bin/* ./debian/tmp/usr/sbin/* ./debian/tmp/usr/lib/cups/*/*; do \ + linkedfile=`readlink -f $$file || true`; \ + if test -z $$linkedfile; then \ + linkedfile=$(CURDIR)/debian/tmp/`readlink $$file`; \ + fi; \ + perl -p -i -e 's:^\s*\#\!/usr/bin/env\s+python.*:#!/usr/bin/python:' $$linkedfile; \ done # Remove all *.pyc files, they do not need to be shipped with the diff -u hplip-3.12.2/debian/changelog hplip-3.12.2/debian/changelog --- hplip-3.12.2/debian/changelog +++ hplip-3.12.2/debian/changelog @@ -1,3 +1,10 @@ +hplip (3.12.2-1.1) unstable; urgency=low + + * Non-maintainer upload. + * Fix FTBFS in pbuilder (Closes: #657047) + + -- Nicolas Dandrimont nicolas.dandrim...@crans.org Sat, 18 Feb 2012 19:40:06 +0100 + hplip (3.12.2-1) unstable; urgency=low * New Upstream Release
