Bug#665221: Dancer-Plugin-Database bug + testcase
On Tue, 26 Jun 2012 05:23:41 +0200 intrigeri intrig...@boum.org wrote: OK. Then, I think we'll probably need to ask for a freeze exception. Therefore, it would help us (the Debian Perl Group) a lot if the minimal changes to fix this specific serious bug were well isolated, so that we can backport them independently and leave other changes alone. Just so you know, what would be perfect for us would be a bugfix-only release, but please don't make your life a pain because of us :) But perhaps a couple of days will end *before* the Wheezy freeze, who knows. I'm looking for a decent safe fix now; if I find one, I'll get a new release out tonight, hopefully that's not too late. If I do, I'll provide a link to the commit(s) which fix the issue, in case you need to backport only the changes. -- David Precious (bigpresh) dav...@preshweb.co.uk http://www.preshweb.co.uk/ www.preshweb.co.uk/twitter www.preshweb.co.uk/linkedinwww.preshweb.co.uk/facebook www.preshweb.co.uk/cpanwww.preshweb.co.uk/github -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#665221: Dancer-Plugin-Database bug + testcase
David Precious wrote (28 Jun 2012 18:42:19 GMT) : I'm looking for a decent safe fix now; if I find one, I'll get a new release out tonight, hopefully that's not too late. Tonight would be perfect. Thanks for working on it. If I do, I'll provide a link to the commit(s) which fix the issue, in case you need to backport only the changes. Emailing me and 665...@bugs.debian.org would be perfect :) -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#665221: Dancer-Plugin-Database bug + testcase
On Thu, 28 Jun 2012 21:24:03 +0200 intrigeri intrig...@boum.org wrote: David Precious wrote (28 Jun 2012 18:42:19 GMT) : I'm looking for a decent safe fix now; if I find one, I'll get a new release out tonight, hopefully that's not too late. Tonight would be perfect. Thanks for working on it. If I do, I'll provide a link to the commit(s) which fix the issue, in case you need to backport only the changes. Emailing me and 665...@bugs.debian.org would be perfect :) Version 1.82 just headed to CPAN, containing a simple fix for this issue. The actual fix was: https://github.com/bigpresh/Dancer-Plugin-Database/commit/85e8cd06ff When caching a handle, if we were given a hashref of settings, we cache a reference to that hashref, too - so the original hashref of settings doesn't go out of scope while the handle is still cached. This simple change should do the job! Many thanks for reporting this issue to me and prompting me for a fix before Wheezy :) -- David Precious (bigpresh) dav...@preshweb.co.uk http://www.preshweb.co.uk/ www.preshweb.co.uk/twitter www.preshweb.co.uk/linkedinwww.preshweb.co.uk/facebook www.preshweb.co.uk/cpanwww.preshweb.co.uk/github -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#665221: Dancer-Plugin-Database bug + testcase
David Precious wrote (28 Jun 2012 20:18:58 GMT) : Version 1.82 just headed to CPAN, containing a simple fix for this issue. That's perfect. I just uploaded it to Debian. Thanks a lot! -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#665221: Dancer-Plugin-Database bug + testcase
On Sat, 23 Jun 2012 21:05:12 +0200 intrigeri intrig...@boum.org wrote: Hi David, intrigeri wrote (10 Jun 2012 17:49:39 GMT) : [0] http://bugs.debian.org/665221 [1] https://github.com/bigpresh/Dancer-Plugin-Database/issues/29 I've seen you have replied on GitHub two weeks ago. Great! Do you think you'll be able to fix this in the next few days, or shall we workaround it to ship Dancer-Plugin-Database in Debian Wheezy? I'll do my best to get it sorted out tomorrow, thanks for the poke. I may have to release a dev version to CPAN and wait a couple of days for tester reports, though, as it'll change how the module currently caches handles, and I really don't want to risk breaking things for people. Cheers Dave P -- David Precious (bigpresh) dav...@preshweb.co.uk http://www.preshweb.co.uk/ www.preshweb.co.uk/twitter www.preshweb.co.uk/linkedinwww.preshweb.co.uk/facebook www.preshweb.co.uk/cpanwww.preshweb.co.uk/github -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#665221: Dancer-Plugin-Database bug + testcase
Hi David, David Precious wrote (25 Jun 2012 18:51:46 GMT) : I'll do my best to get it sorted out tomorrow, thanks for the poke. Great! I may have to release a dev version to CPAN and wait a couple of days for tester reports, though, as it'll change how the module currently caches handles, and I really don't want to risk breaking things for people. OK. Then, I think we'll probably need to ask for a freeze exception. Therefore, it would help us (the Debian Perl Group) a lot if the minimal changes to fix this specific serious bug were well isolated, so that we can backport them independently and leave other changes alone. Just so you know, what would be perfect for us would be a bugfix-only release, but please don't make your life a pain because of us :) But perhaps a couple of days will end *before* the Wheezy freeze, who knows. Cheers, -- intrigeri | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#665221: Dancer-Plugin-Database bug + testcase
Hi David, intrigeri wrote (10 Jun 2012 17:49:39 GMT) : [0] http://bugs.debian.org/665221 [1] https://github.com/bigpresh/Dancer-Plugin-Database/issues/29 I've seen you have replied on GitHub two weeks ago. Great! Do you think you'll be able to fix this in the next few days, or shall we workaround it to ship Dancer-Plugin-Database in Debian Wheezy? -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#665221: Dancer-Plugin-Database bug + testcase
Hi David, while debugging a test failure that was reported to Debian [0] and on Github [1] a few months ago, a bug was uncovered, which is described, along with a minimal test case along with some thoughts about possible fixes. [0] http://bugs.debian.org/665221 [1] https://github.com/bigpresh/Dancer-Plugin-Database/issues/29 Not knowing how closely you monitor the issue tracker on Github, we at the Debian Perl team thought it would be useful to point you at this specific issue. Do you think you'll be able to fix this shortly, or shall we workaround it to ship this package in Debian Wheezy? Thank you for writing Dancer-Plugin-Database! Cheers, -- intrigeri | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
