Bug#686731: edos-distcheck: Stopped to work
reassign 686731 python-debian notfound 686731 debian-python/0.1.21+nmu1 found 686731 python-debian/0.1.21+nmu1 thanks edos-distcheck should be changed to use if field in src: rather than if src.has_key(field): - the latter syntax will not work in Python 3. However, the regression in the Python 2 case is clearly a bug in my NMU, which I'll fix. -- Colin Watson [cjwat...@debian.org] -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Processed: Re: Bug#686731: edos-distcheck: Stopped to work
Processing commands for cont...@bugs.debian.org: reassign 686731 python-debian Bug #686731 [debian-python] edos-distcheck: Stopped to work Warning: Unknown package 'debian-python' Bug reassigned from package 'debian-python' to 'python-debian'. No longer marked as found in versions debian-python/0.1.21+nmu1. Ignoring request to alter fixed versions of bug #686731 to the same values previously set notfound 686731 debian-python/0.1.21+nmu1 Bug #686731 [python-debian] edos-distcheck: Stopped to work The source debian-python and version 0.1.21+nmu1 do not appear to match any binary packages Ignoring request to alter found versions of bug #686731 to the same values previously set found 686731 python-debian/0.1.21+nmu1 Bug #686731 [python-debian] edos-distcheck: Stopped to work The source python-debian and version 0.1.21+nmu1 do not appear to match any binary packages Marked as found in versions python-debian/0.1.21+nmu1. thanks Stopping processing here. Please contact me if you need assistance. -- 686731: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=686731 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#686731: edos-distcheck: Stopped to work
Dear python-debian maintainers, here's my NMU diff for this bug, which I've also pushed to my python3 git branch. I've uploaded this without delay since it's a regression. diff -Nru python-debian-0.1.21+nmu1/debian/changelog python-debian-0.1.21+nmu2/debian/changelog --- python-debian-0.1.21+nmu1/debian/changelog 2012-08-22 16:27:06.0 +0100 +++ python-debian-0.1.21+nmu2/debian/changelog 2012-09-05 11:29:00.0 +0100 @@ -1,3 +1,11 @@ +python-debian (0.1.21+nmu2) unstable; urgency=low + + * Non-maintainer upload. + * In Python 2, restore Deb822Dict.has_key method for compatibility. +(Closes: #686731) + + -- Colin Watson cjwat...@debian.org Wed, 05 Sep 2012 11:28:58 +0100 + python-debian (0.1.21+nmu1) unstable; urgency=low * Non-maintainer upload. diff -Nru python-debian-0.1.21+nmu1/lib/debian/deb822.py python-debian-0.1.21+nmu2/lib/debian/deb822.py --- python-debian-0.1.21+nmu1/lib/debian/deb822.py 2012-08-22 16:26:15.0 +0100 +++ python-debian-0.1.21+nmu2/lib/debian/deb822.py 2012-09-05 11:17:38.0 +0100 @@ -270,7 +270,10 @@ def __contains__(self, key): key = _strI(key) return key in self.__keys - + +if sys.version '3': +has_key = __contains__ + ### END _mutable_mapping_mixin methods def __repr__(self): Thanks, -- Colin Watson [cjwat...@debian.org] -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#686731: edos-distcheck: Stopped to work
clone 686731 -1 reassign -1 edos-distcheck retitle -1 add-sources.py should use forward compatible in syntax instead of has_key severity -1 wishlist tags -1 + pending thanks On Wed, Sep 05, 2012 at 11:20:10AM +0100, Colin Watson wrote: edos-distcheck should be changed to use if field in src: rather than if src.has_key(field): - the latter syntax will not work in Python 3. Thanks for noticing, I've just pushed a fix for that to edos-distcheck Git repo. (Debian OCamlers: I've tested it and it seems to work properly, but more testing is welcome!) However, the regression in the Python 2 case is clearly a bug in my NMU, which I'll fix. And while we're at it: thanks also for your python-debian NMU, without which we would still be without a Python 3 port of it. Regression happens when doing stuff: they're no big deal, especially when someone is as quick as you've been in cleaning up after them :-) Cheers. -- Stefano Zacchiroli . . . . . . . z...@upsilon.cc . . . . o . . . o . o Maître de conférences . . . . . http://upsilon.cc/zack . . . o . . . o o Debian Project Leader . . . . . . @zack on identi.ca . . o o o . . . o . « the first rule of tautology club is the first rule of tautology club » signature.asc Description: Digital signature
Processed: Re: Bug#686731: edos-distcheck: Stopped to work
Processing commands for cont...@bugs.debian.org:
clone 686731 -1
Bug #686731 {Done: Colin Watson cjwat...@debian.org} [python-debian]
edos-builddebcheck: Stopped working
Bug 686731 cloned as bug 686759
reassign -1 edos-distcheck
Bug #686759 {Done: Colin Watson cjwat...@debian.org} [python-debian]
edos-builddebcheck: Stopped working
Bug reassigned from package 'python-debian' to 'edos-distcheck'.
No longer marked as found in versions python-debian/0.1.21+nmu1.
No longer marked as fixed in versions python-debian/0.1.21+nmu2.
retitle -1 add-sources.py should use forward compatible in syntax instead
of has_key
Bug #686759 {Done: Colin Watson cjwat...@debian.org} [edos-distcheck]
edos-builddebcheck: Stopped working
Changed Bug title to 'add-sources.py should use forward compatible in syntax
instead of has_key' from 'edos-builddebcheck: Stopped working'
severity -1 wishlist
Bug #686759 {Done: Colin Watson cjwat...@debian.org} [edos-distcheck]
add-sources.py should use forward compatible in syntax instead of has_key
Severity set to 'wishlist' from 'serious'
tags -1 + pending
Bug #686759 {Done: Colin Watson cjwat...@debian.org} [edos-distcheck]
add-sources.py should use forward compatible in syntax instead of has_key
Added tag(s) pending.
thanks
Stopping processing here.
Please contact me if you need assistance.
--
686731: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=686731
686759: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=686759
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
