Bug#689332: bind9 uses shipped file as statefile

2013-01-22 Thread Adam D. Barratt
Hi,

I was looking at the bind9 -4 upload for a potential unblock and was
about to query some of the changes in this patch when I noticed that
Julien already did so a while ago.

On Mon, 2013-01-07 at 22:34 +0100, Julien Cristau wrote:
 On Tue, Oct 16, 2012 at 04:24:05 -0400, Michael Gilbert wrote:
  Hi, I've attached a proposed patch that moves the state file to /var/lib.
  
 I'm not sure that patch really fixes anything.  Also it doesn't seem
 like the file is removed by any of the maintainer scripts on package
 removal, so if anything it'll make postrm fail to rmdir /var/lib/bind.

The changes included in the package remove the file on purge.

Looking more closely, it appears that the wheezy packages don't ship the
file in any case, which means that the original bug doesn't apply there
afaics.

This change:

 # no sumfile means you get the default
-[ -f /usr/share/bind9/bind9-default.md5sum ] || 
-echo 2cfcfb7bf1b99c7930fd475907e38be7  /etc/default/bind9  
/usr/share/bind9/bind9-default.md5sum
+[ -f /var/lib/bind/bind9-default.md5sum ] || 
+echo 2cfcfb7bf1b99c7930fd475907e38be7  /etc/default/bind9  
/var/lib/bind/bind9-default.md5sum

also means that the md5sum will always be recreated on the first upgrade
from any version of the package which uses the file from /usr,
potentially causing the check to produce the wrong result.

Regards,

Adam


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#689332: bind9 uses shipped file as statefile

2013-01-07 Thread Julien Cristau
On Tue, Oct 16, 2012 at 04:24:05 -0400, Michael Gilbert wrote:

 control: tag -1 patch
 
 Hi, I've attached a proposed patch that moves the state file to /var/lib.
 
I'm not sure that patch really fixes anything.  Also it doesn't seem
like the file is removed by any of the maintainer scripts on package
removal, so if anything it'll make postrm fail to rmdir /var/lib/bind.

Cheers,
Julien


signature.asc
Description: Digital signature


Bug#689332: bind9 uses shipped file as statefile

2012-10-16 Thread Michael Gilbert
control: tag -1 patch

Hi, I've attached a proposed patch that moves the state file to /var/lib.

Best wishes,
Mike


bind.patch
Description: Binary data