Bug#694676: Bug#693472: emacsen-common, emacs23: many emacs addons fail to install if emacs22 (lenny) is still installed

2012-12-21 Thread Agustin Martin
On Mon, Dec 03, 2012 at 11:47:54PM +0100, Milan Zamazal wrote:
  AM == Agustin Martin agmar...@debian.org writes:
 
 AM I am attaching a patch that may help here with speechd-el. For
 AM emacs21 and emacs22 it checks if a standalone eieio package is
 AM installed and otherwise warns and skips byte-compilation for
 AM that flavour.
 
 Thanks for the patch.  Nevertheless I dropped support for old Emacsen
 completely as current speechd-el should be run on Emacs = 23.2.  The
 compilation would still fail with Emacs 23.1 but that one is not a part
 of any official Debian release, so I didn't bother to handle it.

Thanks for the info. I considered doing something similar, but since I
did not know that speechd-el no longer works with older emacsen I proposed
the conservative way.

Also, seems something went wrong when closing this bug report from
the changelog. Bug was reopened before uploading to sid, but was not closed
later with a newer upload version.

However, bug report seems fixed. Is this true? 

Regards,

-- 
Agustin


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#694676: Bug#693472: emacsen-common, emacs23: many emacs addons fail to install if emacs22 (lenny) is still installed

2012-12-03 Thread Agustin Martin
tag 694676 +patch
thanks

On Sat, Dec 01, 2012 at 06:13:25PM +0100, Agustin Martin wrote:
 Loading /usr/share/emacs22/site-lisp/speechd-el/speechd-braille.el (source)...
 Cannot open load file: eieio
 make: *** [braille.elc] Error 255
 ERROR: install script from speechd-el package failed
 
 diffferent than in original bug report, but reproducible here. I am
 afraid that the simple solution is to make speechd-el not build for
 emacs22.

I am attaching a patch that may help here with speechd-el. For emacs21 and
emacs22 it checks if a standalone eieio package is installed and otherwise
warns and skips byte-compilation for that flavour.

On Sat, Dec 01, 2012 at 08:50:59PM +0100, Andreas Beckmann wrote:
 PS: if you upload packages that are supposed to fix these issues
 somewhere I can run them through my piuparts tests before they get
 uploaded to the archive

Thanks,

I have put an experimental package with that change at

http://people.debian.org/~agmartin/debian-store/experimental/

or if you prefer in repo way, at

deb http://people.debian.org/~agmartin/debian-store/experimental/ ./

Repo is signed with my key. 

Although the experimental package is created as a NMU, I'd prefer a regular
upload by speechd-el maintainer (Hi, Milan). I will only consider uploading
it if there is no reply in a reasonable time period.

Regards,

-- 
Agustin
diff --git a/debian/speechd-el.emacsen-install b/debian/speechd-el.emacsen-install
index fb7dfd7..d940e07 100755
--- a/debian/speechd-el.emacsen-install
+++ b/debian/speechd-el.emacsen-install
@@ -13,6 +13,23 @@ ELC_DIR=/usr/share/${FLAVOR}/site-lisp/$PACKAGE
 if [ ${FLAVOR} = emacs23 ] || [ ${FLAVOR} = emacs22 ] || [ ${FLAVOR} = emacs21 ] || [ ${FLAVOR} = emacs-snapshot ]; then
   echo install/$PACKAGE: byte-compiling for ${FLAVOR}...
 
+  # eieio is integrated in emacs23, conflicting with standalone eieio
+  # package. This makes impossible to use this package with
+  # e.g. emacs22 and a standalone eieio package if emacs23 is
+  # installed (#694676). Check if eieio sources are available when
+  # byte-compiling for emacs21 or emacs22. This should help use of this
+  # package in ancient boxes.
+  case ${FLAVOR} in
+  emacs21|emacs22)
+	  if [ ! -d /usr/share/emacs/site-lisp/eieio ]; then
+	  echo install/$PACKAGE: No standalone eieio package available for ${FLAVOR}. Skipping ...
+	  exit 0
+	  fi
+	  ;;
+  *)
+
+  esac
+
   # Copy the temp .el files
   if [ ! -d ${ELC_DIR} ]; then
 mkdir ${ELC_DIR}


Bug#694676: Bug#693472: emacsen-common, emacs23: many emacs addons fail to install if emacs22 (lenny) is still installed

2012-12-03 Thread Milan Zamazal
 AM == Agustin Martin agmar...@debian.org writes:

AM I am attaching a patch that may help here with speechd-el. For
AM emacs21 and emacs22 it checks if a standalone eieio package is
AM installed and otherwise warns and skips byte-compilation for
AM that flavour.

Thanks for the patch.  Nevertheless I dropped support for old Emacsen
completely as current speechd-el should be run on Emacs = 23.2.  The
compilation would still fail with Emacs 23.1 but that one is not a part
of any official Debian release, so I didn't bother to handle it.


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org