Processed: Re: Bug#722159: doesn't seem to work with perl 5.18
Processing commands for cont...@bugs.debian.org: tags 722159 patch Bug #722159 [spampd] doesn't seem to work with perl 5.18 Ignoring request to alter tags of bug #722159 to the same tags previously set thanks Stopping processing here. Please contact me if you need assistance. -- 722159: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=722159 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#722159: doesn't seem to work with perl 5.18
tags 722159 patch
thanks
On Mon, Sep 09, 2013 at 05:39:09PM +0200, gregor herrmann wrote:
Too bad, thanks for checking.
I've added this information to the Github issue now.
I finally found some time debugging and fixing it myself. Here's a patch.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes at gmail dot com
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL
--- spampd 2013-11-04 16:03:52.0 +0100
+++ /usr/sbin/spampd 2013-11-04 16:05:05.0 +0100
@@ -900,6 +900,22 @@
usage(0);
}
+# Untaint some options provided by admin command line.
+$pidfile =~ /^(.*)$/;
+$pidfile = $1;
+
+$relayhost =~ /^(.*)$/;
+$relayhost = $1;
+
+$relayport =~ /^(.*)$/;
+$relayport = $1;
+
+$host =~ /^(.*)$/;
+$host = $1;
+
+$port =~ /^(.*)$/;
+$port = $1;
+
if ( $options{tagall} ) { $tagall = 1; }
if ( $options{'log-rules-hit'} ) { $rh = 1; }
if ( $options{debug} ) { $debug = 1; $nsloglevel = 4; }
Bug#722159: doesn't seem to work with perl 5.18
On Sun, Sep 08, 2013 at 11:55:08PM +0200, gregor herrmann wrote: There's a patch upstream which would need a test and some feedback: https://github.com/mpaperno/spampd/issues/2 https://github.com/mpaperno/spampd/commit/1fe20e4c0f06760eb341b519c32954bfc9ef7a15 Doesn't make a difference. That patch does not fix the problem. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org Jabber: michael.meskes at gmail dot com VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#722159: doesn't seem to work with perl 5.18
On Mon, 09 Sep 2013 10:09:59 +0200, Michael Meskes wrote: On Sun, Sep 08, 2013 at 11:55:08PM +0200, gregor herrmann wrote: There's a patch upstream which would need a test and some feedback: https://github.com/mpaperno/spampd/issues/2 https://github.com/mpaperno/spampd/commit/1fe20e4c0f06760eb341b519c32954bfc9ef7a15 Doesn't make a difference. That patch does not fix the problem. Too bad, thanks for checking. I've added this information to the Github issue now. (Maybe you could try to work this out together? Copypasting between the Debian BTS and github seems a bit inefficient ...) Cheers, gregor -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/ `. `' Member of VIBE!AT SPI, fellow of the Free Software Foundation Europe `- NP: Steppenwolf: Renegade signature.asc Description: Digital signature
Bug#722159: doesn't seem to work with perl 5.18
Package: spampd Version: 2.30-22.1 Severity: grave I'm running an up-to-date testing system on which I had to install a couple packages from unstable to be able to update perl (makes me wonder how it made it into testing, but anyhow). Now this morning spampd was restarted by cron script and didn't make it up again with the following being logged: Sep 8 17:53:05 trantor spampd[3693]: Process Backgrounded Sep 8 17:53:05 trantor spampd[3693]: 2013/09/08-17:53:05 Insecure dependency in open while running with -T switch at /usr/share/perl5/Net/Server/Daemonize.pm line 75.#012#012 at line 180 in file /usr/share/perl5/Net/Server.pm Sep 8 17:53:05 trantor spampd[3693]: 2013/09/08-17:53:05 Server closing! Needless to say that removing the -T option in spampd's shebang made it run again, albeit I'm not sure about security. I'm not sure where exactly the problem lies, but it damn sure made my email processing come to a halt. Michael -- System Information: Debian Release: jessie/sid APT prefers testing-proposed-updates APT policy: (500, 'testing-proposed-updates'), (500, 'testing'), (500, 'stable') Architecture: i386 (i686) Kernel: Linux 3.10-2-686-pae (SMP w/1 CPU core) Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages spampd depends on: ii adduser 3.113+nmu3 ii dpkg1.16.10 ii libnet-server-perl 2.007-3 ii lsb-base4.1+Debian12 ii perl5.18.1-3 ii spamassassin3.3.2-6 spampd recommends no packages. spampd suggests no packages. -- Configuration Files: /etc/default/spampd changed [not included] /etc/spampd.conf [Errno 13] Keine Berechtigung: u'/etc/spampd.conf' -- no debconf information -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#722159: doesn't seem to work with perl 5.18
On Sun, 08 Sep 2013 18:08:23 +0200, Michael Meskes wrote: Sep 8 17:53:05 trantor spampd[3693]: Process Backgrounded Sep 8 17:53:05 trantor spampd[3693]: 2013/09/08-17:53:05 Insecure dependency in open while running with -T switch at /usr/share/perl5/Net/Server/Daemonize.pm line 75.#012#012 at line 180 in file /usr/share/perl5/Net/Server.pm Sep 8 17:53:05 trantor spampd[3693]: 2013/09/08-17:53:05 Server closing! Sounds like #722136 in postgrey. Cheers, gregor, going to forward the bug upstream now -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/ `. `' Member of VIBE!AT SPI, fellow of the Free Software Foundation Europe `- NP: Aimee Mann: How Am I Different signature.asc Description: Digital signature
Processed: Re: Bug#722159: doesn't seem to work with perl 5.18
Processing control commands: tag -1 + upstream patch Bug #722159 [spampd] doesn't seem to work with perl 5.18 Added tag(s) upstream and patch. -- 722159: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=722159 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#722159: doesn't seem to work with perl 5.18
Control: tag -1 + upstream patch On Sun, 08 Sep 2013 19:18:13 +0200, gregor herrmann wrote: On Sun, 08 Sep 2013 18:08:23 +0200, Michael Meskes wrote: Sep 8 17:53:05 trantor spampd[3693]: Process Backgrounded Sep 8 17:53:05 trantor spampd[3693]: 2013/09/08-17:53:05 Insecure dependency in open while running with -T switch at /usr/share/perl5/Net/Server/Daemonize.pm line 75.#012#012 at line 180 in file /usr/share/perl5/Net/Server.pm Sep 8 17:53:05 trantor spampd[3693]: 2013/09/08-17:53:05 Server closing! Sounds like #722136 in postgrey. Cheers, gregor, going to forward the bug upstream now There's a patch upstream which would need a test and some feedback: https://github.com/mpaperno/spampd/issues/2 https://github.com/mpaperno/spampd/commit/1fe20e4c0f06760eb341b519c32954bfc9ef7a15 Cheers, gregor -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/ `. `' Member of VIBE!AT SPI, fellow of the Free Software Foundation Europe `- signature.asc Description: Digital signature
