Bug#725999: [Pkg-salt-team] Bug#725999: salt: fails to ship source and incomplete debian/copyright

2013-10-21 Thread Luke Faraone
On 10 October 2013 20:39, Joe Healy joehe...@gmail.com wrote:

 If I do the second, we would still ship a (unused) version of jQuery
 in the orig.tar.gz, however, it would not be present in the .deb. As
 such, it should still be mentioned in the debian/copyright. Is this
 correct?


Yes. If you don't want to modify the upstream tarball this is then the
recommended approach.

-- 

Luke Faraone;; Debian  Ubuntu Developer; Sugar Labs; MIT SIPB
lfaraone on irc.[freenode,oftc].net -- https://luke.wf/ohhello
PGP fprint: 5189 2A7D 16D0 49BB 046B  DC77 9732 5DD8 F9FD D506


Bug#725999: [Pkg-salt-team] Bug#725999: salt: fails to ship source and incomplete debian/copyright

2013-10-21 Thread Joe Healy
On Mon, Oct 21, 2013 at 06:01:58AM -0400, Luke Faraone wrote:
 Yes. If you don't want to modify the upstream tarball this is then the
 recommended approach.

Thanks Luke, it turns out I need to modify the upstream tarball as
there are non DFSG files (fonts) in there.

So I'll remove these files and patch to use the versions packaged by
debian.

Thanks,

Joe


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#725999: [Pkg-salt-team] Bug#725999: salt: fails to ship source and incomplete debian/copyright

2013-10-10 Thread Joe Healy
Thanks for picking these up and apologies for letting them through.

On Thu, Oct 10, 2013 at 08:05:18PM -0400, Luke Faraone wrote:
 
 Please document
 ../doc/_themes/saltstack/static/css/bootstrap-responsive.css in
 debian/copyright.

Will do.

 
 Please also recreate the minified versions during your package build,
 don't just accept the ones generated by upstream.

Will do.

 
 You do not ship the source for
 ../doc/_themes/saltstack/static/js/vendor/modernizr-2.6.2-respond-1.1.0.min.js
 at all, which is patently unacceptable.

Agreed. Is it acceptable to add the source in via a quilt patch then
build the minified version? or is there a better approach?

 
 This package embeds jQuery, which is suboptimal as jQuery is packaged in
 Debian. Regardless, it must be mentioned in debian/copyright.
 

My understanding is that there are two approaches I could use here. I
could rebuild the upstream .tar.gz without jQuery (and the others) or
I could depend on the debian jQuery and patch the documentation to use
the debian jQuery.

If I do the second, we would still ship a (unused) version of jQuery
in the orig.tar.gz, however, it would not be present in the .deb. As
such, it should still be mentioned in the debian/copyright. Is this
correct?

I'm not thrilled by either option (upstream not including it/them
would be best), but am leaning towards not modifying the orig.tar.gz
as at this stage, I believe the contentious files are all (able to be)
DFSG compliant.

Thanks for your assistance.

Joe


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org