Bug#730488: dicoweb: broken with Django 1.4

2013-11-25 Thread Marc Dequènes (Duck) 

Package: dicoweb
Version: 2.2-3
Severity: grave


With recent Django versions in Debian, dicoweb is broken.

I spotted the following problems which can be solved easily to have a
working version:

1) new-style 'url' tag (see
https://docs.djangoproject.com/en/1.5/releases/1.5/)
fix in /etc/dicoweb/templates/base.html by quoting the route name ({%
url opensearch %})

2) « ImproperlyConfigured: If set, MEDIA_URL must end with a slash »
/etc/dicoweb/settings.py needs to be fixed

3) django.conf.urls.defaults is deprecated, use django.conf.urls
/usr/share/dicoweb/urls.py needs to be fixed

Nevertheless, having a program also working on older versions would
need more work.

Regards.

--
Marc Dequènes (Duck)



pgpY5Ab4v4uyk.pgp
Description: PGP Digital Signature

Bug#730488: dicoweb: broken with Django 1.4

2013-11-25 Thread أحمد المحمودي 
On Mon, Nov 25, 2013 at 04:41:49PM +, Marc Dequènes (Duck) wrote:
 1) new-style 'url' tag (see
 https://docs.djangoproject.com/en/1.5/releases/1.5/)
 fix in /etc/dicoweb/templates/base.html by quoting the route name ({%
 url opensearch %})

  So the line should be:

  href={% url 'opensearch' %}

  right ?

 2) « ImproperlyConfigured: If set, MEDIA_URL must end with a slash »
 /etc/dicoweb/settings.py needs to be fixed

  MEDIA_URL = 'static/' ?

 Nevertheless, having a program also working on older versions would
 need more work.

  Please clarify what you mean here.

-- 
 ‎أحمد المحمودي (Ahmed El-Mahmoudy)
  Digital design engineer
 GPG KeyID: 0xEDDDA1B7
 GPG Fingerprint: 8206 A196 2084 7E6D 0DF8  B176 BC19 6A94 EDDD A1B7


signature.asc
Description: Digital signature

Bug#730488: dicoweb: broken with Django 1.4

2013-11-25 Thread Marc Dequènes (Duck) 


Quoting أحمد المحمودي aelmahmo...@sabily.org:


  href={% url 'opensearch' %}


quoting, single or double (i used double in my tests).


  MEDIA_URL = 'static/' ?


yes


Sorry i had no time to prepare a proper patch.



Nevertheless, having a program also working on older versions would
need more work.


  Please clarify what you mean here.


I guess upstream would be willing to have conditionals in order to
support newer and older Django versions with the same code, thus a
basic patch is ok for Debian and as example, but they may have
additional work.

Regards.

--
Marc Dequènes (Duck)



pgpMsl4ay3f6O.pgp
Description: PGP Digital Signature