2014-03-08 16:21 GMT+00:00 Manuel A. Fernandez Montecelo
manuel.montez...@gmail.com:
Hi,
I'm planning to NMU this because affects my package razorqt.
I would like to do it ASAP since this is already failing for 2 months
and the fix seems straightforward (but still testing it), if possible
this weekend (if you reply and agree), or otherwise upload to delayed
queue.
Tested in powerpc porterbox, diffs of patch and NMU attached, and uploaded.
I decided to upload immediately (hope that it's OK, it abides to the
guidelines in [1]), the urgency being because:
a) the package never built in most of the architectures since the last
upload with the new upstream version, more than 2 months ago, and the
change is unlikely to break anything;
b) this RC bug has been submitted shortly thereafter and also not
fixed, triaged or has any comments for more than 2 months (so there's
no indication that it's being worked on);
c) the last version (new upstream) introduced a transition that made
rev-depends FTBFS in the first place;
d) at least my package, which depends on this, is going to be
auto-removed from testing in the couple of weeks because of this if
not fixed, so I want to get both libstatsgrab and my package razorqt
fixed and migrated to testing before the autoremoval happens;
e) and crucially, the change is quite trivial and minimal, and should
not cause any breakage by itself; but if it does I want to fix it ASAP
(e.g. this weekend better than during the week).
Cheers.
[1]
http://www.debian.org/doc/manuals/developers-reference/pkgs.html#nmu-guidelines
--
Manuel A. Fernandez Montecelo manuel.montez...@gmail.com
diff -Nru libstatgrab-0.90/debian/changelog libstatgrab-0.90/debian/changelog
--- libstatgrab-0.90/debian/changelog 2013-12-25 18:30:19.0 +
+++ libstatgrab-0.90/debian/changelog 2014-03-08 17:53:09.0 +
@@ -1,3 +1,11 @@
+libstatgrab (0.90-1.1) unstable; urgency=high
+
+ * Non-maintainer upload.
+ * Fix tests causing FTBFS in some arches due to failing to find
+/etc/mtab fix-ftbfs-734368.patch (Closes: #734368)
+
+ -- Manuel A. Fernandez Montecelo m...@debian.org Sat, 08 Mar 2014 16:42:36
+
+
libstatgrab (0.90-1) unstable; urgency=low
* New upstream version.
diff -Nru libstatgrab-0.90/debian/patches/fix-ftbfs-734368.patch
libstatgrab-0.90/debian/patches/fix-ftbfs-734368.patch
--- libstatgrab-0.90/debian/patches/fix-ftbfs-734368.patch 1970-01-01
01:00:00.0 +0100
+++ libstatgrab-0.90/debian/patches/fix-ftbfs-734368.patch 2014-03-08
17:10:11.0 +
@@ -0,0 +1,18 @@
+Description: Fix FTBFS in many arches due to FS tests
+ The cause is that it cannot find /etc/mtab (or equivalent) in some arches.
The
+ new standard place for this is '/proc/self/mounts'. ./configure
+ --with-mnttab='/proc/self/mounts' does not seem to work.
+Author: Manuel A. Fernandez Montecelo m...@debian.org
+Last-Update: 2014-03-08
+Bug-Debian: http://bugs.debian.org/734368
+--- a/src/libstatgrab/disk_stats.c
b/src/libstatgrab/disk_stats.c
+@@ -807,7 +807,7 @@
+ # endif
+ # endif
+ # ifndef MNT_MNTTAB
+- static const char *mnttabs[] = { /etc/mnttab, /etc/mtab };
++ static const char *mnttabs[] = { /proc/self/mounts, /etc/mnttab,
/etc/mtab };
+ unsigned i;
+ # endif
+ #elif defined(WIN32)
diff -Nru libstatgrab-0.90/debian/patches/series
libstatgrab-0.90/debian/patches/series
--- libstatgrab-0.90/debian/patches/series 1970-01-01 01:00:00.0
+0100
+++ libstatgrab-0.90/debian/patches/series 2014-03-08 13:45:08.0
+
@@ -0,0 +1 @@
+fix-ftbfs-734368.patch
Description: Fix FTBFS in many arches due to FS tests
The cause is that it cannot find /etc/mtab (or equivalent) in some arches. The
new standard place for this is '/proc/self/mounts'. ./configure
--with-mnttab='/proc/self/mounts' does not seem to work.
Author: Manuel A. Fernandez Montecelo m...@debian.org
Last-Update: 2014-03-08
Bug-Debian: http://bugs.debian.org/734368
--- a/src/libstatgrab/disk_stats.c
+++ b/src/libstatgrab/disk_stats.c
@@ -807,7 +807,7 @@
# endif
# endif
# ifndef MNT_MNTTAB
- static const char *mnttabs[] = { /etc/mnttab, /etc/mtab };
+ static const char *mnttabs[] = { /proc/self/mounts, /etc/mnttab, /etc/mtab };
unsigned i;
# endif
#elif defined(WIN32)
