Bug#748228: NMU patch for kbtin_1.0.14-1.1
On Sat, 2014-05-17 08:44:56 +1000, Aníbal Monsalve Salazar wrote: > On Fri, 2014-05-16 16:50:01 +0200, Adam Borowski wrote: >> On Fri, May 16, 2014 at 09:36:35PM +1000, Aníbal Monsalve Salazar wrote: >>> My NMU patch for kbtin_1.0.14-1.1 is below, at the end of this >>> message. >> >> Looks like there's some work duplication: yesterday I prepared an >> upload fixing this and also a bunch of other problems, and sent a >> request to Bartosz Fe??ski asking for sponsoring. He did not respond >> yet. I assumed no one would try an NMU the very next day. Had I not >> do the fix already, that would be welcome, but it led to work >> duplication instead. >> >> If you'd care before Bartosz finds some time, the upload is at: >> http://mentors.debian.net/debian/pool/main/k/kbtin/kbtin_1.0.15-1.dsc I missed the line above. I'll have a look at your package. Thank you! >> >> The only packaging change is adding V=y (the "verbose build logs" >> release goal), with a bunch of assorted bugfixes in the upstream >> tarball. The most important being an annoying segfault that often >> happens on window resize (introduced in 1.0.14). > > Hello Adam, > > Please let me know where is your new Debian source package and I'll > sponsor it. > > Cheers, > > Aníbal signature.asc Description: Digital signature
Bug#748228: NMU patch for kbtin_1.0.14-1.1
On Fri, 2014-05-16 16:50:01 +0200, Adam Borowski wrote: > On Fri, May 16, 2014 at 09:36:35PM +1000, Aníbal Monsalve Salazar wrote: >> My NMU patch for kbtin_1.0.14-1.1 is below, at the end of this >> message. > > Looks like there's some work duplication: yesterday I prepared an > upload fixing this and also a bunch of other problems, and sent a > request to Bartosz Fe??ski asking for sponsoring. He did not respond > yet. I assumed no one would try an NMU the very next day. Had I not > do the fix already, that would be welcome, but it led to work > duplication instead. > > If you'd care before Bartosz finds some time, the upload is at: > http://mentors.debian.net/debian/pool/main/k/kbtin/kbtin_1.0.15-1.dsc > > The only packaging change is adding V=y (the "verbose build logs" > release goal), with a bunch of assorted bugfixes in the upstream > tarball. The most important being an annoying segfault that often > happens on window resize (introduced in 1.0.14). Hello Adam, Please let me know where is your new Debian source package and I'll sponsor it. Cheers, Aníbal signature.asc Description: Digital signature
Bug#748228: NMU patch for kbtin_1.0.14-1.1
On Fri, May 16, 2014 at 09:36:35PM +1000, Aníbal Monsalve Salazar wrote: > My NMU patch for kbtin_1.0.14-1.1 is below, at the end of this > message. Looks like there's some work duplication: yesterday I prepared an upload fixing this and also a bunch of other problems, and sent a request to Bartosz Feński asking for sponsoring. He did not respond yet. I assumed no one would try an NMU the very next day. Had I not do the fix already, that would be welcome, but it led to work duplication instead. If you'd care before Bartosz finds some time, the upload is at: http://mentors.debian.net/debian/pool/main/k/kbtin/kbtin_1.0.15-1.dsc The only packaging change is adding V=y (the "verbose build logs" release goal), with a bunch of assorted bugfixes in the upstream tarball. The most important being an annoying segfault that often happens on window resize (introduced in 1.0.14). Meow! -- Gnome 3, Windows 8, Slashdot Beta, now Firefox Ribbon^WAustralis. WTF is going on with replacing usable interfaces with tabletized ones? -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#748228: NMU patch for kbtin_1.0.14-1.1
On Fri, 2014-05-16 21:36:35 +1000, Aníbal Monsalve Salazar wrote: > With the changes in the NMU patch grib-api builds successfully on > mips, mipsel and amd64. Typo. s/grib-api/kbtin/ -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#748228: NMU patch for kbtin_1.0.14-1.1
Hello Adam,
At Imagination Technologies (http://imgtec.com/) Jurica Stanojkovic has
found a solution to Debian bug #748228.
https://bugs.debian.org/748228
My NMU patch for kbtin_1.0.14-1.1 is below, at the end of this
message.
With the changes in the NMU patch grib-api builds successfully on
mips, mipsel and amd64.
Regards,
Aníbal
--
Aníbal Monsalve Salazar
debdiff kbtin_1.0.14-1.dsc kbtin_1.0.14-1.1.dsc
diff -Nru kbtin-1.0.14/debian/changelog kbtin-1.0.14/debian/changelog
--- kbtin-1.0.14/debian/changelog 2012-12-23 17:13:35.0 +
+++ kbtin-1.0.14/debian/changelog 2014-05-16 11:31:36.0 +0100
@@ -1,3 +1,13 @@
+kbtin (1.0.14-1.1) unstable; urgency=medium
+
+ * Non-maintainer upload.
+ * Fix FTBFS on big endian architectures.
+Add big_endian.patch.
+Patch by Jurica Stanojkovic .
+Closes: #748228.
+
+ -- Anibal Monsalve Salazar Fri, 16 May 2014 11:31:20
+0100
+
kbtin (1.0.14-1) unstable; urgency=low
* New upstream release.
diff -Nru kbtin-1.0.14/debian/patches/big_endian.patch
kbtin-1.0.14/debian/patches/big_endian.patch
--- kbtin-1.0.14/debian/patches/big_endian.patch1970-01-01
01:00:00.0 +0100
+++ kbtin-1.0.14/debian/patches/big_endian.patch2014-05-16
11:17:57.0 +0100
@@ -0,0 +1,48 @@
+From: Jurica Stanojkovic
+Subject: package kbtin_1.0.14-1 FTBS on big endian architectures
+Date: Wed, 14 May 2014 06:13:10 -0700
+
+http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=748228
+
+Package is failing to build on all big endian architectures.
+
+mips build log:
+https://buildd.debian.org/status/fetch.php?pkg=kbtin&arch=mips&ver=1.0.14-1&stamp=1383184670
+
+I was able to build package kbtin_1.0.14-1 on mips (big endian) with
+following patch.
+
+File big_endian.patch is attached.
+
+These changes are already in master branch for kbtin package on git.
+
+https://github.com/kilobyte/kbtin/commit/a5c0ef55f909ddc3487d355c25f40b3c18c93946
+
+--- a/files.c
b/files.c
+@@ -273,7 +273,7 @@ void write_log(struct session *ses, char
+ if (ses->logtype==2)
+ {
+ ttyrec_timestamp(&th);
+-th.len=n;
++th.len=to_little_endian(n);
+ if (fwrite(&th, 1, sizeof(struct ttyrec_header), ses->logfile)<
+ sizeof(struct ttyrec_header))
+ {
+--- a/tintin.h
b/tintin.h
+@@ -363,10 +363,10 @@ typedef char pvars_t[10][BUFFER_SIZE];
+
+ #ifdef WORDS_BIGENDIAN
+ # define to_little_endian(x) ((uint32_t) ( \
+-(((uint32_t)(x) &((uint32_t)0x00ffU) << 24)) | \
+-(((uint32_t)(x) &((uint32_t)0xff00U) << 8)) | \
+-(((uint32_t)(x) &((uint32_t)0x00ffU) >> 8)) | \
+-(((uint32_t)(x) &((uint32_t)0xff00U) >> 24
++((uint32_t)(x) &(uint32_t)0x00ffU) << 24 | \
++((uint32_t)(x) &(uint32_t)0xff00U) << 8 | \
++((uint32_t)(x) &(uint32_t)0x00ffU) >> 8 | \
++((uint32_t)(x) &(uint32_t)0xff00U) >> 24))
+ #else
+ # define to_little_endian(x) ((uint32_t)(x))
+ #endif
diff -Nru kbtin-1.0.14/debian/patches/series kbtin-1.0.14/debian/patches/series
--- kbtin-1.0.14/debian/patches/series 1970-01-01 01:00:00.0 +0100
+++ kbtin-1.0.14/debian/patches/series 2014-05-15 10:03:07.0 +0100
@@ -0,0 +1 @@
+big_endian.patch
signature.asc
Description: Digital signature
