Bug#752974: xdotool: FTBFS - tests fail with EOFError: end of file reached
On 07/29/2014 03:51 AM, Petter Reinholdtsen wrote: Is this failing test related to bug #740419 (Unreliable testsuite)? i don't think so, unfortunately. the failures in 752974 are very reliable :P these newer failures appear to be related to the version of ruby that is running. Should the bugs be merged? If the test suite is unreliable, perhaps running it during build should be optional, or at least not fatal when it fail? I'm tempted to do this, since xdotool clearly is still working, and it's just the ruby framework that appears to be breaking :/ --dkg signature.asc Description: OpenPGP digital signature
Bug#752974: xdotool: FTBFS - tests fail with EOFError: end of file reached
Is this failing test related to bug #740419 (Unreliable testsuite)? Should the bugs be merged? If the test suite is unreliable, perhaps running it during build should be optional, or at least not fatal when it fail? -- Happy hacking Petter Reinholdtsen -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Processed: Re: Bug#752974: xdotool: FTBFS - tests fail with EOFError: end of file reached
Processing control commands: tag -1 + patch Bug #752974 [xdotool] xdotool: FTBFS - tests fail with EOFError: end of file reached Added tag(s) patch. -- 752974: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=752974 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#752974: xdotool: FTBFS - tests fail with EOFError: end of file reached
Control: tag -1 + patch
Hi Daniel,
Michael Tautschnig wrote:
During a rebuild of all Debian packages in a clean sid chroot (using
cowbuilder
and pbuilder) the build failed with the following error.
[...]
/srv/jenkins-slave/workspace/sid-goto-cc-xdotool/xdotool-3.20130111.1/t/xdo_test_helper.rb:7:in
`setup'
===
E
===
Error: test_xdotool_exits_success_with_help_flag(XdotoolBasicTests)
EOFError: end of file reached
This (very likely) can be fixed by moving write.close after all
occurrences of reader.readline in t/xdo_test_helper.rb. Patch
attached.
I likely can NMU this, but due to upstream's time-consuming way to
conduct the tests (one sleep 300 per test as it seems, etc.),
building the packages takes ages. So I can't promise to NMU this until
the build finished. (But at least it's not immediately bailing out on
the first test anymore, so I consider the attached patch as
sufficient. :-)
Please tell me if you'd prefer the NMU to go to unstable directly.
Otherwise I'd target DELAYED/10 or such as it's just a FTBFS.
Regards, Axel
--
,''`. | Axel Beckert a...@debian.org, http://people.debian.org/~abe/
: :' : | Debian Developer, ftp.ch.debian.org Admin
`. `' | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE
`-| 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5
Description: Fix failing test suite by calling close after read in xdo_test_helper.rb
Author: Axel Beckert a...@debian.org
Bug-Debian: https://bugs.debian.org/752974
Index: xdotool-3.20130111.1/t/xdo_test_helper.rb
===
--- xdotool-3.20130111.1.orig/t/xdo_test_helper.rb 2013-01-10 18:52:07.0 +0100
+++ xdotool-3.20130111.1/t/xdo_test_helper.rb 2014-07-12 13:12:14.611829739 +0200
@@ -28,9 +28,9 @@
reader.close
exec(exec xterm -T '#{@title}' -e 'echo $WINDOWID #{writer.fileno}; echo $$ #{writer.fileno}; #{cmd}')
end # xterm fork
-writer.close
@wid = reader.readline.to_i
@shellpid = reader.readline.to_i
+writer.close
healthy = false
while !healthy
signature.asc
Description: Digital signature
Bug#752974: xdotool: FTBFS - tests fail with EOFError: end of file reached
Control: tag -1 - patch Hi again, Axel Beckert wrote: This (very likely) can be fixed by moving write.close after all occurrences of reader.readline in t/xdo_test_helper.rb. Patch attached. Unfortunately the patch is not sufficient. It causes xterm zombies and a hanging test suite, which isn't much better. :-( I'll have a closer look later. Regards, Axel -- ,''`. | Axel Beckert a...@debian.org, http://people.debian.org/~abe/ : :' : | Debian Developer, ftp.ch.debian.org Admin `. `' | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE `-| 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5 -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Processed: Re: Bug#752974: xdotool: FTBFS - tests fail with EOFError: end of file reached
Processing control commands: tag -1 - patch Bug #752974 [xdotool] xdotool: FTBFS - tests fail with EOFError: end of file reached Removed tag(s) patch. -- 752974: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=752974 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#752974: xdotool: FTBFS - tests fail with EOFError: end of file reached
Package: xdotool Version: 1:3.20130111.1-3.1 Severity: serious Usertags: goto-cc During a rebuild of all Debian packages in a clean sid chroot (using cowbuilder and pbuilder) the build failed with the following error. [...] /srv/jenkins-slave/workspace/sid-goto-cc-xdotool/xdotool-3.20130111.1/t/xdo_test_helper.rb:7:in `setup' === E === Error: test_xdotool_exits_success_with_help_flag(XdotoolBasicTests) EOFError: end of file reached /srv/jenkins-slave/workspace/sid-goto-cc-xdotool/xdotool-3.20130111.1/t/xdo_test_helper.rb:32:in `readline' /srv/jenkins-slave/workspace/sid-goto-cc-xdotool/xdotool-3.20130111.1/t/xdo_test_helper.rb:32:in `setup_launch_xterm' /srv/jenkins-slave/workspace/sid-goto-cc-xdotool/xdotool-3.20130111.1/t/xdo_test_helper.rb:7:in `setup' === Finished in 3601.874984405 seconds. 12 tests, 0 assertions, 0 failures, 12 errors, 0 pendings, 0 omissions, 0 notifications 0% passed 0.00 tests/s, 0.00 assertions/s Makefile:27: recipe for target 'do-test' failed make[5]: *** [do-test] Error 1 The full build log is attached; please do let me know if the problem is unreproducible, in which case I shall try to investigate further. Best, Michael xdotool-build-log.txt.gz Description: application/gunzip pgpF2hAXDBM7F.pgp Description: PGP signature
