Bug#767933: daemontools-run: fails to install without /etc/inittab
I don't agree that this qualifies as an RC bug. daemontools isn't designed to be run on top on modern init systems like systemd and you can't sensibly run it there. Please either downgrade the severity of this bug report or remove daemontools from testing. No one is going to hack systemd support, i.e. daemontools working without /etc/inittab, into daemontools over the weekend now. daemontools has become obsolete with systemd anyway and is interesting for users of sysvinit anyway. Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de `-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913 -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#767933: daemontools-run: fails to install without /etc/inittab
tags 767933 - patch quit On Thu, Nov 13, 2014 at 12:20:01AM +0100, Simon Elsbrock wrote: the patch below fixes the build failure by checking for existence of /etc/inittab before grepping. Hi Simon, thanks for the patch, but that's not the solution, it has other problems which are not as obvious as an installation failure, see https://lists.debian.org/debian-devel/2014/10/msg00613.html Regards, Gerrit. -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Processed: Re: Bug#767933: daemontools-run: fails to install without /etc/inittab
Processing commands for cont...@bugs.debian.org: tags 767933 - patch Bug #767933 [daemontools-run] daemontools-run: fails to install without /etc/inittab Removed tag(s) patch. quit Stopping processing here. Please contact me if you need assistance. -- 767933: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=767933 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#767933: daemontools-run: fails to install without /etc/inittab
Control: tags 767933 + patch
Dear maintainer,
the patch below fixes the build failure by checking for existence
of /etc/inittab before grepping.
Regards,
Simon
diff -u daemontools-0.76/debian/daemontools-run.postinst
daemontools-0.76/debian/daemontools-run.postinst
--- daemontools-0.76/debian/daemontools-run.postinst
+++ daemontools-0.76/debian/daemontools-run.postinst
@@ -17,7 +17,7 @@
break
done
# upgrade from unofficial daemontools-run
- if grep -q '#-- daemontools-run begin' /etc/inittab; then
+ if test -f /etc/inittab grep -q '#-- daemontools-run begin' /etc/inittab;
then
echo 'Removing SV inittab entry...'
rm -f /etc/inittab'{new}'
sed -e '/#-- daemontools-run begin/,/#-- daemontools-run end/d' \
@@ -27,7 +27,7 @@
sleep 1
fi
# update from daemontools-installer
- if grep -q 'SV:123456:respawn:/command/svscanboot' /etc/inittab; then
+ if test -f /etc/inittab grep -q 'SV:123456:respawn:/command/svscanboot'
/etc/inittab; then
echo 'Removing SV inittab entry...'
rm -f /etc/inittab'{new}'
sed -e '/SV:123456:respawn:\/command\/svscanboot/d' \
@@ -37,7 +37,7 @@
sleep 1
fi
# update from daemontools-installer (fhs version)
- if grep -q 'SV:123456:respawn:/usr/bin/svscanboot' /etc/inittab; then
+ if test -f /etc/inittab grep -q 'SV:123456:respawn:/usr/bin/svscanboot'
/etc/inittab; then
echo 'Removing SV inittab entry...'
rm -f /etc/inittab'{new}'
sed -e '/SV:123456:respawn:\/usr\/bin\/svscanboot/d' \
@@ -49,7 +49,7 @@
fi
if test -z $2; then
# not upgrading
- if grep '^SV:' /etc/inittab /dev/null; then
+ if test -f /etc/inittab grep '^SV:' /etc/inittab /dev/null; then
cat -\EOT 2
There already is an SV entry in /etc/inittab. In order to have this
@@ -63,7 +63,7 @@
exit 1
fi
fi
-if ! grep '^SV:' /etc/inittab /dev/null; then
+if test -f /etc/inittab ! grep '^SV:' /etc/inittab /dev/null; then
echo 'Adding SV inittab entry...'
cp /etc/inittab /etc/inittab'{new}'
cat /etc/inittab'{new}' -\EOT
diff -u daemontools-0.76/debian/daemontools-run.postrm
daemontools-0.76/debian/daemontools-run.postrm
--- daemontools-0.76/debian/daemontools-run.postrm
+++ daemontools-0.76/debian/daemontools-run.postrm
@@ -3,7 +3,7 @@
test $1 = 'remove' || exit 0
-if grep -q #-- daemontools-run begin /etc/inittab; then
+if test -f /etc/inittab grep -q #-- daemontools-run begin /etc/inittab;
then
echo 'Removing SV inittab entry...'
rm -f /etc/inittab'{new}'
sed -e '/#-- daemontools-run begin/,/#-- daemontools-run end/d' \
--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#767933: daemontools-run: fails to install without /etc/inittab
Package: daemontools-run Version: 1:0.76-5 Severity: serious User: debian...@lists.debian.org Usertags: piuparts Hi, during a test with piuparts I noticed your package failed to install. As per definition of the release team this makes the package too buggy for a release, thus the severity. From the attached log (scroll to the bottom...): Selecting previously unselected package daemontools-run. (Reading database ... 7426 files and directories currently installed.) Preparing to unpack .../daemontools-run_1%3a0.76-5_all.deb ... Unpacking daemontools-run (1:0.76-5) ... Setting up daemontools-run (1:0.76-5) ... grep: /etc/inittab: No such file or directory grep: /etc/inittab: No such file or directory grep: /etc/inittab: No such file or directory grep: /etc/inittab: No such file or directory grep: /etc/inittab: No such file or directory Adding SV inittab entry... cp: cannot stat '/etc/inittab': No such file or directory dpkg: error processing package daemontools-run (--configure): subprocess installed post-installation script returned error exit status 1 Errors were encountered while processing: daemontools-run See also https://bugs.debian.org/766187 cheers, Andreas daemontools-run_1:0.76-5.log.gz Description: application/gzip
