Bug#769240: libcatalyst-controller-formbuilder-perl: FTBFS in jessie/i386: Tests failures
Quoting Simon McVittie (2014-11-15 16:54:23) > On 15/11/14 15:25, Jonas Smedegaard wrote: >> Please someone else than me take the dialogue with release team - my >> stomach is not up for that task. > > I'll do the unblock request now. Excellent. Thanks! - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: signature
Bug#769240: libcatalyst-controller-formbuilder-perl: FTBFS in jessie/i386: Tests failures
On 15/11/14 15:25, Jonas Smedegaard wrote: > Please someone else than me take the dialogue with release team - > my stomach is not up for that task. I'll do the unblock request now. S -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#769240: libcatalyst-controller-formbuilder-perl: FTBFS in jessie/i386: Tests failures
Quoting gregor herrmann (2014-11-15 16:11:22) > On Sat, 15 Nov 2014 16:00:04 +0100, Jonas Smedegaard wrote: > >>> Jonas, do you have time to look into this? >> Yes, working on it now. Uploaded now. Please someone else than me take the dialogue with release team - my stomach is not up for that task. - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: signature
Bug#769240: libcatalyst-controller-formbuilder-perl: FTBFS in jessie/i386: Tests failures
On Sat, 15 Nov 2014 16:00:04 +0100, Jonas Smedegaard wrote: > > Jonas, do you have time to look into this? > Yes, working on it now. Great, thanks! Cheers, gregor -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- NP: Bjørn Berge: Buena signature.asc Description: Digital Signature
Bug#769240: libcatalyst-controller-formbuilder-perl: FTBFS in jessie/i386: Tests failures
Quoting gregor herrmann (2014-11-15 15:14:52) > On Wed, 12 Nov 2014 21:11:09 +, Simon McVittie wrote: >> The attached 0001-*.patch is for Debian's git repo. The patched >> libcgi-formbuilder-perl passes its tests in sbuild, and so does >> libcatalyst-controller-formbuilder-perl_0.06-2 when given the patched >> libcgi-formbuilder-perl as an additional .deb. > Jonas, do you have time to look into this? Yes, working on it now. Thanks, Simon! - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: signature
Bug#769240: libcatalyst-controller-formbuilder-perl: FTBFS in jessie/i386: Tests failures
On Wed, 12 Nov 2014 21:11:09 +, Simon McVittie wrote: > Since this is, strictly speaking, a regression in our patched > CGI::FormBuilder, I've prepared a patch that replaces Amitai's 2 > patches, and my additional patch in the same style. (See attached, > 0003-*.patch.) Thank you, much appreciated. > The best way to do this upstream would probably be to add a new function > Util::param_multi_valued($cgi_or_compatible, $k) encapsulating that > logic, but that's new API, which seems undesirable to add downstream; > that's also a reasonable argument for not adding > Catalyst::Request::param_fetch unless/until Catalyst upstream say yes, I > suppose. Agreed on both accounts. > The attached 0001-*.patch is for Debian's git repo. The patched > libcgi-formbuilder-perl passes its tests in sbuild, and so does > libcatalyst-controller-formbuilder-perl_0.06-2 when given the patched > libcgi-formbuilder-perl as an additional .deb. Thanks. Jonas, do you have time to look into this? Cheers, gregor -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- NP: Element of Crime: Wenn der Winter kommt signature.asc Description: Digital Signature
Bug#769240: libcatalyst-controller-formbuilder-perl: FTBFS in jessie/i386: Tests failures
On 12/11/14 19:50, Simon McVittie wrote:
> Alternatively, CGI::FormBuilder could be augmented to use something like
> this
>
> my @xs;
>
> if ($q->can("param_fetch")) {
> @xs = @{$q->param_fetch('x')};
> } else {
> @xs = $q->param('x');
> }
>
> at each of the locations where Amitai and I patched it.
Since this is, strictly speaking, a regression in our patched
CGI::FormBuilder, I've prepared a patch that replaces Amitai's 2
patches, and my additional patch in the same style. (See attached,
0003-*.patch.)
The best way to do this upstream would probably be to add a new function
Util::param_multi_valued($cgi_or_compatible, $k) encapsulating that
logic, but that's new API, which seems undesirable to add downstream;
that's also a reasonable argument for not adding
Catalyst::Request::param_fetch unless/until Catalyst upstream say yes, I
suppose.
The attached 0001-*.patch is for Debian's git repo. The patched
libcgi-formbuilder-perl passes its tests in sbuild, and so does
libcatalyst-controller-formbuilder-perl_0.06-2 when given the patched
libcgi-formbuilder-perl as an additional .deb.
S
From 89421a62fbf839354371fb1c27b9c94b97ffbef7 Mon Sep 17 00:00:00 2001
From: Simon McVittie
Date: Wed, 12 Nov 2014 20:43:56 +
Subject: [PATCH] Revise patches from previous release to retain support for
objects that mimic the CGI.pm API but do not have param_fetch (Closes:
#769240)
---
debian/changelog | 8 ++
...nneeded-warning-from-CGI.pm-4.05-or-newer.patch | 87 ++
...nneeded-warning-from-CGI.pm-4.05-or-newer.patch | 20 -
...nneeded-warning-from-CGI.pm-4.05-or-newer.patch | 20 -
...-use-of-param-that-will-cause-a-warning-i.patch | 19 -
...t-cgi_param-is-context-sensitive-just-lik.patch | 4 +-
debian/patches/series | 4 +-
7 files changed, 99 insertions(+), 63 deletions(-)
create mode 100644 debian/patches/0003-Avoid-unneeded-warning-from-CGI.pm-4.05-or-newer.patch
delete mode 100644 debian/patches/0004-Avoid-unneeded-warning-from-CGI.pm-4.05-or-newer.patch
delete mode 100644 debian/patches/0005-Avoid-unneeded-warning-from-CGI.pm-4.05-or-newer.patch
delete mode 100644 debian/patches/0006-Fix-another-use-of-param-that-will-cause-a-warning-i.patch
diff --git a/debian/changelog b/debian/changelog
index 3f1081e..09ecb3c 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+libcgi-formbuilder-perl (3.09-1.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Revise patches from previous release to retain support for objects
+that mimic the CGI.pm API but do not have param_fetch (Closes: #769240)
+
+ -- Simon McVittie Wed, 12 Nov 2014 20:43:04 +
+
libcgi-formbuilder-perl (3.09-1) unstable; urgency=medium
[ Salvatore Bonaccorso ]
diff --git a/debian/patches/0003-Avoid-unneeded-warning-from-CGI.pm-4.05-or-newer.patch b/debian/patches/0003-Avoid-unneeded-warning-from-CGI.pm-4.05-or-newer.patch
new file mode 100644
index 000..e91c0bc
--- /dev/null
+++ b/debian/patches/0003-Avoid-unneeded-warning-from-CGI.pm-4.05-or-newer.patch
@@ -0,0 +1,87 @@
+From: Simon McVittie
+Date: Wed, 12 Nov 2014 20:41:26 +
+Subject: Avoid unneeded warning from CGI.pm 4.05 or newer
+
+Based on earlier patches by Amitai Schlair, but modified to retain
+support for objects like Catalyst::Request that mimic the CGI interface
+but do not have a param_fetch method.
+---
+ lib/CGI/FormBuilder.pm | 13 -
+ lib/CGI/FormBuilder/Field.pm | 14 +-
+ lib/CGI/FormBuilder/Multi.pm | 14 +-
+ 3 files changed, 38 insertions(+), 3 deletions(-)
+
+diff --git a/lib/CGI/FormBuilder.pm b/lib/CGI/FormBuilder.pm
+index f01c61c..04b5e72 100644
+--- a/lib/CGI/FormBuilder.pm
b/lib/CGI/FormBuilder.pm
+@@ -855,7 +855,18 @@ sub keepextras {
+
+ # Make sure to get all values
+ for my $p (@keep) {
+-for my $v ($self->{params}->param($p)) {
++my @values;
++if ($self->{params}->can('param_fetch')) {
++@values = @{$self->{params}->param_fetch($p)};
++}
++else {
++# array-context calls to param($p) are deprecated in
++# CGI.pm, but some other objects that mimic
++# its interface don't have param_fetch
++@values = $self->{params}->param($p);
++}
++
++for my $v (@values) {
+ debug 1, "keepextras: saving hidden param $p = $v";
+ push @html, htmltag('input', name => $p, type => 'hidden', value => $v);
+ }
+diff --git a/lib/CGI/FormBuilder/Field.pm b/lib/CGI/FormBuilder/Field.pm
+index a649696..8413240 100644
+--- a/lib/CGI/FormBuilder/Field.pm
b/lib/CGI/FormBuilder/Field.pm
+@@ -189,7 +189,19 @@ sub cgi_value {
+ my $self = shift;
+ debug 2, "$self->{name}: called \$field->cgi_value";
+ puke "Cannot set \$field->cgi_value manually" if @_;
+-if (my @v = $self->{_form}{params}->
Bug#769240: libcatalyst-controller-formbuilder-perl: FTBFS in jessie/i386: Tests failures
On 12/11/14 19:24, gregor herrmann wrote:
> On Wed, 12 Nov 2014 11:28:52 +0100, Lucas Nussbaum wrote:
>>> # Testing Catalyst::Controller::FormBuilder 0.06
>>> t/00-load.t ok
>>> [error] Caught exception in TestApp::Controller::Books->basic "Can't locate
>>> object method "param_fetch" via package "Catalyst::Request" at
>>> /usr/share/perl5/CGI/FormBuilder/Field.pm line 192."
>>> [error] Caught exception in TestApp::Component::Rendered->process "Can't
>>> call method "render" on an undefined value at
>>> /«PKGBUILDDIR»/t/lib/TestApp/Component/Rendered.pm line 9."
>
> I guess this is caused by the recent changes in
> libcgi-formbuilder-perl, esp. by 5742e58 (adjustments for CGI.pm >=
> 4.05)
The first error, certainly: real CGI.pm objects have "always"[1] had the
param_fetch method, but CGI::FormBuilder would previously tolerate being
given a CGI-like object with only the param method.
I would personally suggest adding the param_fetch method to whatever
object is pretending to be a CGI object (Catalyst::Request?), since the
context-sensitive CGI::param method seems like a security vulnerability
waiting to happen. Bugzilla was unlucky and IkiWiki was lucky, but it
could easily have been the other way round.
Alternatively, CGI::FormBuilder could be augmented to use something like
this
my @xs;
if ($q->can("param_fetch")) {
@xs = @{$q->param_fetch('x')};
} else {
@xs = $q->param('x');
}
at each of the locations where Amitai and I patched it. :-(
S
[1] since at least 2000, at which point I stopped researching
--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Processed: Re: Bug#769240: libcatalyst-controller-formbuilder-perl: FTBFS in jessie/i386: Tests failures
Processing control commands: > tag -1 + confirmed Bug #769240 [src:libcatalyst-controller-formbuilder-perl] libcatalyst-controller-formbuilder-perl: FTBFS in jessie/i386: Tests failures Added tag(s) confirmed. -- 769240: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=769240 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#769240: libcatalyst-controller-formbuilder-perl: FTBFS in jessie/i386: Tests failures
Control: tag -1 + confirmed On Wed, 12 Nov 2014 11:28:52 +0100, Lucas Nussbaum wrote: > Source: libcatalyst-controller-formbuilder-perl > Version: 0.06-2 > Severity: serious > Tags: jessie sid > User: debian...@lists.debian.org > Usertags: qa-ftbfs-20141112 qa-ftbfs > Justification: FTBFS in jessie on i386 > > > # Testing Catalyst::Controller::FormBuilder 0.06 > > t/00-load.t ok > > [error] Caught exception in TestApp::Controller::Books->basic "Can't locate > > object method "param_fetch" via package "Catalyst::Request" at > > /usr/share/perl5/CGI/FormBuilder/Field.pm line 192." > > [error] Caught exception in TestApp::Component::Rendered->process "Can't > > call method "render" on an undefined value at > > /«PKGBUILDDIR»/t/lib/TestApp/Component/Rendered.pm line 9." I guess this is caused by the recent changes in libcgi-formbuilder-perl, esp. by 5742e58 (adjustments for CGI.pm >= 4.05) Cheers, gregor -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- NP: Simon & Garfunkel: April Come She Will signature.asc Description: Digital Signature
Bug#769240: libcatalyst-controller-formbuilder-perl: FTBFS in jessie/i386: Tests failures
Source: libcatalyst-controller-formbuilder-perl Version: 0.06-2 Severity: serious Tags: jessie sid User: debian...@lists.debian.org Usertags: qa-ftbfs-20141112 qa-ftbfs Justification: FTBFS in jessie on i386 Hi, During a rebuild of all packages in jessie (in a jessie chroot, not a sid chroot), your package failed to build on i386. Relevant part (hopefully): > # Testing Catalyst::Controller::FormBuilder 0.06 > t/00-load.t ok > [error] Caught exception in TestApp::Controller::Books->basic "Can't locate > object method "param_fetch" via package "Catalyst::Request" at > /usr/share/perl5/CGI/FormBuilder/Field.pm line 192." > [error] Caught exception in TestApp::Component::Rendered->process "Can't call > method "render" on an undefined value at > /«PKGBUILDDIR»/t/lib/TestApp/Component/Rendered.pm line 9." > > # Failed test 'GET /books/basic' > # at t/01-basic.t line 11. > # 500 > # Internal Server Error > > # Failed test 'Form found' > # at t/01-basic.t line 14. > Bailout called. Further testing stopped: Can't do anything without a form > FAILED--Further testing stopped: Can't do anything without a form > make[1]: *** [test_dynamic] Error 255 > Makefile:761: recipe for target 'test_dynamic' failed The full build log is available from: http://aws-logs.debian.net/ftbfs-logs/2014/11/12/libcatalyst-controller-formbuilder-perl_0.06-2_jessie-i386.log A list of current common problems and possible solutions is available at http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute! About the archive rebuild: The rebuild was done on EC2 VM instances from Amazon Web Services, using a clean, minimal and up-to-date chroot. Every failed build was retried once to eliminate random failures. -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
