Bug#769552: ipolish: package fails to upgrade properly from wheezy

2014-11-21 Thread Agustin Martin
On Sat, Nov 15, 2014 at 11:21:33AM +0100, Jakub Wilk wrote:
> * Lucas Nussbaum , 2014-11-14, 13:31:
> >>update-default-ispell:
> >>Could not make the default symlink to "/usr/lib/ispell/polish.hash".
> >>This may be a temporary problem due to installation ordering. If that
> >>file is not present after installation, please file a bugreport
> >>against ispell dictionary package owning that file.
> 
> This looks like an insufficient dependency on dictionaries-common.

Thanks for pointing out this,

Seems I did not check the use of jessie dicts in wheezy.

> Given that the binary package was mostly generated automatically by
> installdeb-ispell(1), the dependencies should be be generated automatically,
> too. There is ${ispell:Depends} that can be used for this purpose, although
> it's very poorly documented.

I mailed the info about this change to the dict-common.dev mailing list

http://lists.alioth.debian.org/pipermail/dict-common-dev/2014-June/thread.html

but did not make clear that dictionaries relying on symlink creation by
installdeb- scripts must bump its dependency on dictionaries-common. That
symlinks are now created by the autobuildhash script.

Just sent a clarification to the list, bcc'ed to the packages address for
those ispell or aspell dictionaries not having a bumped dependency. Sorry,
Robert, for being late.

I have also modified the installdeb-{a,i}spell man pages to add info about
the substvars and to fix info about this no longer available feature (it
was still marked as available). Opened #770484 to track this. Since it is
only a dodumentation fix, I hope to get a freeze exception from the release
team.

> The attached patch should fix the bug. After rebuilding with this patch, the
> binary package has:
> 
> Depends: dictionaries-common (>= 1.23~)
> 
> instead of
> 
> Depends: dictionaries-common (>= 1.10.6~)
> 
> But I fear that there are many other ispell dictionaries with the same
> problem. Some of them might not have any symptoms now (because they were
> built with old dictionaries-common), but they'd break after a rebuild.

I went through the list of sid ispell or aspell dictionaries and
fortunately, they are in one of these cases: were built some time ago, when
that feature was available, have updated dependency, set symlinks explicitly
during build process or are binary:arch packages where no symlinks are
needed. Hope not to have missed anyone.

Thank you very much for the info,

-- 
Agustin


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#769552: ipolish: package fails to upgrade properly from wheezy

2014-11-15 Thread Jakub Wilk

* Lucas Nussbaum , 2014-11-14, 13:31:

update-default-ispell:
Could not make the default symlink to "/usr/lib/ispell/polish.hash".
This may be a temporary problem due to installation ordering. If that
file is not present after installation, please file a bugreport
against ispell dictionary package owning that file.


This looks like an insufficient dependency on dictionaries-common.

Given that the binary package was mostly generated automatically by 
installdeb-ispell(1), the dependencies should be be generated 
automatically, too. There is ${ispell:Depends} that can be used for this 
purpose, although it's very poorly documented.


The attached patch should fix the bug. After rebuilding with this patch, 
the binary package has:


Depends: dictionaries-common (>= 1.23~)

instead of

Depends: dictionaries-common (>= 1.10.6~)

But I fear that there are many other ispell dictionaries with the same 
problem. Some of them might not have any symptoms now (because they were 
built with old dictionaries-common), but they'd break after a rebuild.


--
Jakub Wilk
diff -Nru ipolish-20140830/debian/control ipolish-20140830/debian/control
--- ipolish-20140830/debian/control	2014-08-30 20:15:52.0 +0200
+++ ipolish-20140830/debian/control	2014-11-15 10:54:17.0 +0100
@@ -2,7 +2,7 @@
 Maintainer: Robert Luberda 
 Section: text
 Priority: optional
-Build-Depends-Indep: dictionaries-common-dev (>= 1.10.6~),
+Build-Depends-Indep: dictionaries-common-dev (>= 1.21),
  hunspell-tools | myspell-tools,
  ispell (>= 3.3.02),
  locales,
@@ -15,8 +15,7 @@
 
 Package: ipolish
 Architecture: all
-Depends: dictionaries-common (>= 1.10.6~),
- ispell,
+Depends: ${ispell:Depends},
  ${misc:Depends},
  ${perl:Depends}
 Provides: ispell-dictionary