Bug#779501: clamsmtp: patch included in 1.10-12 completely breaks the package

2015-03-01 Thread Michael Meskes
On Sun, Mar 01, 2015 at 05:05:59PM +0100, Julien Cristau wrote:
 Package: clamsmtp
 Version: 1.10-12
 Severity: grave
 Justification: renders package unusable
 x-debbugs-cc: Michael Tautschnig m...@debian.org
 ...

Patch doesn't seem to help, see attached. What did I miss?

Michael

-- 
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes at gmail dot com
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL
 dpkg-buildpackage -rfakeroot -D -us -uc -i -I
dpkg-buildpackage: source package clamsmtp
dpkg-buildpackage: source version 1.10-13
dpkg-buildpackage: source distribution unstable
dpkg-buildpackage: source changed by Michael Meskes mes...@debian.org
 dpkg-source -i -I --before-build clamsmtp
dpkg-buildpackage: host architecture amd64
 fakeroot debian/rules clean
dh clean --with quilt,autoreconf
   dh_testdir
   dh_auto_clean
   dh_quilt_unpatch
No patch removed
   dh_autoreconf_clean
   dh_clean
 dpkg-source -i -I -b clamsmtp
dpkg-source: warning: source directory 'clamsmtp' is not 
sourcepackage-upstreamversion 'clamsmtp-1.10'
dpkg-source: warning: .orig directory name clamsmtp.orig is not 
package-upstreamversion (wanted clamsmtp-1.10.orig)
dpkg-source: info: using source format `1.0'
dpkg-source: info: building clamsmtp using existing clamsmtp_1.10.orig.tar.gz
dpkg-source: info: building clamsmtp in clamsmtp_1.10-13.diff.gz
dpkg-source: warning: ignoring deletion of file depcomp, use --include-removal 
to override
dpkg-source: warning: ignoring deletion of file config.h.in, use 
--include-removal to override
dpkg-source: warning: ignoring deletion of file INSTALL, use --include-removal 
to override
dpkg-source: warning: ignoring deletion of file config.guess, use 
--include-removal to override
dpkg-source: warning: ignoring deletion of file missing, use --include-removal 
to override
dpkg-source: warning: ignoring deletion of file config.sub, use 
--include-removal to override
dpkg-source: warning: ignoring deletion of file aclocal.m4, use 
--include-removal to override
dpkg-source: warning: ignoring deletion of file Makefile.in, use 
--include-removal to override
dpkg-source: warning: ignoring deletion of file configure, use 
--include-removal to override
dpkg-source: warning: ignoring deletion of file install-sh, use 
--include-removal to override
dpkg-source: warning: ignoring deletion of file src/Makefile.in, use 
--include-removal to override
dpkg-source: warning: ignoring deletion of file doc/Makefile.in, use 
--include-removal to override
dpkg-source: info: building clamsmtp in clamsmtp_1.10-13.dsc
 debian/rules build
dh build --with quilt,autoreconf
   dh_testdir
   dh_quilt_patch
Applying patch 300175-fileperms.patch
patching file common/smtppass.c
Hunk #1 succeeded at 1371 (offset 101 lines).

Applying patch manpage.patch
patching file doc/clamsmtpd.8

Applying patch gnu_source.patch
patching file common/smtppass.c

Applying patch include_order.patch
patching file common/usuals.h
patching file configure.in
Hunk #1 succeeded at 51 with fuzz 2.

Now at patch include_order.patch
   dh_autoreconf
aclocal: warning: autoconf input should be named 'configure.ac', not 
'configure.in'
automake: warning: autoconf input should be named 'configure.ac', not 
'configure.in'
configure.in:40: warning: AM_INIT_AUTOMAKE: two- and three-arguments forms are 
deprecated.  For more info, see:
configure.in:40: 
http://www.gnu.org/software/automake/manual/automake.html#Modernize-AM_005fINIT_005fAUTOMAKE-invocation
configure.in:49: installing './compile'
configure.in:68: installing './config.guess'
configure.in:68: installing './config.sub'
configure.in:40: installing './install-sh'
configure.in:40: installing './missing'
Makefile.am: installing './INSTALL'
src/Makefile.am:4: warning: source file '../common/spio.c' is in a subdirectory,
src/Makefile.am:4: but option 'subdir-objects' is disabled
automake: warning: possible forward-incompatibility.
automake: At least a source file is in a subdirectory, but the 'subdir-objects'
automake: automake option hasn't been enabled.  For now, the corresponding 
output
automake: object file(s) will be placed in the top-level directory.  However,
automake: this behaviour will change in future Automake versions: they will
automake: unconditionally cause object files to be placed in the same 
subdirectory
automake: of the corresponding sources.
automake: You are advised to start using 'subdir-objects' option throughout your
automake: project, to avoid future incompatibilities.
src/Makefile.am:4: warning: source file '../common/smtppass.c' is in a 
subdirectory,
src/Makefile.am:4: but option 'subdir-objects' is disabled
src/Makefile.am:4: warning: source file '../common/stringx.c' is in a 
subdirectory,
src/Makefile.am:4: but option 'subdir-objects' is disabled
src/Makefile.am:4: warning: source file '../common/sock_any.c' is in a 

Bug#779501: clamsmtp: patch included in 1.10-12 completely breaks the package

2015-03-01 Thread Julien Cristau
Package: clamsmtp
Version: 1.10-12
Severity: grave
Justification: renders package unusable
x-debbugs-cc: Michael Tautschnig m...@debian.org

Dear maintainer,

the removal of _GNU_SOURCE in 1.10-12 following #703538 means strcasestr
is not declared, which results in

../common/smtppass.c: In function ‘parse_xforward’:
../common/smtppass.c:1206:7: warning: assignment makes pointer from integer 
without a cast
 t = strcasestr(line, part);
   ^

and in the compiler taking that value as an int instead of a pointer,
which makes things explode on 64bit.  Please either revert that change
or use something like the following and make sure config.h or usuals.h
is always included first in all source files (and in particular
smtppass.c).  And don't ignore compiler warnings next time around :)

Cheers,
Julien

--- clamsmtp-1.10/common/usuals.h   2007-05-27 01:57:56.0 +0200
+++ clamsmtp-patched/common/usuals.h2015-03-01 16:48:10.684201573 +0100
@@ -39,10 +39,10 @@
 #ifndef __USUALS_H__
 #define __USUALS_H__
 
-#include sys/types.h
-
 #include config.h
 
+#include sys/types.h
+
 #include stdio.h
 #include stdlib.h
 #include errno.h
diff -Nru clamsmtp-1.10/configure.in clamsmtp-patched/configure.in
--- clamsmtp-1.10/configure.in  2008-06-30 19:01:48.0 +0200
+++ clamsmtp-patched/configure.in   2015-03-01 16:40:02.278986882 +0100
@@ -51,6 +51,8 @@
 AC_PROG_LN_S
 AC_PROG_MAKE_SET
 
+AC_USE_SYSTEM_EXTENSIONS
+
 # Debug mode
 AC_ARG_ENABLE(debug, 
 AC_HELP_STRING([--enable-debug],


signature.asc
Description: Digital signature


Bug#779501: clamsmtp: patch included in 1.10-12 completely breaks the package

2015-03-01 Thread Julien Cristau
On Sun, Mar  1, 2015 at 21:02:15 +0100, Michael Meskes wrote:

 On Sun, Mar 01, 2015 at 05:05:59PM +0100, Julien Cristau wrote:
  Package: clamsmtp
  Version: 1.10-12
  Severity: grave
  Justification: renders package unusable
  x-debbugs-cc: Michael Tautschnig m...@debian.org
  ...
 
 Patch doesn't seem to help, see attached. What did I miss?
 
common/smtppass.c needs an update to include config.h before anything
else.

Cheers,
Julien


signature.asc
Description: Digital signature