Bug#781716: gparted: partitioning fails due to lack of udisks2 locking and automount

2015-04-12 Thread Michael Gilbert
control: tag -1 patch, pending

Hi,

I applied and tested upstream's fix for this issue.  It works, so I
uploaded an nmu to delayed/5.  Please let me know if I should delay
longer.

Best wishes,
Mike
diff -Nru gparted-0.19.0/debian/changelog gparted-0.19.0/debian/changelog
--- gparted-0.19.0/debian/changelog	2014-11-09 21:45:29.0 +
+++ gparted-0.19.0/debian/changelog	2015-04-12 19:02:57.0 +
@@ -1,3 +1,11 @@
+gparted (0.19.0-2.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Apply upstream fix to prevent automounting during partitioning on systems
+using udisks2 (closes: #781716).
+
+ -- Michael Gilbert mgilb...@debian.org  Sun, 12 Apr 2015 18:31:55 +
+
 gparted (0.19.0-2) unstable; urgency=medium
 
   * 03_fix-crash.patch: cherry pick of upstream commit that fixes
diff -Nru gparted-0.19.0/debian/patches/04_inhibit-udisks2.patch gparted-0.19.0/debian/patches/04_inhibit-udisks2.patch
--- gparted-0.19.0/debian/patches/04_inhibit-udisks2.patch	1970-01-01 00:00:00.0 +
+++ gparted-0.19.0/debian/patches/04_inhibit-udisks2.patch	2015-04-12 19:02:49.0 +
@@ -0,0 +1,78 @@
+From 4acb8e4fbb9e01d33cc1e9fd89686a3818050690
+From: Curtis Gedak ged...@gmail.com
+Date: Tue, 10 Mar 2015 10:56:47 -0600
+Subject: If available use udisks2-inhibit to prevent automounting (#745349)
+
+In order to prevent potential corruption of newly created file systems,
+when available use udisks2-inhibit with gpartedbin execution to prevent
+automounting.
+
+Original report:
+
+Xubuntu install fail due partition auto mount defeats Gparted
+https://bugs.launchpad.net/ubuntu/+source/thunar/+bug/1078445
+
+Some GNU/Linux distributions use the udisks2 udisksd daemon and have
+udisks2-inhibit at a known location.  The known location is not in the
+default PATH environment variable.
+
+One known distribution that matches this criteria is xubuntu 14.04.
+
+Interestingly neither kubuntu 14.04 nor ubuntu 14.04 appear to have the
+udisks2 udisksd daemon running and do not suffer from this specific
+automounting problem.
+
+Bug 745349 - gparted wrapper script needs updated for udisks2
+
+diff --git a/gparted.in b/gparted.in
+index 54e208f..c435bac 100755
+--- a/gparted.in
 b/gparted.in
+@@ -9,7 +9,7 @@
+ #GParted's operations, or if multiple partition editing
+ #tools are in use concurrently.
+ #
+-# Copyright (C) 2008, 2009, 2010, 2013 Curtis Gedak
++# Copyright (C) 2008, 2009, 2010, 2013, 2015 Curtis Gedak
+ #
+ #  This file is part of GParted.
+ #
+@@ -51,6 +51,17 @@ for k in '' `echo $PATH | sed 's,:, ,g'`; do
+ done
+ 
+ #
++#  Check if udisks2-inhibit exists in known location
++#  and if appropriate daemon is running.
++#
++HAVE_UDISKS2_INHIBIT=no
++if test -x /usr/lib/udisks2/udisks2-inhibit; then
++	if test z`ps -e | grep 'udisksd'` != z; then
++		HAVE_UDISKS2_INHIBIT=yes
++	fi
++fi
++
++#
+ #  Search PATH to determine if udisks program can be found
+ #  and if appropriate daemon is running.
+ #
+@@ -150,7 +161,8 @@ for rule in $UDEV_TEMP_MDADM_RULES; do
+ done
+ 
+ #
+-#  Use both udisks and hal-lock for invocation if both binaries exist and both
++#  Use udisks2-inhibit if udisks2-inhibit exists and deamon running.
++#  Else use both udisks and hal-lock for invocation if both binaries exist and both
+ #  daemons are running.
+ #  Else use udisks if binary exists and daemon is running.
+ #  Else use both devkit-disks and hal-lock for invocation if both binaries exist
+@@ -159,7 +171,9 @@ done
+ #  Otherwise use hal-lock for invocation if binary exists and daemon is running.
+ #  If the above checks fail then simply run gpartedbin.
+ #
+-if test x$HAVE_UDISKS = xyes  test x$HAVE_HAL_LOCK = xyes; then
++if test x$HAVE_UDISKS2_INHIBIT = xyes; then
++	/usr/lib/udisks2/udisks2-inhibit $BASE_CMD
++elif test x$HAVE_UDISKS = xyes  test x$HAVE_HAL_LOCK = xyes; then
+ 	udisks --inhibit -- \
+ 		hal-lock --interface org.freedesktop.Hal.Device.Storage --exclusive \
+ 			--run $BASE_CMD
diff -Nru gparted-0.19.0/debian/patches/series gparted-0.19.0/debian/patches/series
--- gparted-0.19.0/debian/patches/series	2014-11-09 21:38:31.0 +
+++ gparted-0.19.0/debian/patches/series	2015-04-12 19:02:49.0 +
@@ -2,3 +2,5 @@
 02_use-pkexec.patch
 
 03_fix-crash.patch
+
+04_inhibit-udisks2.patch


Processed: Re: Bug#781716: gparted: partitioning fails due to lack of udisks2 locking and automount

2015-04-12 Thread Debian Bug Tracking System
Processing control commands:

 tag -1 patch, pending
Bug #781716 [gparted] gparted: partitioning fails due to lack of udisks2 
locking and automount
Added tag(s) pending and patch.

-- 
781716: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=781716
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems


--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#781716: gparted: partitioning fails due to lack of udisks2 locking and automount

2015-04-01 Thread Chris Bainbridge
Package: gparted
Version: 0.19.0-2
Severity: serious
Tags: upstream
Forwarded: https://bugzilla.gnome.org/show_bug.cgi?id=745349

Gparted does not lock the disk being partitioned, so it will be automounted
whilst gparted is operating on it, resulting in gparted failing mid-operation.

This has been fixed upstream:
https://git.gnome.org/browse/gparted/commit/?id=4acb8e4fbb9e01d33cc1e9fd89686a3818050690


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org