Bug#798765: xtrs: FTBFS with GCC 5: trs_memory.c:152:6: error: type of 'state' defaults to 'int' [-Werror=implicit-int]

[YunQiang Su]

On Sat, 12 Sep 2015 14:17:11 +0200 Andreas Beckmann  wrote:
> Package: xtrs
> Version: 4.9c-3.4
> Severity: serious
> Tags: sid stretch
> Justification: fails to build from source (but built successfully in the past)
>
> Hi,
>
> xtrs FTBFS in sid with GCC 5:
>
> [...]
> /usr/bin/make DEBUG="-Wall -Werror -Wno-error=unused-but-set-variable -O2 -g 
> -D_REENTRANT" PREFIX=/usr
> make[1]: Entering directory '/tmp/buildd/xtrs-4.9c'
> cc -Wall -Werror -Wno-error=unused-but-set-variable -O2 -g -D_REENTRANT  
> -DDEFAULT_ROM='"/usr/local/lib/xtrs/level2rom.hex"' 
> -DDEFAULT_ROM3='"/usr/local/lib/xtrs/romimage.m3"' 
> -DDEFAULT_ROM4P='"/usr/local/lib/xtrs/romimage.m4p"' -DREADLINE 
> -DDISKDIR='"."' -I/usr/include/X11 
> -DAPPDEFAULTS='"/usr/X11/lib/X11/app-defaults"' -DKBWAIT -DHAVE_SIGIO   -c -o 
> z80.o z80.c
> cc -Wall -Werror -Wno-error=unused-but-set-variable -O2 -g -D_REENTRANT  
> -DDEFAULT_ROM='"/usr/local/lib/xtrs/level2rom.hex"' 
> -DDEFAULT_ROM3='"/usr/local/lib/xtrs/romimage.m3"' 
> -DDEFAULT_ROM4P='"/usr/local/lib/xtrs/romimage.m4p"' -DREADLINE 
> -DDISKDIR='"."' -I/usr/include/X11 
> -DAPPDEFAULTS='"/usr/X11/lib/X11/app-defaults"' -DKBWAIT -DHAVE_SIGIO   -c -o 
> main.o main.c
> cc -Wall -Werror -Wno-error=unused-but-set-variable -O2 -g -D_REENTRANT  
> -DDEFAULT_ROM='"/usr/local/lib/xtrs/level2rom.hex"' 
> -DDEFAULT_ROM3='"/usr/local/lib/xtrs/romimage.m3"' 
> -DDEFAULT_ROM4P='"/usr/local/lib/xtrs/romimage.m4p"' -DREADLINE 
> -DDISKDIR='"."' -I/usr/include/X11 
> -DAPPDEFAULTS='"/usr/X11/lib/X11/app-defaults"' -DKBWAIT -DHAVE_SIGIO   -c -o 
> load_cmd.o load_cmd.c
> cc -Wall -Werror -Wno-error=unused-but-set-variable -O2 -g -D_REENTRANT  
> -DDEFAULT_ROM='"/usr/local/lib/xtrs/level2rom.hex"' 
> -DDEFAULT_ROM3='"/usr/local/lib/xtrs/romimage.m3"' 
> -DDEFAULT_ROM4P='"/usr/local/lib/xtrs/romimage.m4p"' -DREADLINE 
> -DDISKDIR='"."' -I/usr/include/X11 
> -DAPPDEFAULTS='"/usr/X11/lib/X11/app-defaults"' -DKBWAIT -DHAVE_SIGIO   -c -o 
> load_hex.o load_hex.c
> cc -Wall -Werror -Wno-error=unused-but-set-variable -O2 -g -D_REENTRANT  
> -DDEFAULT_ROM='"/usr/local/lib/xtrs/level2rom.hex"' 
> -DDEFAULT_ROM3='"/usr/local/lib/xtrs/romimage.m3"' 
> -DDEFAULT_ROM4P='"/usr/local/lib/xtrs/romimage.m4p"' -DREADLINE 
> -DDISKDIR='"."' -I/usr/include/X11 
> -DAPPDEFAULTS='"/usr/X11/lib/X11/app-defaults"' -DKBWAIT -DHAVE_SIGIO   -c -o 
> trs_memory.o trs_memory.c
> trs_memory.c: In function 'mem_romin':
> trs_memory.c:152:6: error: type of 'state' defaults to 'int' 
> [-Werror=implicit-int]
>  void mem_romin(state)
>   ^
> cc1: all warnings being treated as errors
> : recipe for target 'trs_memory.o' failed
> make[1]: *** [trs_memory.o] Error 1
> make[1]: Leaving directory '/tmp/buildd/xtrs-4.9c'
> debian/rules:34: recipe for target 'build-stamp' failed
> make: *** [build-stamp] Error 2
> dpkg-buildpackage: error: debian/rules build gave error exit status 2

I NMUed this package with the attached patch to 5 days delay.

>
>
> Andreas
>
>


xtrs.debdiff
Description: Binary data

Bug#798765: xtrs: FTBFS with GCC 5: trs_memory.c:152:6: error: type of 'state' defaults to 'int' [-Werror=implicit-int]

[Andreas Beckmann]

Package: xtrs
Version: 4.9c-3.4
Severity: serious
Tags: sid stretch
Justification: fails to build from source (but built successfully in the past)

Hi,

xtrs FTBFS in sid with GCC 5:

[...]
/usr/bin/make DEBUG="-Wall -Werror -Wno-error=unused-but-set-variable -O2 -g 
-D_REENTRANT" PREFIX=/usr
make[1]: Entering directory '/tmp/buildd/xtrs-4.9c'
cc -Wall -Werror -Wno-error=unused-but-set-variable -O2 -g -D_REENTRANT  
-DDEFAULT_ROM='"/usr/local/lib/xtrs/level2rom.hex"' 
-DDEFAULT_ROM3='"/usr/local/lib/xtrs/romimage.m3"' 
-DDEFAULT_ROM4P='"/usr/local/lib/xtrs/romimage.m4p"' -DREADLINE -DDISKDIR='"."' 
-I/usr/include/X11 -DAPPDEFAULTS='"/usr/X11/lib/X11/app-defaults"' -DKBWAIT 
-DHAVE_SIGIO   -c -o z80.o z80.c
cc -Wall -Werror -Wno-error=unused-but-set-variable -O2 -g -D_REENTRANT  
-DDEFAULT_ROM='"/usr/local/lib/xtrs/level2rom.hex"' 
-DDEFAULT_ROM3='"/usr/local/lib/xtrs/romimage.m3"' 
-DDEFAULT_ROM4P='"/usr/local/lib/xtrs/romimage.m4p"' -DREADLINE -DDISKDIR='"."' 
-I/usr/include/X11 -DAPPDEFAULTS='"/usr/X11/lib/X11/app-defaults"' -DKBWAIT 
-DHAVE_SIGIO   -c -o main.o main.c
cc -Wall -Werror -Wno-error=unused-but-set-variable -O2 -g -D_REENTRANT  
-DDEFAULT_ROM='"/usr/local/lib/xtrs/level2rom.hex"' 
-DDEFAULT_ROM3='"/usr/local/lib/xtrs/romimage.m3"' 
-DDEFAULT_ROM4P='"/usr/local/lib/xtrs/romimage.m4p"' -DREADLINE -DDISKDIR='"."' 
-I/usr/include/X11 -DAPPDEFAULTS='"/usr/X11/lib/X11/app-defaults"' -DKBWAIT 
-DHAVE_SIGIO   -c -o load_cmd.o load_cmd.c
cc -Wall -Werror -Wno-error=unused-but-set-variable -O2 -g -D_REENTRANT  
-DDEFAULT_ROM='"/usr/local/lib/xtrs/level2rom.hex"' 
-DDEFAULT_ROM3='"/usr/local/lib/xtrs/romimage.m3"' 
-DDEFAULT_ROM4P='"/usr/local/lib/xtrs/romimage.m4p"' -DREADLINE -DDISKDIR='"."' 
-I/usr/include/X11 -DAPPDEFAULTS='"/usr/X11/lib/X11/app-defaults"' -DKBWAIT 
-DHAVE_SIGIO   -c -o load_hex.o load_hex.c
cc -Wall -Werror -Wno-error=unused-but-set-variable -O2 -g -D_REENTRANT  
-DDEFAULT_ROM='"/usr/local/lib/xtrs/level2rom.hex"' 
-DDEFAULT_ROM3='"/usr/local/lib/xtrs/romimage.m3"' 
-DDEFAULT_ROM4P='"/usr/local/lib/xtrs/romimage.m4p"' -DREADLINE -DDISKDIR='"."' 
-I/usr/include/X11 -DAPPDEFAULTS='"/usr/X11/lib/X11/app-defaults"' -DKBWAIT 
-DHAVE_SIGIO   -c -o trs_memory.o trs_memory.c
trs_memory.c: In function 'mem_romin':
trs_memory.c:152:6: error: type of 'state' defaults to 'int' 
[-Werror=implicit-int]
 void mem_romin(state)
  ^
cc1: all warnings being treated as errors
: recipe for target 'trs_memory.o' failed
make[1]: *** [trs_memory.o] Error 1
make[1]: Leaving directory '/tmp/buildd/xtrs-4.9c'
debian/rules:34: recipe for target 'build-stamp' failed
make: *** [build-stamp] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2


Andreas