Bug#862883: Port from libnm-glib/libnm-util to libnm

2018-04-18 Thread Michael Biebl 
Am 18.04.2018 um 19:55 schrieb Pino Toscano:
> In data mercoledì 18 aprile 2018 19:35:01 CEST, Michael Biebl ha scritto:
>> Control: tags -1 + patch
>>
>> I made some more minor tweaks to v2:
>>
>> - Update debian/changelog
>> - Drop debian/patches/add_glib_for_nm, no longer necessary
>>
>> v3 of the debdiff is attached. I was told that it's probably not worth
>> forwarding this upstream, as KDE4 development is pretty much dormant.
> 
> While the KDE 4 development is basically stopped, the code here was
> basically copied into the compatibility framework kdelibs4support;
> hence I'd prefer to see the resolution of #862877 (or at least upstream
> feedback on the patch for it), so the same fix can be backported here
> too.

So, we have upstream feedback now, but I'm not sure what to make of it.
It seems the preference is to simply drop NM support in networkstatus,
given that NM support in kdelibs4support was never actually enabled and
kde-runtime is basically on its way out anyway.

I have no preference either way.

Can you please let me know how you intend to proceed?

Michael
-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?



signature.asc
Description: OpenPGP digital signature

Bug#862883: Port from libnm-glib/libnm-util to libnm

2018-04-18 Thread Pino Toscano 
In data mercoledì 18 aprile 2018 19:35:01 CEST, Michael Biebl ha scritto:
> Control: tags -1 + patch
> 
> I made some more minor tweaks to v2:
> 
> - Update debian/changelog
> - Drop debian/patches/add_glib_for_nm, no longer necessary
> 
> v3 of the debdiff is attached. I was told that it's probably not worth
> forwarding this upstream, as KDE4 development is pretty much dormant.

While the KDE 4 development is basically stopped, the code here was
basically copied into the compatibility framework kdelibs4support;
hence I'd prefer to see the resolution of #862877 (or at least upstream
feedback on the patch for it), so the same fix can be backported here
too.

> I plan to NMU kde-runtime in a week or so and upload to DELAYED/10
> unless I hear back from you. Please holler, if you have any objections.

See above.  Also, there are local changes in the packaging git, and
possibly I should land one/two more (although I have not worked on them
yet).

-- 
Pino Toscano

signature.asc
Description: This is a digitally signed message part.

Bug#862883: Port from libnm-glib/libnm-util to libnm

2018-04-18 Thread Michael Biebl 
Control: tags -1 + patch

I made some more minor tweaks to v2:

- Update debian/changelog
- Drop debian/patches/add_glib_for_nm, no longer necessary

v3 of the debdiff is attached. I was told that it's probably not worth
forwarding this upstream, as KDE4 development is pretty much dormant.

I plan to NMU kde-runtime in a week or so and upload to DELAYED/10
unless I hear back from you. Please holler, if you have any objections.

Regards,
Michael

-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?
diff -Nru kde-runtime-17.08.3/debian/changelog 
kde-runtime-17.08.3/debian/changelog
--- kde-runtime-17.08.3/debian/changelog2018-01-11 09:22:25.0 
+0100
+++ kde-runtime-17.08.3/debian/changelog2018-04-14 15:02:04.0 
+0200
@@ -1,3 +1,12 @@
+kde-runtime (4:17.08.3-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Update solid-networkstatus to use libnm. (Closes: #862883)
+  * Drop debian/patches/add_glib_for_nm, no longer necessary with the above
+changes.
+
+ -- Michael Biebl   Sat, 14 Apr 2018 13:02:04 +
+
 kde-runtime (4:17.08.3-1) unstable; urgency=medium
 
   * Team upload.
diff -Nru kde-runtime-17.08.3/debian/control kde-runtime-17.08.3/debian/control
--- kde-runtime-17.08.3/debian/control  2018-01-06 11:49:18.0 +0100
+++ kde-runtime-17.08.3/debian/control  2018-04-14 15:02:04.0 +0200
@@ -24,7 +24,7 @@
libjpeg-dev,
libkactivities-dev,
liblzma-dev,
-   libnm-util-dev (>= 0.7) [linux-any],
+   libnm-dev (>= 1.0.0) [linux-any],
libntrack-qt4-dev [linux-any],
libopenexr-dev,
libphonon-dev (>= 4:4.6.0really4.4.3),
@@ -35,7 +35,6 @@
libwebp-dev,
libx11-dev,
libxcursor-dev,
-   network-manager-dev (>= 0.7.0) [linux-any],
pkg-config,
pkg-kde-tools (>= 0.12),
shared-mime-info,
diff -Nru kde-runtime-17.08.3/debian/patches/add_glib_for_nm 
kde-runtime-17.08.3/debian/patches/add_glib_for_nm
--- kde-runtime-17.08.3/debian/patches/add_glib_for_nm  2017-05-22 
19:34:05.0 +0200
+++ kde-runtime-17.08.3/debian/patches/add_glib_for_nm  1970-01-01 
01:00:00.0 +0100
@@ -1,25 +0,0 @@
-From: Debian/Kubuntu Qt/KDE Maintainers 
-Date: Sat, 18 Jun 2016 16:24:29 +0200
-Subject: add_glib_for_nm
-

- solid-networkstatus/kded/CMakeLists.txt | 6 ++
- 1 file changed, 6 insertions(+)
-
-diff --git a/solid-networkstatus/kded/CMakeLists.txt 
b/solid-networkstatus/kded/CMakeLists.txt
-index 633c7f1394..5dfcbf4f8d 100644
 a/solid-networkstatus/kded/CMakeLists.txt
-+++ b/solid-networkstatus/kded/CMakeLists.txt
-@@ -16,6 +16,12 @@ set_package_properties(NetworkManager PROPERTIES 
DESCRIPTION "The NetworkManager
-   )
- 
- if(NETWORKMANAGER_FOUND)
-+find_package(PkgConfig REQUIRED)
-+pkg_check_modules(GLIB_PKG glib-2.0)
-+
-+if (GLIB_PKG_FOUND)
-+   include_directories(${GLIB_PKG_INCLUDE_DIRS})
-+endif()
- macro_ensure_version("0.7.0" ${NETWORKMANAGER_VERSION} NM_0_7)
- if(NM_0_7)
- MESSAGE(STATUS "Adding in-process NetworkManager service-wart to kded 
module")
diff -Nru 
kde-runtime-17.08.3/debian/patches/cmake-add-NetworkManager-module.patch 
kde-runtime-17.08.3/debian/patches/cmake-add-NetworkManager-module.patch
--- kde-runtime-17.08.3/debian/patches/cmake-add-NetworkManager-module.patch
1970-01-01 01:00:00.0 +0100
+++ kde-runtime-17.08.3/debian/patches/cmake-add-NetworkManager-module.patch
2018-04-14 15:02:04.0 +0200
@@ -0,0 +1,56 @@
+From 5711ab8b4b053e5d2f4f0b5831ff2a1d37cdf9fa Mon Sep 17 00:00:00 2001
+From: Lubomir Rintel 
+Date: Tue, 19 Dec 2017 19:45:23 +0100
+Subject: [PATCH] cmake: add NetworkManager module
+
+This one looks for libnm as opposed to the deprecated libnm-glib.
+---
+ cmake/modules/FindNetworkManager.cmake | 40 ++
+ 1 file changed, 40 insertions(+)
+ create mode 100644 cmake/modules/FindNetworkManager.cmake
+
+Index: kde-runtime-17.08.3/cmake/modules/FindNetworkManager.cmake
+===
+--- /dev/null
 kde-runtime-17.08.3/cmake/modules/FindNetworkManager.cmake
+@@ -0,0 +1,40 @@
++# - Try to find NetworkManager
++# Once done this will define
++#
++#  NETWORKMANAGER_FOUND - system has NetworkManager
++#  NETWORKMANAGER_INCLUDE_DIRS - the NetworkManager include directories
++#  NETWORKMANAGER_LIBRARIES - the libraries needed to use NetworkManager
++#  NETWORKMANAGER_CFLAGS - Compiler switches required for using NetworkManager
++#  NETWORKMANAGER_VERSION - version number of NetworkManager
++
++# Copyright (c) 2006, Alexander Neundorf, 
++# Copyright (c) 2007, Will Stephenson,

Bug#862883: Port from libnm-glib/libnm-util to libnm

2018-04-18 Thread Michael Biebl 
On Sat, 14 Apr 2018 21:32:30 +0200 Michael Biebl  wrote:
> Am 14.04.2018 um 15:21 schrieb Michael Biebl:
> 
> > I tried updating solid-networkstartus to use QT_NO_KEYWORDS and the Q_
> > macros, but ran into a problem. The QNtrack headers use the slots
> > keyword, so if I set -DQT_NO_KEYWORDS,
> > solid-networkstatus/kded/ntracknetworkstate.cpp fails to compile.
> > 
> > So while I could get the networkmanager backend compile successfully
> > with the attached patch, I had to disable QNtrack support.
> 
> I found a way to avoid that situation.
> As networkmanagerstatus.cpp only uses the D-Bus interface, using
> #include 
> instead of
> #include 
> was sufficient and it avoids that gio related headers are included, so
> -DQT_NO_KEYWORDS is not necessary.
> 
> Lubo, as NM upstream, wdyt about using nm-dbus-interface.h directly
> instead of the include-all NetworkManager.h?
> 
> v2 of the patch is attached.

Thomas Haller just confirmed on IRC that using nm-dbus-interface.h
directly is fine and it was actually designed that way that it can be
used from Qt without dragging in any gio dependencies.

I guess that means v2 of my patch is the better approach, as it avoids
having to rewrite the code to accomodate the use of -DQT_NO_KEYWORDS.

-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?



signature.asc
Description: OpenPGP digital signature

Bug#862883: Port from libnm-glib/libnm-util to libnm

2018-04-14 Thread Michael Biebl 
Am 14.04.2018 um 15:21 schrieb Michael Biebl:

> I tried updating solid-networkstartus to use QT_NO_KEYWORDS and the Q_
> macros, but ran into a problem. The QNtrack headers use the slots
> keyword, so if I set -DQT_NO_KEYWORDS,
> solid-networkstatus/kded/ntracknetworkstate.cpp fails to compile.
> 
> So while I could get the networkmanager backend compile successfully
> with the attached patch, I had to disable QNtrack support.

I found a way to avoid that situation.
As networkmanagerstatus.cpp only uses the D-Bus interface, using
#include 
instead of
#include 
was sufficient and it avoids that gio related headers are included, so
-DQT_NO_KEYWORDS is not necessary.

Lubo, as NM upstream, wdyt about using nm-dbus-interface.h directly
instead of the include-all NetworkManager.h?

v2 of the patch is attached.

Regards,
Michael

-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?
diff -Nru kde-runtime-17.08.3/debian/changelog 
kde-runtime-17.08.3/debian/changelog
--- kde-runtime-17.08.3/debian/changelog2018-01-11 09:22:25.0 
+0100
+++ kde-runtime-17.08.3/debian/changelog2018-04-14 15:02:04.0 
+0200
@@ -1,3 +1,12 @@
+kde-runtime (4:17.08.3-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Update solid-networkstatus to use libnm. (Closes: #862883)
+This requires the use of -DQT_NO_KEYWORDS which is not compatible with
+QNtrack, so disable support for that backend.
+
+ -- Michael Biebl   Sat, 14 Apr 2018 13:02:04 +
+
 kde-runtime (4:17.08.3-1) unstable; urgency=medium
 
   * Team upload.
diff -Nru kde-runtime-17.08.3/debian/control kde-runtime-17.08.3/debian/control
--- kde-runtime-17.08.3/debian/control  2018-01-06 11:49:18.0 +0100
+++ kde-runtime-17.08.3/debian/control  2018-04-14 15:02:04.0 +0200
@@ -24,7 +24,7 @@
libjpeg-dev,
libkactivities-dev,
liblzma-dev,
-   libnm-util-dev (>= 0.7) [linux-any],
+   libnm-dev (>= 1.0.0) [linux-any],
libntrack-qt4-dev [linux-any],
libopenexr-dev,
libphonon-dev (>= 4:4.6.0really4.4.3),
@@ -35,7 +35,6 @@
libwebp-dev,
libx11-dev,
libxcursor-dev,
-   network-manager-dev (>= 0.7.0) [linux-any],
pkg-config,
pkg-kde-tools (>= 0.12),
shared-mime-info,
diff -Nru 
kde-runtime-17.08.3/debian/patches/cmake-add-NetworkManager-module.patch 
kde-runtime-17.08.3/debian/patches/cmake-add-NetworkManager-module.patch
--- kde-runtime-17.08.3/debian/patches/cmake-add-NetworkManager-module.patch
1970-01-01 01:00:00.0 +0100
+++ kde-runtime-17.08.3/debian/patches/cmake-add-NetworkManager-module.patch
2018-04-14 15:02:04.0 +0200
@@ -0,0 +1,56 @@
+From 5711ab8b4b053e5d2f4f0b5831ff2a1d37cdf9fa Mon Sep 17 00:00:00 2001
+From: Lubomir Rintel 
+Date: Tue, 19 Dec 2017 19:45:23 +0100
+Subject: [PATCH] cmake: add NetworkManager module
+
+This one looks for libnm as opposed to the deprecated libnm-glib.
+---
+ cmake/modules/FindNetworkManager.cmake | 40 ++
+ 1 file changed, 40 insertions(+)
+ create mode 100644 cmake/modules/FindNetworkManager.cmake
+
+Index: kde-runtime-17.08.3/cmake/modules/FindNetworkManager.cmake
+===
+--- /dev/null
 kde-runtime-17.08.3/cmake/modules/FindNetworkManager.cmake
+@@ -0,0 +1,40 @@
++# - Try to find NetworkManager
++# Once done this will define
++#
++#  NETWORKMANAGER_FOUND - system has NetworkManager
++#  NETWORKMANAGER_INCLUDE_DIRS - the NetworkManager include directories
++#  NETWORKMANAGER_LIBRARIES - the libraries needed to use NetworkManager
++#  NETWORKMANAGER_CFLAGS - Compiler switches required for using NetworkManager
++#  NETWORKMANAGER_VERSION - version number of NetworkManager
++
++# Copyright (c) 2006, Alexander Neundorf, 
++# Copyright (c) 2007, Will Stephenson, 
++#
++# Redistribution and use is allowed according to the terms of the BSD license.
++# For details see the accompanying COPYING-CMAKE-SCRIPTS file.
++
++
++IF (NETWORKMANAGER_INCLUDE_DIRS)
++   # in cache already
++   SET(NetworkManager_FIND_QUIETLY TRUE)
++ENDIF (NETWORKMANAGER_INCLUDE_DIRS)
++
++IF (NOT WIN32)
++   # use pkg-config to get the directories and then use these values
++   # in the FIND_PATH() and FIND_LIBRARY() calls
++   find_package(PkgConfig)
++   PKG_SEARCH_MODULE( NETWORKMANAGER libnm )
++ENDIF (NOT WIN32)
++
++IF (NETWORKMANAGER_FOUND)
++   IF (NOT NetworkManager_FIND_QUIETLY)
++  MESSAGE(STATUS "Found libnm ${NETWORKMANAGER_VERSION}: 
${NETWORKMANAGER_LIBRARY_DIRS}")
++   ENDIF (NOT NetworkManager_FIND_QUIETLY)
++ELSE (NETWORKMANAGER_FOUND)
++   IF (NetworkManager_FIND_REQUIRED)
++  MESSAGE(FATAL_ERROR "Could NOT find

Bug#862883: Port from libnm-glib/libnm-util to libnm

2018-04-14 Thread Michael Biebl 
Am 14.04.2018 um 14:07 schrieb Michael Biebl:
> Am 14.04.2018 um 14:01 schrieb Michael Biebl:
>> On Wed, 20 Dec 2017 09:58:16 +0100 Lubomir Rintel  wrote:
>>> This doesn't seem to build with current libnm and glib, perhaps because
>>> "signals" is a reserved word in MOC?
> 
>>
>> That said, I'm not really familiar with Qt, so not sure if using
>> -DQT_NO_KEYWORDS + macros like Q_EMIT are consider a proper solution for
>> this kind of problem.
>>
>> KDE maintainers, any suggestions?
> 
> Also related
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=622176
> 
> Seems like using QT_NO_KEYWORDS + the macros is the way to go then

I tried updating solid-networkstartus to use QT_NO_KEYWORDS and the Q_
macros, but ran into a problem. The QNtrack headers use the slots
keyword, so if I set -DQT_NO_KEYWORDS,
solid-networkstatus/kded/ntracknetworkstate.cpp fails to compile.

So while I could get the networkmanager backend compile successfully
with the attached patch, I had to disable QNtrack support.

Would be great to have some feedback from the KDE maintainers on how to
proceed, i.e. if we simply disable the NM support (and keep support for
QNtrack enabled), or apply the attached patch which uses libnm but drops
support QNtrack.

Regards,
Michael



-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?
diff -Nru kde-runtime-17.08.3/debian/changelog 
kde-runtime-17.08.3/debian/changelog
--- kde-runtime-17.08.3/debian/changelog2018-01-11 08:22:25.0 
+
+++ kde-runtime-17.08.3/debian/changelog2018-04-14 13:02:04.0 
+
@@ -1,3 +1,12 @@
+kde-runtime (4:17.08.3-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Update solid-networkstatus to use libnm. (Closes: #862883)
+This requires the use of -DQT_NO_KEYWORDS which is not compatible with
+QNtrack, so disable support for that backend.
+
+ -- Michael Biebl   Sat, 14 Apr 2018 13:02:04 +
+
 kde-runtime (4:17.08.3-1) unstable; urgency=medium
 
   * Team upload.
diff -Nru kde-runtime-17.08.3/debian/control kde-runtime-17.08.3/debian/control
--- kde-runtime-17.08.3/debian/control  2018-01-06 10:49:18.0 +
+++ kde-runtime-17.08.3/debian/control  2018-04-14 12:48:57.0 +
@@ -24,8 +24,7 @@
libjpeg-dev,
libkactivities-dev,
liblzma-dev,
-   libnm-util-dev (>= 0.7) [linux-any],
-   libntrack-qt4-dev [linux-any],
+   libnm-dev (>= 1.0.0) [linux-any],
libopenexr-dev,
libphonon-dev (>= 4:4.6.0really4.4.3),
libpulse-dev (>= 0.9.16),
@@ -35,7 +34,6 @@
libwebp-dev,
libx11-dev,
libxcursor-dev,
-   network-manager-dev (>= 0.7.0) [linux-any],
pkg-config,
pkg-kde-tools (>= 0.12),
shared-mime-info,
diff -Nru 
kde-runtime-17.08.3/debian/patches/cmake-add-NetworkManager-module.patch 
kde-runtime-17.08.3/debian/patches/cmake-add-NetworkManager-module.patch
--- kde-runtime-17.08.3/debian/patches/cmake-add-NetworkManager-module.patch
1970-01-01 00:00:00.0 +
+++ kde-runtime-17.08.3/debian/patches/cmake-add-NetworkManager-module.patch
2018-04-14 12:48:27.0 +
@@ -0,0 +1,56 @@
+From 5711ab8b4b053e5d2f4f0b5831ff2a1d37cdf9fa Mon Sep 17 00:00:00 2001
+From: Lubomir Rintel 
+Date: Tue, 19 Dec 2017 19:45:23 +0100
+Subject: [PATCH] cmake: add NetworkManager module
+
+This one looks for libnm as opposed to the deprecated libnm-glib.
+---
+ cmake/modules/FindNetworkManager.cmake | 40 ++
+ 1 file changed, 40 insertions(+)
+ create mode 100644 cmake/modules/FindNetworkManager.cmake
+
+Index: kde-runtime-17.08.3/cmake/modules/FindNetworkManager.cmake
+===
+--- /dev/null
 kde-runtime-17.08.3/cmake/modules/FindNetworkManager.cmake
+@@ -0,0 +1,40 @@
++# - Try to find NetworkManager
++# Once done this will define
++#
++#  NETWORKMANAGER_FOUND - system has NetworkManager
++#  NETWORKMANAGER_INCLUDE_DIRS - the NetworkManager include directories
++#  NETWORKMANAGER_LIBRARIES - the libraries needed to use NetworkManager
++#  NETWORKMANAGER_CFLAGS - Compiler switches required for using NetworkManager
++#  NETWORKMANAGER_VERSION - version number of NetworkManager
++
++# Copyright (c) 2006, Alexander Neundorf, 
++# Copyright (c) 2007, Will Stephenson, 
++#
++# Redistribution and use is allowed according to the terms of the BSD license.
++# For details see the accompanying COPYING-CMAKE-SCRIPTS file.
++
++
++IF (NETWORKMANAGER_INCLUDE_DIRS)
++   # in cache already
++   SET(NetworkManager_FIND_QUIETLY TRUE)
++ENDIF (NETWORKMANAGER_INCLUDE_DIRS)
++
++IF (NOT WIN32)
++   # use pkg-config to get the directories and then use

Bug#862883: Port from libnm-glib/libnm-util to libnm

2018-04-14 Thread Michael Biebl 
Am 14.04.2018 um 14:01 schrieb Michael Biebl:
> On Wed, 20 Dec 2017 09:58:16 +0100 Lubomir Rintel  wrote:
>> This doesn't seem to build with current libnm and glib, perhaps because
>> "signals" is a reserved word in MOC?

> 
> That said, I'm not really familiar with Qt, so not sure if using
> -DQT_NO_KEYWORDS + macros like Q_EMIT are consider a proper solution for
> this kind of problem.
> 
> KDE maintainers, any suggestions?

Also related
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=622176

Seems like using QT_NO_KEYWORDS + the macros is the way to go then

-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?



signature.asc
Description: OpenPGP digital signature

Bug#862883: Port from libnm-glib/libnm-util to libnm

2018-04-14 Thread Michael Biebl 
On Wed, 20 Dec 2017 09:58:16 +0100 Lubomir Rintel  wrote:
> This doesn't seem to build with current libnm and glib, perhaps because
> "signals" is a reserved word in MOC?
> 
> Build log:
> >   In file included from /usr/include/qt4/QtCore/qobject.h:47:0,
> >  from /usr/include/qt4/QtCore/QObject:1,
> >  from /usr/include/solid/networking.h:25,
> >  from 
> > /home/lkundrak/src/kde-runtime-16.08.3/solid-networkstatus/kded/systemstatusinterface.h:27,
> >  from 
> > /home/lkundrak/src/kde-runtime-16.08.3/solid-networkstatus/kded/networkmanagerstatus.h:27,
> >  from 
> > /home/lkundrak/src/kde-runtime-16.08.3/solid-networkstatus/kded/networkmanagerstatus.cpp:27:
> > /usr/include/glib-2.0/gio/gdbusintrospection.h:155:25: error: expected 
> > unqualified-id before ‘protected’
> >GDBusSignalInfo **signals;
> >  ^
> > In file included from /usr/include/glib-2.0/gio/gio.h:54:0,
> >  from /usr/include/libnm/nm-types.h:24,
> >  from /usr/include/libnm/nm-object.h:29,
> >  from /usr/include/libnm/nm-access-point.h:29,
> >  from /usr/include/libnm/NetworkManager.h:26,
> >  from 
> > /home/lkundrak/src/kde-runtime-16.08.3/solid-networkstatus/kded/networkmanagerstatus.cpp:31:
> > /usr/include/glib-2.0/gio/gdbusintrospection.h:155:24: error: expected ‘;’ 
> > at end of member declaration
> >GDBusSignalInfo **signals;
> > ^
> > /usr/include/glib-2.0/gio/gdbusintrospection.h:155:32: error: expected ‘:’ 
> > before ‘;’ token
> >GDBusSignalInfo **signals;
> > ^
> > solid-networkstatus/kded/CMakeFiles/kded_networkstatus.dir/build.make:228: 
> > recipe for target 
> > 'solid-networkstatus/kded/CMakeFiles/kded_networkstatus.dir/networkmanagerstatus.cpp.o'
> >  failed
> > 

See
https://bugs.kde.org/show_bug.cgi?id=378109
or
https://git.reviewboard.kde.org/r/123091/

Seems very unfortunate, that gdbusintrospection.h uses that name. Maybe
we could convince glib upstream to rename the variable to make it easier
to use glib/gio from KDE/Qt applications and not having to work around
that invidually.

That said, I'm not really familiar with Qt, so not sure if using
-DQT_NO_KEYWORDS + macros like Q_EMIT are consider a proper solution for
this kind of problem.

KDE maintainers, any suggestions?

Michael
-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?



signature.asc
Description: OpenPGP digital signature