Bug#866472: Playing with a different approach for the color profiles

[Xavi Drudis Ferran]

El Mon, Jul 29, 2019 at 02:46:14PM +0200, Agustin Martin deia:
> I am attaching a couple of files with current state of my experiments. I am
> also not fluent with python (that is why I did not adopt or sponsored this
> or any other python package), so my changes would definitely need review, if
> considered.
>

I've tried your packaging and it works in my very limited use case. 
But it still seems to install the files

dpkg -L python-uniconvertor
/usr/lib/python2.7/dist-packages/uniconvertor-2.0rc4/uc2/cms/cmyk_profile_rc.py
/usr/lib/python2.7/dist-packages/uniconvertor-2.0rc4/uc2/cms/display_profile_rc.py
/usr/lib/python2.7/dist-packages/uniconvertor-2.0rc4/uc2/cms/gray_profile_rc.py
/usr/lib/python2.7/dist-packages/uniconvertor-2.0rc4/uc2/cms/lab_profile_rc.py
/usr/lib/python2.7/dist-packages/uniconvertor-2.0rc4/uc2/cms/srgb_profile_rc.py

 
> A DEP5 copyright with file exclusion line is included, which should make
> easier to create a DFSG free tarball.
>

But I think
Files-Excluded: */src/uc2/cms/*_profile.py
should be 
Files-Excluded: */src/uc2/cms/*_profile_rc.py

With that it no longer installs the dubious files.

Neither your debian/watch nor mine worked for me this time for some
reason (the version 2.0~rc4 instead of 2.0rc4 maybe among others), I
ended up with

version=4
opts=compression=gz,repack,uversionmangle=s/rc/~rc/,filenamemangle=s/^.*uniconvertor-(\d.*)\.(tgz|tbz2|tar\.(?:gz|bz2|xz)).*$/python-uniconvertor-$1.$2/
 
https://sk1project.net/modules.php?name=Products&product=uniconvertor&op=download
 .*=uniconvertor-(\d.*)\.(?:tgz|tbz2|tar\.(?:gz|bz2|xz))

(compression=gz is not really necessary, I guess) 

now uscan is happier (it detected the upstream as always newer before)
and deletes the excluded files from the orig.tar.gz archive. 
I hope it stays so the next time I try it, must have tested it wrong before. 

Another nitpick, in debian/copyright  the text 

On Debian systems, the complete text of the GNU General
 Public License version 3 can be found in
 "/usr/share/common-licenses/GPL-2".

should list the correct path for GPLv3:

On Debian systems, the complete text of the GNU General
 Public License version 3 can be found in
 "/usr/share/common-licenses/GPL-3".

Thank you very much for your work. Let's hope it's useful for whoever
ends up being maintainer and they can return python-uniconvertor to
debian.

Bug#866472: Playing with a different approach for the color profiles

[Xavi Drudis Ferran]

El Mon, Jul 29, 2019 at 02:46:14PM +0200, Agustin Martin deia:
> I am attaching a couple of files with current state of my experiments. I am
> also not fluent with python (that is why I did not adopt or sponsored this
> or any other python package), so my changes would definitely need review, if
> considered.
>

It looks fine to me. I'll try it when I can, but I'll only test a very specific 
use case, 
i'm not sure how to test uniconvertor in general. 

Thanks a lot. 

Bug#866472: Playing with a different approach for the color profiles

[Agustin Martin]

On Thu, Jul 11, 2019 at 06:26:49PM +0200, Xavi Drudis Ferran wrote:
> 
> that was the intention of this code in my debian/rules (probably misplaced) 
> 
>   python src/uc2/utils/rcc2py/rcc2py.py 
> /usr/share/color/icc/ghostscript/default_cmyk.icc 
> src/uc2/cms/cmyk_profile_rc.py
>   python src/uc2/utils/rcc2py/rcc2py.py /usr/share/color/icc/Gray.icc 
> src/uc2/cms/gray_profile_rc.py
>   python src/uc2/utils/rcc2py/rcc2py.py /usr/share/color/icc/sRGB.icc 
> src/uc2/cms/srgb_profile_rc.py
> # python src/uc2/utils/rcc2py/rcc2py.py ? 
> src/uc2/cms/display_profile_rc.py
>   python src/uc2/utils/rcc2py/rcc2py.py 
> /usr/share/color/icc/ghostscript/lab.icc src/uc2/cms/lab_profile_rc.py

Hi, Xavi,

Missed how important were these lines, sorry.

I finally had time to look again at this. I am beginning to think that
keeping color profiles obfuscated and turning them available on first
use is not the most convenient thing, so I played with other approach.

I have been playing with using built-in_%s.icm under ~/.config/uc2/profiles
if available, but global profiles otherwise. To make things simpler, I 
set symlinks with similar names from /usr/share/uniconvertor/profiles to
some of the profiles in libgs9-common, and modified code to use them, so the
*_profile_rc.py files could be removed from sources. I am not fluent with
color profiles, and for simplicity I used everything from a single package,
libgs9-common. Regarding display profile, people claim that it depends on
monitor and graphics card, so I simply set it to the RGB profile.

I am attaching a couple of files with current state of my experiments. I am
also not fluent with python (that is why I did not adopt or sponsored this
or any other python package), so my changes would definitely need review, if
considered.

A DEP5 copyright with file exclusion line is included, which should make
easier to create a DFSG free tarball.

Regards,

-- 
Agustin
Format: 3.0 (quilt)
Source: python-uniconvertor
Binary: python-uniconvertor
Architecture: any
Version: 2.0~rc4-1~amd1
Maintainer: Debian QA Group 
Homepage: https://sk1project.net/modules.php?name=Products&product=uniconvertor
Standards-Version: 4.4.0
Build-Depends: debhelper (>= 11), dpkg-dev (>= 1.16.1.1), dh-python, 
python-dev, python-cairo-dev, libcairo2-dev, liblcms2-dev, libpango1.0-dev, 
libmagickwand-6.q16-dev
Package-List:
 python-uniconvertor deb python optional arch=any
Checksums-Sha1:
 4ec122e9d066b339ab3aa4d745fb45505cf76ce8 1088298 
python-uniconvertor_2.0~rc4.orig.tar.gz
 fbb8eec9a014ebe1a7dd4009f27e7b8084a40d5b 7616 
python-uniconvertor_2.0~rc4-1~amd1.debian.tar.xz
Checksums-Sha256:
 98c32fa7255825cb5a395346f77bafa256d78a7b06093dbbb5f612e46371f045 1088298 
python-uniconvertor_2.0~rc4.orig.tar.gz
 a8460afa2cc4c56d10a032ef8f9699bcd8684e051f3a9df96d52dfebf907ab1b 7616 
python-uniconvertor_2.0~rc4-1~amd1.debian.tar.xz
Files:
 84efd5fa55ec8ebea0caaef4f3e0c5a3 1088298 
python-uniconvertor_2.0~rc4.orig.tar.gz
 0f786da922842c0ffad7a953a685025d 7616 
python-uniconvertor_2.0~rc4-1~amd1.debian.tar.xz


python-uniconvertor_2.0~rc4-1~amd1.debian.tar.xz
Description: application/xz


signature.asc
Description: PGP signature