Bug#871059: fltk1.3: FTBFS: Unescaped left brace in regex is illegal here in regex; marked by <-- HERE in m/(\${ <-- HERE _IMPORT_PREFIX}/lib)(?!/x86_64-linux-gnu)/ at debian/fix-fltk-targets-noconfig

2017-08-06 Thread gregor herrmann 
On Sun, 06 Aug 2017 22:00:03 -0400, Aaron M. Ucko wrote:

> gregor herrmann  writes:
> > Here's a patch which escapes the literal left brace in
> > debian/fix-fltk-targets-noconfig.
> I'm already on it, thanks, just want to make a make a few formal
> modernizations while I'm at it.

Great, thank you!
 

Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at/ - Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   


signature.asc
Description: Digital Signature

Bug#871059: fltk1.3: FTBFS: Unescaped left brace in regex is illegal here in regex; marked by <-- HERE in m/(\${ <-- HERE _IMPORT_PREFIX}/lib)(?!/x86_64-linux-gnu)/ at debian/fix-fltk-targets-noconfig

2017-08-06 Thread Aaron M. Ucko 
gregor herrmann  writes:

> Here's a patch which escapes the literal left brace in
> debian/fix-fltk-targets-noconfig.

I'm already on it, thanks, just want to make a make a few formal
modernizations while I'm at it.

See you around.

-- 
Aaron M. Ucko, KB1CJC (amu at alum.mit.edu, ucko at debian.org)
http://www.mit.edu/~amu/ | http://stuff.mit.edu/cgi/finger/?a...@monk.mit.edu

Bug#871059: fltk1.3: FTBFS: Unescaped left brace in regex is illegal here in regex; marked by <-- HERE in m/(\${ <-- HERE _IMPORT_PREFIX}/lib)(?!/x86_64-linux-gnu)/ at debian/fix-fltk-targets-noconfig

2017-08-06 Thread gregor herrmann 
Control: tag -1 + patch

On Sun, 06 Aug 2017 17:48:19 -0400, Lucas Nussbaum wrote:

> Source: fltk1.3
> Version: 1.3.4-4
> Severity: serious
> Tags: buster sid
> User: debian...@lists.debian.org
> Usertags: qa-ftbfs-20170805 qa-ftbfs
> Justification: FTBFS on amd64
> 
> > debian/fix-fltk-targets-noconfig \
> > CMakeTmp/CMakeFiles/Export/share/fltk/FLTK-Targets-noconfig.cmake \
> > > CMakeTmp/etc/FLTK-Targets-noconfig.cmake
> > Unescaped left brace in regex is illegal here in regex; marked by <-- HERE 
> > in m/(\${ <-- HERE _IMPORT_PREFIX}/lib)(?!/x86_64-linux-gnu)/ at 
> > debian/fix-fltk-targets-noconfig line 6, <> line 1.
> > debian/rules:33: recipe for target 'override_dh_auto_configure' failed
> > make[1]: *** [override_dh_auto_configure] Error 25

Here's a patch which escapes the literal left brace in
debian/fix-fltk-targets-noconfig.


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at/ - Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   
diff -Nru fltk1.3-1.3.4/debian/.gitignore fltk1.3-1.3.4/debian/.gitignore
--- fltk1.3-1.3.4/debian/.gitignore	2017-01-16 18:26:31.0 -0500
+++ fltk1.3-1.3.4/debian/.gitignore	1969-12-31 19:00:00.0 -0500
@@ -1,13 +0,0 @@
-*.debhelper
-*.debhelper.log
-*.substvars
-common-build-stamp
-debhelper-build-stamp
-files
-fltk1.3-doc
-fltk1.3-games
-fluid
-libfltk*1.3
-libfltk1.3-dev
-libfltk1.3-compat-headers
-tmp
diff -Nru fltk1.3-1.3.4/debian/changelog fltk1.3-1.3.4/debian/changelog
--- fltk1.3-1.3.4/debian/changelog	2017-02-22 22:28:48.0 -0500
+++ fltk1.3-1.3.4/debian/changelog	2017-08-06 21:39:02.0 -0400
@@ -1,3 +1,12 @@
+fltk1.3 (1.3.4-4.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix "FTBFS: Unescaped left brace in regex is illegal here in regex;"
+escape literal left brace in debian/fix-fltk-targets-noconfig.
+(Closes: #871059)
+
+ -- gregor herrmann   Sun, 06 Aug 2017 21:39:02 -0400
+
 fltk1.3 (1.3.4-4) unstable; urgency=medium
 
   * debian/control: Build-depend on libxcursor-dev.  (Closes: #855863.)
diff -Nru fltk1.3-1.3.4/debian/fix-fltk-targets-noconfig fltk1.3-1.3.4/debian/fix-fltk-targets-noconfig
--- fltk1.3-1.3.4/debian/fix-fltk-targets-noconfig	2017-02-13 22:08:01.0 -0500
+++ fltk1.3-1.3.4/debian/fix-fltk-targets-noconfig	2017-08-06 21:39:02.0 -0400
@@ -3,7 +3,7 @@
 
 my $to_untag = '';
 while (<>) {
-s,(\${_IMPORT_PREFIX}/lib)(?!/$ENV{DEB_HOST_MULTIARCH}),$1/$ENV{DEB_HOST_MULTIARCH},g;
+s,(\$\{_IMPORT_PREFIX}/lib)(?!/$ENV{DEB_HOST_MULTIARCH}),$1/$ENV{DEB_HOST_MULTIARCH},g;
 s,\.so\.1\.3\.\d*,\.so,g;
 s,([^a-z]fltk\w*(?

signature.asc
Description: Digital Signature

Bug#871059: fltk1.3: FTBFS: Unescaped left brace in regex is illegal here in regex; marked by <-- HERE in m/(\${ <-- HERE _IMPORT_PREFIX}/lib)(?!/x86_64-linux-gnu)/ at debian/fix-fltk-targets-noconfig

2017-08-06 Thread Lucas Nussbaum 
Source: fltk1.3
Version: 1.3.4-4
Severity: serious
Tags: buster sid
User: debian...@lists.debian.org
Usertags: qa-ftbfs-20170805 qa-ftbfs
Justification: FTBFS on amd64

Hi,

During a rebuild of all packages in sid, your package failed to build on
amd64.

Relevant part (hopefully):
> make[1]: Entering directory '/<>'
> [ -e fltk.spec.saved ] || mv fltk.spec fltk.spec.saved
> mkdir -p CMakeTmp
> cd CMakeTmp  &&  cmake -DCC:STRING="cc" -DCXX:STRING="g++" \
> -DCMAKE_INSTALL_PREFIX:STRING=/usr -DOPTION_CAIRO:BOOL=ON \
> -DOPTION_BUILD_SHARED_LIBS:BOOL=ON -DOPTION_CREATE_LINKS:BOOL=ON \
> -DOPTION_BUILD_EXAMPLES:BOOL=OFF ..
> -- The C compiler identification is GNU 7.1.0
> -- The CXX compiler identification is GNU 7.1.0
> -- Check for working C compiler: /usr/bin/cc
> -- Check for working C compiler: /usr/bin/cc -- works
> -- Detecting C compiler ABI info
> -- Detecting C compiler ABI info - done
> -- Detecting C compile features
> -- Detecting C compile features - done
> -- Check for working CXX compiler: /usr/bin/c++
> -- Check for working CXX compiler: /usr/bin/c++ -- works
> -- Detecting CXX compiler ABI info
> -- Detecting CXX compiler ABI info - done
> CMake Warning (dev) at 
> /usr/share/cmake-3.9/Modules/CMakeDetermineCompilerABI.cmake:78 (if):
>   Policy CMP0054 is not set: Only interpret if() arguments as variables or
>   keywords when unquoted.  Run "cmake --help-policy CMP0054" for policy
>   details.  Use the cmake_policy command to set the policy and suppress this
>   warning.
> 
>   Quoted variables like "CXX" will no longer be dereferenced when the policy
>   is set to NEW.  Since the policy is not set the OLD behavior will be used.
> Call Stack (most recent call first):
>   /usr/share/cmake-3.9/Modules/CMakeTestCXXCompiler.cmake:58 
> (CMAKE_DETERMINE_COMPILER_ABI)
>   CMakeLists.txt:24 (project)
> This warning is for project developers.  Use -Wno-dev to suppress it.
> 
> -- Check if the system is big endian
> -- Searching 16 bit integer
> -- Looking for sys/types.h
> -- Looking for sys/types.h - found
> -- Looking for stdint.h
> -- Looking for stdint.h - found
> -- Looking for stddef.h
> -- Looking for stddef.h - found
> -- Check size of unsigned short
> -- Check size of unsigned short - done
> -- Using unsigned short
> CMake Warning (dev) at /usr/share/cmake-3.9/Modules/TestBigEndian.cmake:56 
> (if):
>   Policy CMP0054 is not set: Only interpret if() arguments as variables or
>   keywords when unquoted.  Run "cmake --help-policy CMP0054" for policy
>   details.  Use the cmake_policy command to set the policy and suppress this
>   warning.
> 
>   Quoted variables like "CXX" will no longer be dereferenced when the policy
>   is set to NEW.  Since the policy is not set the OLD behavior will be used.
> Call Stack (most recent call first):
>   CMake/setup.cmake:90 (TEST_BIG_ENDIAN)
>   CMakeLists.txt:36 (include)
> This warning is for project developers.  Use -Wno-dev to suppress it.
> 
> -- Check if the system is big endian - little endian
> -- Check size of short
> -- Check size of short - done
> -- Check size of int
> -- Check size of int - done
> -- Check size of long
> -- Check size of long - done
> -- Check size of long long
> -- Check size of long long - done
> -- Looking for dlsym
> -- Looking for dlsym - found
> -- Looking for localeconv
> -- Looking for localeconv - found
> -- Looking for png_get_valid
> -- Looking for png_get_valid - found
> -- Looking for png_set_tRNS_to_alpha
> -- Looking for png_set_tRNS_to_alpha - found
> -- Looking for scandir
> -- Looking for scandir - found
> -- Looking for snprintf
> -- Looking for snprintf - found
> -- Looking for strcasecmp
> -- Looking for strcasecmp - found
> -- Looking for strlcat
> -- Looking for strlcat - not found
> -- Looking for strlcpy
> -- Looking for strlcpy - not found
> -- Looking for vsnprintf
> -- Looking for vsnprintf - found
> -- Looking for POSIX compatible scandir
> -- POSIX compatible scandir - found
> -- Found Doxygen: /usr/bin/doxygen (found version "1.8.13") found components: 
>  doxygen missing components:  dot
> -- Found LATEX: /usr/bin/latex   
> -- Looking for XOpenDisplay in 
> /usr/lib/x86_64-linux-gnu/libX11.so;/usr/lib/x86_64-linux-gnu/libXext.so
> -- Looking for XOpenDisplay in 
> /usr/lib/x86_64-linux-gnu/libX11.so;/usr/lib/x86_64-linux-gnu/libXext.so - 
> found
> -- Looking for gethostbyname
> -- Looking for gethostbyname - found
> -- Looking for connect
> -- Looking for connect - found
> -- Looking for remove
> -- Looking for remove - found
> -- Looking for shmat
> -- Looking for shmat - found
> -- Looking for IceConnectionNumber in ICE
> -- Looking for IceConnectionNumber in ICE - found
> -- Found X11: /usr/lib/x86_64-linux-gnu/libX11.so
> -- Found PkgConfig: /usr/bin/pkg-config (found version "0.29") 
> -- Checking for one of the modules 'cairo'
> -- Found OpenGL: /usr/lib/x86_64-linux-gnu/libGL.so  
> -- Looking for glXGetProcAddressARB
> -- Looking for glXGetProcAddressARB - found
> --