Bug#876147: camp frequently FTBFS on 64bit big endian: camptest-qt (Failed)

[Flavien Bridault]

Thanks for the cleaning and the upload.

I should keep in mind to run `cme fix dpkg-control` each time.


Cheers,


Le 16/04/2018 à 16:49, Andreas Tille a écrit :
> Hi Flavien,
>
> thanks a lot for working on this.
>
> On Mon, Apr 16, 2018 at 04:07:46PM +0200, Flavien Bridault wrote:
>> This looks ok for me now, I updated to 0.8.2 which includes the fix
>> proposal. Please upload if that looks ok for you.
> I had some packaging updates and thus deleted your tag.  Please delete
> in your local repository and pull.
>
> The package is uploaded now.
>
> Kind regards
>
>Andreas.
>

-- 
*Flavien BRIDAULT*
Ingénieur de Recherche

fbrida...@ircad.fr

*IRCAD France*
1, place de l'Hôpital - 67091 Strasbourg Cedex - FRANCE

http://www.ircad.fr/ 




signature.asc
Description: OpenPGP digital signature

Bug#876147: camp frequently FTBFS on 64bit big endian: camptest-qt (Failed)

[Andreas Tille]

Hi Flavien,

thanks a lot for working on this.

On Mon, Apr 16, 2018 at 04:07:46PM +0200, Flavien Bridault wrote:
> This looks ok for me now, I updated to 0.8.2 which includes the fix
> proposal. Please upload if that looks ok for you.

I had some packaging updates and thus deleted your tag.  Please delete
in your local repository and pull.

The package is uploaded now.

Kind regards

   Andreas.

-- 
http://fam-tille.de

Bug#876147: [Debian-med-packaging] Bug#876147: Bug#876147: camp frequently FTBFS on 64bit big endian: camptest-qt (Failed)

[Flavien Bridault]

Hi guys,

This looks ok for me now, I updated to 0.8.2 which includes the fix
proposal. Please upload if that looks ok for you.

Cheers,


Le 16/04/2018 à 14:47, Flavien Bridault a écrit :
> Ok great, as soon as the merge request is accepted upstream, which
> should happen very soon, I'll propose the update.
>
> Thanks a lot for testing this.
>
> Le 16/04/2018 à 14:34, John Paul Adrian Glaubitz a écrit :
>> On 04/16/2018 02:21 PM, Flavien Bridault wrote:
>>> Sorry the patch is ofc meant to be applied on the raw upstream, not
>>> after debian patches being applied. I was applying it directly into the
>>> git repo so that's why I did not have any issue. If you want to keep
>>> trying it this way, I attached a rebased version of the patch that
>>> should apply well on top of other.
>> Ok, this works:
>>
>> (sid_s390x-dchroot)glaubitz@zelenka:~/camp/camp-0.8.1/obj-s390x-linux-gnu$
>> make test
>> Running tests...
>> /usr/bin/ctest --force-new-ctest-process
>> Test project /home/glaubitz/camp/camp-0.8.1/obj-s390x-linux-gnu
>>     Start 1: camptest
>> 1/2 Test #1: camptest .   Passed    0.01 sec
>>     Start 2: camptest-qt
>> 2/2 Test #2: camptest-qt ..   Passed    0.00 sec
>>
>> 100% tests passed, 0 tests failed out of 2
>>
>> Total Test time (real) =   0.02 sec
>> (sid_s390x-dchroot)glaubitz@zelenka:~/camp/camp-0.8.1/obj-s390x-linux-gnu$
>>
>>
>
>
> ___
> Debian-med-packaging mailing list
> debian-med-packag...@alioth-lists.debian.net
> https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/debian-med-packaging

-- 
*Flavien BRIDAULT*
Ingénieur de Recherche

fbrida...@ircad.fr

*IRCAD France*
1, place de l'Hôpital - 67091 Strasbourg Cedex - FRANCE

http://www.ircad.fr/ 



signature.asc
Description: OpenPGP digital signature

Bug#876147: [Debian-med-packaging] Bug#876147: Bug#876147: camp frequently FTBFS on 64bit big endian: camptest-qt (Failed)

[Flavien Bridault]

Ok great, as soon as the merge request is accepted upstream, which
should happen very soon, I'll propose the update.

Thanks a lot for testing this.

Le 16/04/2018 à 14:34, John Paul Adrian Glaubitz a écrit :
> On 04/16/2018 02:21 PM, Flavien Bridault wrote:
>> Sorry the patch is ofc meant to be applied on the raw upstream, not
>> after debian patches being applied. I was applying it directly into the
>> git repo so that's why I did not have any issue. If you want to keep
>> trying it this way, I attached a rebased version of the patch that
>> should apply well on top of other.
>
> Ok, this works:
>
> (sid_s390x-dchroot)glaubitz@zelenka:~/camp/camp-0.8.1/obj-s390x-linux-gnu$
> make test
> Running tests...
> /usr/bin/ctest --force-new-ctest-process
> Test project /home/glaubitz/camp/camp-0.8.1/obj-s390x-linux-gnu
>     Start 1: camptest
> 1/2 Test #1: camptest .   Passed    0.01 sec
>     Start 2: camptest-qt
> 2/2 Test #2: camptest-qt ..   Passed    0.00 sec
>
> 100% tests passed, 0 tests failed out of 2
>
> Total Test time (real) =   0.02 sec
> (sid_s390x-dchroot)glaubitz@zelenka:~/camp/camp-0.8.1/obj-s390x-linux-gnu$
>
>

-- 
*Flavien BRIDAULT*
Ingénieur de Recherche

fbrida...@ircad.fr

*IRCAD France*
1, place de l'Hôpital - 67091 Strasbourg Cedex - FRANCE

http://www.ircad.fr/ 




signature.asc
Description: OpenPGP digital signature

Bug#876147: [Debian-med-packaging] Bug#876147: Bug#876147: camp frequently FTBFS on 64bit big endian: camptest-qt (Failed)

[John Paul Adrian Glaubitz]

On 04/16/2018 02:21 PM, Flavien Bridault wrote:

Sorry the patch is ofc meant to be applied on the raw upstream, not
after debian patches being applied. I was applying it directly into the
git repo so that's why I did not have any issue. If you want to keep
trying it this way, I attached a rebased version of the patch that
should apply well on top of other.


Ok, this works:

(sid_s390x-dchroot)glaubitz@zelenka:~/camp/camp-0.8.1/obj-s390x-linux-gnu$ make 
test
Running tests...
/usr/bin/ctest --force-new-ctest-process
Test project /home/glaubitz/camp/camp-0.8.1/obj-s390x-linux-gnu
Start 1: camptest
1/2 Test #1: camptest .   Passed0.01 sec
Start 2: camptest-qt
2/2 Test #2: camptest-qt ..   Passed0.00 sec

100% tests passed, 0 tests failed out of 2

Total Test time (real) =   0.02 sec
(sid_s390x-dchroot)glaubitz@zelenka:~/camp/camp-0.8.1/obj-s390x-linux-gnu$

--
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaub...@debian.org
`. `'   Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

Bug#876147: [Debian-med-packaging] Bug#876147: Bug#876147: camp frequently FTBFS on 64bit big endian: camptest-qt (Failed)

[Flavien Bridault]

Sorry the patch is ofc meant to be applied on the raw upstream, not
after debian patches being applied. I was applying it directly into the
git repo so that's why I did not have any issue. If you want to keep
trying it this way, I attached a rebased version of the patch that
should apply well on top of other.


Le 16/04/2018 à 13:49, John Paul Adrian Glaubitz a écrit :
> On 04/16/2018 11:58 AM, Flavien Bridault wrote:
>> Weird, it applies well for me on the master branch of the debian
>> repository. Try the patch attached to this email or directly this link
>>
>> https://patch-diff.githubusercontent.com/raw/fw4spl-org/camp/pull/2.diff
>
> Tried to apply against the current package in Debian unstable:
>
> glaubitz@zelenka:~$ md5sum fix-s390.diff
> 3fae8e5c44e239e74e2ef14a667126b4  fix-s390.diff
> glaubitz@zelenka:~$ cd camp/
> glaubitz@zelenka:~/camp$ dget -u
> http://deb.debian.org/debian/pool/main/c/camp/camp_0.8.1-2.dsc
> dget: retrieving
> http://deb.debian.org/debian/pool/main/c/camp/camp_0.8.1-2.dsc
>   % Total    % Received % Xferd  Average Speed   Time    Time
> Time  Current
>  Dload  Upload   Total   Spent   
> Left  Speed
> 100   321  100   321    0 0   4346  0 --:--:-- --:--:--
> --:--:--  4397
> 100  2000  100  2000    0 0  20750  0 --:--:-- --:--:--
> --:--:-- 20750
> dget: retrieving
> http://deb.debian.org/debian/pool/main/c/camp/camp_0.8.1.orig.tar.gz
>   % Total    % Received % Xferd  Average Speed   Time    Time
> Time  Current
>  Dload  Upload   Total   Spent   
> Left  Speed
> 100   327  100   327    0 0   4570  0 --:--:-- --:--:--
> --:--:--  4605
> 100  534k  100  534k    0 0  4044k  0 --:--:-- --:--:--
> --:--:-- 4044k
> dget: retrieving
> http://deb.debian.org/debian/pool/main/c/camp/camp_0.8.1-2.debian.tar.xz
>   % Total    % Received % Xferd  Average Speed   Time    Time
> Time  Current
>  Dload  Upload   Total   Spent   
> Left  Speed
> 100   331  100   331    0 0   4809  0 --:--:-- --:--:--
> --:--:--  4867
> 100  5272  100  5272    0 0  63979  0 --:--:-- --:--:--
> --:--:-- 63979
> dpkg-source: info: extracting camp in camp-0.8.1
> dpkg-source: info: unpacking camp_0.8.1.orig.tar.gz
> dpkg-source: info: unpacking camp_0.8.1-2.debian.tar.xz
> dpkg-source: info: applying remove_licences_files.patch
> dpkg-source: info: applying hide_boost_from_qt4moc.patch
> glaubitz@zelenka:~/camp$ cd camp-0.8.1/
> glaubitz@zelenka:~/camp/camp-0.8.1$ patch -p1 < ~/fix-s390x.patch
> patching file .gitignore
> patching file include/camp/qt/qtfunction.hpp
> patching file include/camp/qt/qthelper.hpp
> patching file include/camp/valuemapper.hpp
> Hunk #2 FAILED at 40.
> Hunk #3 succeeded at 96 (offset 2 lines).
> Hunk #4 succeeded at 126 (offset 2 lines).
> Hunk #5 succeeded at 139 (offset 2 lines).
> Hunk #6 succeeded at 156 (offset 2 lines).
> Hunk #7 succeeded at 183 (offset 2 lines).
> Hunk #8 succeeded at 205 (offset 2 lines).
> Hunk #9 succeeded at 234 (offset 2 lines).
> Hunk #10 succeeded at 250 (offset 2 lines).
> Hunk #11 succeeded at 279 (offset 2 lines).
> Hunk #12 succeeded at 326 (offset 2 lines).
> Hunk #13 succeeded at 345 (offset 2 lines).
> 1 out of 13 hunks FAILED -- saving rejects to file
> include/camp/valuemapper.hpp.rej
> patching file test/arrayproperty.hpp
> Hunk #2 FAILED at 32.
> Hunk #3 succeeded at 78 (offset 2 lines).
> 1 out of 3 hunks FAILED -- saving rejects to file
> test/arrayproperty.hpp.rej
> patching file test/qt/propertymapping.cpp
> Hunk #2 succeeded at 34 with fuzz 2 (offset 2 lines).
> Hunk #3 succeeded at 47 (offset 2 lines).
> Hunk #4 succeeded at 95 (offset 2 lines).
> Hunk #5 succeeded at 106 (offset 2 lines).
> glaubitz@zelenka:~/camp/camp-0.8.1$
>

-- 
*Flavien BRIDAULT*
Ingénieur de Recherche

fbrida...@ircad.fr

*IRCAD France*
1, place de l'Hôpital - 67091 Strasbourg Cedex - FRANCE

http://www.ircad.fr/ 

diff -uNr camp-0.8.1.old/.gitignore camp-0.8.1/.gitignore
--- camp-0.8.1.old/.gitignore	2018-04-16 14:08:14.403457120 +0200
+++ camp-0.8.1/.gitignore	2018-04-16 14:08:19.987457060 +0200
@@ -28,6 +28,7 @@
 *.o
 *.a
 moc_*
+build/
 
 *.cmake
 CMakeFiles/
diff -uNr camp-0.8.1.old/include/camp/qt/qtfunction.hpp camp-0.8.1/include/camp/qt/qtfunction.hpp
--- camp-0.8.1.old/include/camp/qt/qtfunction.hpp	2018-04-16 14:08:14.411457120 +0200
+++ camp-0.8.1/include/camp/qt/qtfunction.hpp	2018-04-16 14:08:19.987457060 +0200
@@ -15,10 +15,10 @@
 ** to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 ** copies of the Software, and to permit persons to whom the Software is
 ** furnished to do so, subject to the following conditions:
-** 
+**
 ** The above copyright notice and this permission notice shall be included in
 ** all copies or substantial portions of the Software.
-** 
+**
 ** THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 ** 

Bug#876147: [Debian-med-packaging] Bug#876147: Bug#876147: camp frequently FTBFS on 64bit big endian: camptest-qt (Failed)

[John Paul Adrian Glaubitz]

On 04/16/2018 11:58 AM, Flavien Bridault wrote:

Weird, it applies well for me on the master branch of the debian
repository. Try the patch attached to this email or directly this link

https://patch-diff.githubusercontent.com/raw/fw4spl-org/camp/pull/2.diff


Tried to apply against the current package in Debian unstable:

glaubitz@zelenka:~$ md5sum fix-s390.diff
3fae8e5c44e239e74e2ef14a667126b4  fix-s390.diff
glaubitz@zelenka:~$ cd camp/
glaubitz@zelenka:~/camp$ dget -u 
http://deb.debian.org/debian/pool/main/c/camp/camp_0.8.1-2.dsc
dget: retrieving http://deb.debian.org/debian/pool/main/c/camp/camp_0.8.1-2.dsc
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
100   321  100   3210 0   4346  0 --:--:-- --:--:-- --:--:--  4397
100  2000  100  20000 0  20750  0 --:--:-- --:--:-- --:--:-- 20750
dget: retrieving 
http://deb.debian.org/debian/pool/main/c/camp/camp_0.8.1.orig.tar.gz
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
100   327  100   3270 0   4570  0 --:--:-- --:--:-- --:--:--  4605
100  534k  100  534k0 0  4044k  0 --:--:-- --:--:-- --:--:-- 4044k
dget: retrieving 
http://deb.debian.org/debian/pool/main/c/camp/camp_0.8.1-2.debian.tar.xz
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
100   331  100   3310 0   4809  0 --:--:-- --:--:-- --:--:--  4867
100  5272  100  52720 0  63979  0 --:--:-- --:--:-- --:--:-- 63979
dpkg-source: info: extracting camp in camp-0.8.1
dpkg-source: info: unpacking camp_0.8.1.orig.tar.gz
dpkg-source: info: unpacking camp_0.8.1-2.debian.tar.xz
dpkg-source: info: applying remove_licences_files.patch
dpkg-source: info: applying hide_boost_from_qt4moc.patch
glaubitz@zelenka:~/camp$ cd camp-0.8.1/
glaubitz@zelenka:~/camp/camp-0.8.1$ patch -p1 < ~/fix-s390x.patch
patching file .gitignore
patching file include/camp/qt/qtfunction.hpp
patching file include/camp/qt/qthelper.hpp
patching file include/camp/valuemapper.hpp
Hunk #2 FAILED at 40.
Hunk #3 succeeded at 96 (offset 2 lines).
Hunk #4 succeeded at 126 (offset 2 lines).
Hunk #5 succeeded at 139 (offset 2 lines).
Hunk #6 succeeded at 156 (offset 2 lines).
Hunk #7 succeeded at 183 (offset 2 lines).
Hunk #8 succeeded at 205 (offset 2 lines).
Hunk #9 succeeded at 234 (offset 2 lines).
Hunk #10 succeeded at 250 (offset 2 lines).
Hunk #11 succeeded at 279 (offset 2 lines).
Hunk #12 succeeded at 326 (offset 2 lines).
Hunk #13 succeeded at 345 (offset 2 lines).
1 out of 13 hunks FAILED -- saving rejects to file 
include/camp/valuemapper.hpp.rej
patching file test/arrayproperty.hpp
Hunk #2 FAILED at 32.
Hunk #3 succeeded at 78 (offset 2 lines).
1 out of 3 hunks FAILED -- saving rejects to file test/arrayproperty.hpp.rej
patching file test/qt/propertymapping.cpp
Hunk #2 succeeded at 34 with fuzz 2 (offset 2 lines).
Hunk #3 succeeded at 47 (offset 2 lines).
Hunk #4 succeeded at 95 (offset 2 lines).
Hunk #5 succeeded at 106 (offset 2 lines).
glaubitz@zelenka:~/camp/camp-0.8.1$

--
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaub...@debian.org
`. `'   Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

Bug#876147: [Debian-med-packaging] Bug#876147: Bug#876147: camp frequently FTBFS on 64bit big endian: camptest-qt (Failed)

[Flavien Bridault]

Weird, it applies well for me on the master branch of the debian
repository. Try the patch attached to this email or directly this link

https://patch-diff.githubusercontent.com/raw/fw4spl-org/camp/pull/2.diff


Le 16/04/2018 à 11:21, John Paul Adrian Glaubitz a écrit :
> On 04/16/2018 11:16 AM, John Paul Adrian Glaubitz wrote:
>>> Meanwhile I commited a fix upstream
>>> (https://github.com/fw4spl-org/camp/pull/2) so I would just want to try
>>> it before proposing the fix in the package.
>> I'll test that for you on s390x.
>
> That patch doesn't apply to the Debian version of camp:
>
> glaubitz@zelenka:~/camp/camp-0.8.1$ patch -p1 < ~/fix-s390x.patch
> patching file .gitignore
> patching file include/camp/qt/qtfunction.hpp
> patching file include/camp/qt/qthelper.hpp
> patching file include/camp/valuemapper.hpp
> Hunk #2 FAILED at 40.
> Hunk #3 succeeded at 96 (offset 2 lines).
> Hunk #4 succeeded at 126 (offset 2 lines).
> Hunk #5 succeeded at 139 (offset 2 lines).
> Hunk #6 succeeded at 156 (offset 2 lines).
> Hunk #7 succeeded at 183 (offset 2 lines).
> Hunk #8 succeeded at 205 (offset 2 lines).
> Hunk #9 succeeded at 234 (offset 2 lines).
> Hunk #10 succeeded at 250 (offset 2 lines).
> Hunk #11 succeeded at 279 (offset 2 lines).
> Hunk #12 succeeded at 326 (offset 2 lines).
> Hunk #13 succeeded at 345 (offset 2 lines).
> 1 out of 13 hunks FAILED -- saving rejects to file
> include/camp/valuemapper.hpp.rej
> patching file test/arrayproperty.hpp
> Hunk #2 FAILED at 32.
> Hunk #3 succeeded at 78 (offset 2 lines).
> 1 out of 3 hunks FAILED -- saving rejects to file
> test/arrayproperty.hpp.rej
> patching file test/qt/propertymapping.cpp
> Hunk #2 succeeded at 34 with fuzz 2 (offset 2 lines).
> Hunk #3 succeeded at 47 (offset 2 lines).
> Hunk #4 succeeded at 95 (offset 2 lines).
> Hunk #5 succeeded at 106 (offset 2 lines).
> glaubitz@zelenka:~/camp/camp-0.8.1$
>

-- 
*Flavien BRIDAULT*
Ingénieur de Recherche

fbrida...@ircad.fr

*IRCAD France*
1, place de l'Hôpital - 67091 Strasbourg Cedex - FRANCE

http://www.ircad.fr/ 

diff --git a/.gitignore b/.gitignore
index ce734c4..9a073a8 100644
--- a/.gitignore
+++ b/.gitignore
@@ -28,6 +28,7 @@ qtc-gdbmacros/
 *.o
 *.a
 moc_*
+build/
 
 *.cmake
 CMakeFiles/
diff --git a/include/camp/qt/qtfunction.hpp b/include/camp/qt/qtfunction.hpp
index 96484ab..912383b 100644
--- a/include/camp/qt/qtfunction.hpp
+++ b/include/camp/qt/qtfunction.hpp
@@ -15,10 +15,10 @@
 ** to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 ** copies of the Software, and to permit persons to whom the Software is
 ** furnished to do so, subject to the following conditions:
-** 
+**
 ** The above copyright notice and this permission notice shall be included in
 ** all copies or substantial portions of the Software.
-** 
+**
 ** THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 ** IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 ** FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
@@ -86,7 +86,7 @@ class QtFunction : public camp::Function
 
 case 1:
 {
-QVariant arg1 = QtHelper::valueToVariant(args[0]);
+const auto arg1 = QtHelper::argumentToVariant(args[0], m_metaMethod.parameterType(0));
 m_metaMethod.invoke(object.get(), Qt::DirectConnection, ret
   , QGenericArgument(arg1.typeName(), arg1.data()));
 break;
@@ -94,8 +94,8 @@ class QtFunction : public camp::Function
 
 case 2:
 {
-QVariant arg1 = QtHelper::valueToVariant(args[0]);
-QVariant arg2 = QtHelper::valueToVariant(args[1]);
+const auto arg1 = QtHelper::argumentToVariant(args[0], m_metaMethod.parameterType(0));
+const auto arg2 = QtHelper::argumentToVariant(args[1], m_metaMethod.parameterType(1));
 m_metaMethod.invoke(object.get(), Qt::DirectConnection, ret
   , QGenericArgument(arg1.typeName(), arg1.data())
   , QGenericArgument(arg2.typeName(), arg2.data()));
@@ -104,9 +104,9 @@ class QtFunction : public camp::Function
 
 case 3:
 {
-QVariant arg1 = QtHelper::valueToVariant(args[0]);
-QVariant arg2 = QtHelper::valueToVariant(args[1]);
-QVariant arg3 = QtHelper::valueToVariant(args[2]);
+const auto arg1 = QtHelper::argumentToVariant(args[0], m_metaMethod.parameterType(0));
+const auto arg2 = QtHelper::argumentToVariant(args[1], m_metaMethod.parameterType(1));
+const auto arg3 = QtHelper::argumentToVariant(args[2], m_metaMethod.parameterType(2));
 m_metaMethod.invoke(object.get(), Qt::DirectConnection, ret
   , QGenericArgument(arg1.typeName(), arg1.data())
 

Bug#876147: [Debian-med-packaging] Bug#876147: Bug#876147: camp frequently FTBFS on 64bit big endian: camptest-qt (Failed)

[John Paul Adrian Glaubitz]

On 04/16/2018 11:16 AM, John Paul Adrian Glaubitz wrote:

Meanwhile I commited a fix upstream
(https://github.com/fw4spl-org/camp/pull/2) so I would just want to try
it before proposing the fix in the package.

I'll test that for you on s390x.


That patch doesn't apply to the Debian version of camp:

glaubitz@zelenka:~/camp/camp-0.8.1$ patch -p1 < ~/fix-s390x.patch
patching file .gitignore
patching file include/camp/qt/qtfunction.hpp
patching file include/camp/qt/qthelper.hpp
patching file include/camp/valuemapper.hpp
Hunk #2 FAILED at 40.
Hunk #3 succeeded at 96 (offset 2 lines).
Hunk #4 succeeded at 126 (offset 2 lines).
Hunk #5 succeeded at 139 (offset 2 lines).
Hunk #6 succeeded at 156 (offset 2 lines).
Hunk #7 succeeded at 183 (offset 2 lines).
Hunk #8 succeeded at 205 (offset 2 lines).
Hunk #9 succeeded at 234 (offset 2 lines).
Hunk #10 succeeded at 250 (offset 2 lines).
Hunk #11 succeeded at 279 (offset 2 lines).
Hunk #12 succeeded at 326 (offset 2 lines).
Hunk #13 succeeded at 345 (offset 2 lines).
1 out of 13 hunks FAILED -- saving rejects to file 
include/camp/valuemapper.hpp.rej
patching file test/arrayproperty.hpp
Hunk #2 FAILED at 32.
Hunk #3 succeeded at 78 (offset 2 lines).
1 out of 3 hunks FAILED -- saving rejects to file test/arrayproperty.hpp.rej
patching file test/qt/propertymapping.cpp
Hunk #2 succeeded at 34 with fuzz 2 (offset 2 lines).
Hunk #3 succeeded at 47 (offset 2 lines).
Hunk #4 succeeded at 95 (offset 2 lines).
Hunk #5 succeeded at 106 (offset 2 lines).
glaubitz@zelenka:~/camp/camp-0.8.1$

--
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaub...@debian.org
`. `'   Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

Bug#876147: [Debian-med-packaging] Bug#876147: Bug#876147: camp frequently FTBFS on 64bit big endian: camptest-qt (Failed)

[John Paul Adrian Glaubitz]

Hello!

On 04/16/2018 09:15 AM, Flavien Bridault wrote:

I sent you a private email twice last week but I did not receive any
answer from you so I am afraid they did not reach you. Or maybe you were
just away or not available, if that's the case sorry for spaming you...


I forgot to follow up on that, sorry. I have been very busy. But from
the logs it's also apparent that the package builds fine - including the
tests - on sparc64, so I'm not sure the sparc64 porterbox would be of
any help.

You should preferably get access to an s390x porterbox but I don't have
any that I can provide access to. You would have to contact the correct
people at Debian for that.

See: https://dsa.debian.org/doc/guest-account/


Meanwhile I commited a fix upstream
(https://github.com/fw4spl-org/camp/pull/2) so I would just want to try
it before proposing the fix in the package.

I'll test that for you on s390x.

Adrian

--
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaub...@debian.org
`. `'   Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

Bug#876147: [Debian-med-packaging] Bug#876147: Bug#876147: camp frequently FTBFS on 64bit big endian: camptest-qt (Failed)

[Flavien Bridault]

Hi Adrian,

I sent you a private email twice last week but I did not receive any
answer from you so I am afraid they did not reach you. Or maybe you were
just away or not available, if that's the case sorry for spaming you...

Meanwhile I commited a fix upstream
(https://github.com/fw4spl-org/camp/pull/2) so I would just want to try
it before proposing the fix in the package.

Cheers


Le 06/04/2018 à 14:36, John Paul Adrian Glaubitz a écrit :
> On 04/06/2018 02:34 PM, Flavien Bridault wrote:
>> Okay thanks a lot for your quick answer !
>>
>> Maybe I misunderstood the excuses
>> https://qa.debian.org/excuses.php?package=camp, but the build failure on
>> s390x looks very similar at the endianess issue we have on sparc64, so
>> this should also solves that. If not I will contact s390x folks.
> We can give a try non-theless.
>
> Please send me a private email with your desired username. Encrypt the
> mail using my GPG below (you can find in the Debian GPG keyring).
>
> Use your key that was signed by the Debian Developer you mentioned.
>
> Adrian
>

-- 
*Flavien BRIDAULT*
Ingénieur de Recherche

fbrida...@ircad.fr

*IRCAD France*
1, place de l'Hôpital - 67091 Strasbourg Cedex - FRANCE

http://www.ircad.fr/ 




signature.asc
Description: OpenPGP digital signature

Bug#876147: [Debian-med-packaging] Bug#876147: Bug#876147: camp frequently FTBFS on 64bit big endian: camptest-qt (Failed)

[John Paul Adrian Glaubitz]

On 04/06/2018 02:34 PM, Flavien Bridault wrote:

Okay thanks a lot for your quick answer !

Maybe I misunderstood the excuses
https://qa.debian.org/excuses.php?package=camp, but the build failure on
s390x looks very similar at the endianess issue we have on sparc64, so
this should also solves that. If not I will contact s390x folks.

We can give a try non-theless.

Please send me a private email with your desired username. Encrypt the
mail using my GPG below (you can find in the Debian GPG keyring).

Use your key that was signed by the Debian Developer you mentioned.

Adrian

--
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaub...@debian.org
`. `'   Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

Bug#876147: [Debian-med-packaging] Bug#876147: Bug#876147: camp frequently FTBFS on 64bit big endian: camptest-qt (Failed)

[Flavien Bridault]

Okay thanks a lot for your quick answer !

Maybe I misunderstood the excuses
https://qa.debian.org/excuses.php?package=camp, but the build failure on
s390x looks very similar at the endianess issue we have on sparc64, so
this should also solves that. If not I will contact s390x folks.


Le 06/04/2018 à 14:28, John Paul Adrian Glaubitz a écrit :
> Hi Flavien!
>
> On 04/06/2018 02:24 PM, Flavien Bridault wrote:
>> I already posted the information but it seems no one got it.
>>
>> My GPG key has been signed by a Debian Developer, would it be
>> possible to
>> gain access to the sparc64 porterbox now ?
> Yes, we can create an account for you on the sparc64 porterbox.
>
>> camp has been removed from testing because of this bug and this
>> prevents fw4spl
>> from being updated, I would like to fix this asap.
>
> A package failing to build from source on sparc64 does not have
> any influence on testing migration. In fact, the package builds
> fine on sparc64 at the moment so I'm not sure a sparc64 porterbox
> would help you.
>
> We can still give you access to the sparc64 porterbox if the problem
> is big-endian-specific, but I guess access to an s390x machine would be
> better. Although for that you would have to contact the s390x folk.
>
> Adrian
>

-- 
*Flavien BRIDAULT*
Ingénieur de Recherche

fbrida...@ircad.fr

*IRCAD France*
1, place de l'Hôpital - 67091 Strasbourg Cedex - FRANCE

http://www.ircad.fr/ 

Bug#876147: [Debian-med-packaging] Bug#876147: camp frequently FTBFS on 64bit big endian: camptest-qt (Failed)

[John Paul Adrian Glaubitz]

Hi Flavien!

On 04/06/2018 02:24 PM, Flavien Bridault wrote:

I already posted the information but it seems no one got it.

My GPG key has been signed by a Debian Developer, would it be possible to
gain access to the sparc64 porterbox now ?

Yes, we can create an account for you on the sparc64 porterbox.


camp has been removed from testing because of this bug and this prevents fw4spl
from being updated, I would like to fix this asap.


A package failing to build from source on sparc64 does not have
any influence on testing migration. In fact, the package builds
fine on sparc64 at the moment so I'm not sure a sparc64 porterbox
would help you.

We can still give you access to the sparc64 porterbox if the problem
is big-endian-specific, but I guess access to an s390x machine would be
better. Although for that you would have to contact the s390x folk.

Adrian

--
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaub...@debian.org
`. `'   Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

Bug#876147: [Debian-med-packaging] Bug#876147: camp frequently FTBFS on 64bit big endian: camptest-qt (Failed)

[Flavien Bridault]

Hi Adrian,

I already posted the information but it seems no one got it.

My GPG key has been signed by a Debian Developer, would it be possible
to gain access to the sparc64 porterbox now ? camp has been removed from
testing because of this bug and this prevents fw4spl from being updated,
I would like to fix this asap.

Thanks !


Le 09/01/2018 à 09:15, Flavien Bridault a écrit :
> No my GPG key has not been signed by anyone afaik.
>
> Otherwise Andreas proposed me some weeks to apply as a Debian Developer,
> that might be one more good reason to do it ? :)
>
> Le 08/01/2018 à 18:16, John Paul Adrian Glaubitz a écrit :
>> On 01/08/2018 06:13 PM, Flavien Bridault wrote:
>>> Ah I see maybe I should email Ben Collins 
>>  as stated here
>>> https://www.debian.org/ports/sparc/porting.en.html ?
>> No, that information is unfortunately outdated. We need to ask the webteam
>> to update the website. Thanks for the heads-up.
>>
>> Do you happen to have a GPG key which has been signed by any Debian
>> Developer
>> or any developer from another large Linux distribution?
>>
>> Adrian
>>
>
>
> ___
> Debian-med-packaging mailing list
> debian-med-packag...@lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-med-packaging

-- 
*Flavien BRIDAULT*
Ingénieur de Recherche

fbrida...@ircad.fr

*IRCAD France*
1, place de l'Hôpital - 67091 Strasbourg Cedex - FRANCE

http://www.ircad.fr/ 



signature.asc
Description: OpenPGP digital signature

Bug#876147: camp frequently FTBFS on 64bit big endian: camptest-qt (Failed)

[Flavien Bridault]

Hi Andreas,

I finally managed to find a Debian Developer !

He signed my gpg key yesterday so now I think I can request the
permissions to log in the sparc64 portexbox and process that bug.

The gpg key is the one used to sign this email. Please tell me if that's
ok now.

Cheers,


Le 09/01/2018 à 11:37, Andreas Tille a écrit :
> Hi Flavien,
>
> On Tue, Jan 09, 2018 at 09:15:38AM +0100, Flavien Bridault wrote:
>> No my GPG key has not been signed by anyone afaik.
> I guess somewhere close to you you can find a Debian developer to sign
> your key.
>  
>> Otherwise Andreas proposed me some weeks to apply as a Debian Developer,
>> that might be one more good reason to do it ? :)
> The first stage is a Debian Maintainer ... and you need to have a key
> signed by a Debian Developer to get this status. ;-)
>
> Kind regards
>
>  Andreas.
>

-- 
*Flavien BRIDAULT*
Ingénieur de Recherche

fbrida...@ircad.fr

*IRCAD France*
1, place de l'Hôpital - 67091 Strasbourg Cedex - FRANCE

http://www.ircad.fr/ 




signature.asc
Description: OpenPGP digital signature

Bug#876147: camp frequently FTBFS on 64bit big endian: camptest-qt (Failed)

[Andreas Tille]

Hi Flavien,

On Tue, Jan 09, 2018 at 09:15:38AM +0100, Flavien Bridault wrote:
> No my GPG key has not been signed by anyone afaik.

I guess somewhere close to you you can find a Debian developer to sign
your key.
 
> Otherwise Andreas proposed me some weeks to apply as a Debian Developer,
> that might be one more good reason to do it ? :)

The first stage is a Debian Maintainer ... and you need to have a key
signed by a Debian Developer to get this status. ;-)

Kind regards

 Andreas.

-- 
http://fam-tille.de

Bug#876147: camp frequently FTBFS on 64bit big endian: camptest-qt (Failed)

[Flavien Bridault]

No my GPG key has not been signed by anyone afaik.

Otherwise Andreas proposed me some weeks to apply as a Debian Developer,
that might be one more good reason to do it ? :)

Le 08/01/2018 à 18:16, John Paul Adrian Glaubitz a écrit :
> On 01/08/2018 06:13 PM, Flavien Bridault wrote:
> > Ah I see maybe I should email Ben Collins 
>  as stated here
> > https://www.debian.org/ports/sparc/porting.en.html ?
>
> No, that information is unfortunately outdated. We need to ask the webteam
> to update the website. Thanks for the heads-up.
>
> Do you happen to have a GPG key which has been signed by any Debian
> Developer
> or any developer from another large Linux distribution?
>
> Adrian
>

-- 
*Flavien BRIDAULT*
Ingénieur de Recherche

fbrida...@ircad.fr

*IRCAD France*
1, place de l'Hôpital - 67091 Strasbourg Cedex - FRANCE

http://www.ircad.fr/ 





signature.asc
Description: OpenPGP digital signature

Bug#876147: camp frequently FTBFS on 64bit big endian: camptest-qt (Failed)

[Flavien Bridault]

How can I connect to the box ?

I read on https://db.debian.org/machines.cgi it is public, but the
connection fails if I naively try to login with:

~ % ssh sakharov.debian.net
Permission denied (publickey).

Thanks.

Flavien.


Le 08/12/2017 à 10:16, John Paul Adrian Glaubitz a écrit :
> We have a new sparc64 porterbox called sakharov.debian.net. Feel free to test 
> your code there.
>
> Adrian
>
>> On Dec 8, 2017, at 9:49 AM, Andreas Tille  wrote:
>>
>> Hi Flavien,
>>
>> I have put the porter lists of the affected architectures in CC whether
>> there is somebody who has a hint for a better solution than removing
>> these architectures from the supported architectures.  This kind of
>> "random failure"[1] is quite hard to debug for somebody who is not
>> familiar for the said architectures.
>>
>> Kind regards
>>
>>   Andreas.
>>
>> [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=876147#20
>>
>> -- 
>> http://fam-tille.de

-- 
*Flavien BRIDAULT*
Ingénieur de Recherche

fbrida...@ircad.fr

*IRCAD France*
1, place de l'Hôpital - 67091 Strasbourg Cedex - FRANCE

http://www.ircad.fr/ 




signature.asc
Description: OpenPGP digital signature

Bug#876147: camp frequently FTBFS on 64bit big endian: camptest-qt (Failed)

[Flavien Bridault]

Ah I see maybe I should email Ben Collins 
 as stated here
https://www.debian.org/ports/sparc/porting.en.html ?


Le 08/12/2017 à 10:16, John Paul Adrian Glaubitz a écrit :
> We have a new sparc64 porterbox called sakharov.debian.net. Feel free to test 
> your code there.
>
> Adrian
>
>> On Dec 8, 2017, at 9:49 AM, Andreas Tille  wrote:
>>
>> Hi Flavien,
>>
>> I have put the porter lists of the affected architectures in CC whether
>> there is somebody who has a hint for a better solution than removing
>> these architectures from the supported architectures.  This kind of
>> "random failure"[1] is quite hard to debug for somebody who is not
>> familiar for the said architectures.
>>
>> Kind regards
>>
>>   Andreas.
>>
>> [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=876147#20
>>
>> -- 
>> http://fam-tille.de

-- 
*Flavien BRIDAULT*
Ingénieur de Recherche

fbrida...@ircad.fr

*IRCAD France*
1, place de l'Hôpital - 67091 Strasbourg Cedex - FRANCE

http://www.ircad.fr/ 



signature.asc
Description: OpenPGP digital signature

Bug#876147: camp frequently FTBFS on 64bit big endian: camptest-qt (Failed)

[John Paul Adrian Glaubitz]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 01/08/2018 06:13 PM, Flavien Bridault wrote:
> Ah I see maybe I should email Ben Collins  
>  as stated here 
> https://www.debian.org/ports/sparc/porting.en.html ?

No, that information is unfortunately outdated. We need to ask the webteam
to update the website. Thanks for the heads-up.

Do you happen to have a GPG key which has been signed by any Debian Developer
or any developer from another large Linux distribution?

Adrian

- -- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaub...@debian.org
`. `'   Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913
-BEGIN PGP SIGNATURE-

iQIzBAEBCAAdFiEEYv+KdYTgKVaVRgAGdCY7N/W1+RMFAlpTp3cACgkQdCY7N/W1
+ROXhg/+K0rcF8XWoDdb+0AF2vYT4VTEOKQdA15aLW4TSQ3XGfwdqXE6maNwAXM7
SuqB4NzJxxTHiTXJ8QXXQ1u29yKdCqb6g/vgEwduoLC3FAfupQ+A11WkMNidrqhu
MTME4+rq24yLaNdIiE2fS+C3goTaS7raIgFY68nnL5j2x2Ptjs0BNGnJ2QPEflK9
IDMDNPPG9L2OPwQB52XtyWJODZuFANg6kKRE4OwgPMTL8aYRpQEKnLLQ2pxt4sdb
IhWivHhDGBTlkwMWpVuTseyMSEyGLBRZrXaXi5Y/5wirg72N8CzzXU8hiwphf3cm
L1dUWx45XuK9ZfmLFJ/yUzg48XPheH4AgnLto0Rvq6mIPoKCmLcrZAMVhxIPWEHw
/US9H8nu4iipmJAGaPAcwqfPCYLNhngljlPmVPvHY4pgK3Z9XiGtCvwSg7/bBfTD
vs6Ok31/+7UlCWEuXVBhS7HV/+5abpDJeMXBFZ84PgzfxcQwayNvpCdTFgZmell0
/GQ8IMUnDFpANmjZ2qtDlUuchwRdTAIxqIkie6v7JmBk3tp3CQMC0AOU29u3Psrh
8ls+bevKJeOAtaJG2fJxWnVH+h9QbM8ug8lcb3+26U2v5QShK6Nyt2yozSzU6wlc
CBMnH+8NXtQ95zU2lCZ8Qm7lgG8prKztdyJKGdx9m26Kt5tbGg4=
=1hIL
-END PGP SIGNATURE-

Bug#876147: camp frequently FTBFS on 64bit big endian: camptest-qt (Failed)

[James Clarke]

On Fri, Dec 08, 2017 at 09:49:05AM +0100, Andreas Tille wrote:
> Hi Flavien,
>
> I have put the porter lists of the affected architectures in CC whether
> there is somebody who has a hint for a better solution than removing
> these architectures from the supported architectures.  This kind of
> "random failure"[1] is quite hard to debug for somebody who is not
> familiar for the said architectures.

f4 is (long, long, long) -> long, and so the generated Qt metacall magic
wrapper around f4 treats its arguments as an array of long*,
dereferences them, passes them to f4 and stores the return value for the
caller.

However, camp's own Value class only has camp::intType; it has no type
for long or long long. This means that valueToVariant always gives a
QVariant storing an int, so QtFunction::execute invokes the meta method
with QGenericArgument's pointing to ints. Therefore, when the metacall
wrapper reads them, it reads too much, and gets 32 bits of garbage after
them in memory. Normally in C arguments are promoted automatically, but
because of all these levels of indirection it has to be done manually
(as you can see for example with the double tests, which must use the
double literal 1. rather than the int literal 1).

Now, as to why it only affects 64-bit big-endian. Obviously, 32-bit is
unaffected, as sizeof(int) == sizeof(long) there. On 64-bit
little-endian, reading too much data puts the garbage in the *higher*
bits in the registers; if you then add values with garbage in the higher
half, the lower half will remain correct, and it gets stored as a 64-bit
value. Then eventually it gets read as an int (variantType sees that the
function returns a QMetaType::Long, which is mapped to a return
QVariant::Int), so the higher 32 bits get dropped, and all appears fine
(despite the horrendous out-of-bounds memory accesses).

On 64-bit big-endian systems, though, it's not quite so forgiving. When
it reads the 32-bit value as a 64-bit value, the endianness means that
the 32 bits of garbage are the *lower* 32 bits in the registers, and so
when adding three numbers together, the sum of these garbage halves
could overflow (up to twice) into the higher 32 bits, which store the
desired values, causing the upper half to non-deterministically be 20,
21 or 22. This gets stored as a 64-bit quantity again, and then later
re-read as a 32-bit quantity, and again due to the endianness it only
reads what was the higher half in the register, i.e. either 20, 21 or
22.

I don't have a patch, because fixing this requires a fairly involved
trawl through the source. I haven't tried using it, but valgrind might
catch these out-of-bounds reads regardless of the system's endianness.

TL;DR camp needs to stop treating longs like ints.

Regards,
James

Bug#876147: camp frequently FTBFS on 64bit big endian: camptest-qt (Failed)

[John Paul Adrian Glaubitz]

We have a new sparc64 porterbox called sakharov.debian.net. Feel free to test 
your code there.

Adrian

> On Dec 8, 2017, at 9:49 AM, Andreas Tille  wrote:
> 
> Hi Flavien,
> 
> I have put the porter lists of the affected architectures in CC whether
> there is somebody who has a hint for a better solution than removing
> these architectures from the supported architectures.  This kind of
> "random failure"[1] is quite hard to debug for somebody who is not
> familiar for the said architectures.
> 
> Kind regards
> 
>   Andreas.
> 
> [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=876147#20
> 
> -- 
> http://fam-tille.de

Bug#876147: camp frequently FTBFS on 64bit big endian: camptest-qt (Failed)

[Andreas Tille]

Hi Flavien,

I have put the porter lists of the affected architectures in CC whether
there is somebody who has a hint for a better solution than removing
these architectures from the supported architectures.  This kind of
"random failure"[1] is quite hard to debug for somebody who is not
familiar for the said architectures.

Kind regards

   Andreas.

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=876147#20

-- 
http://fam-tille.de