Bug#877670: [Debian-med-packaging] Bug#877670: Bug#877670: bcftools FTBFS on armel armhf and ppc64el

2017-11-07 Thread Graham Inggs
Control: reassign -1 htslib 1.4-1
Control: tags -1 + patch
Control: affects -1 bcftools

It seems this code appeared in htslib 1.4, but was only tested in bcftools 1.5.
Description: Fix calculation of PLs on ARM and POWER
Bug: https://github.com/samtools/bcftools/issues/702
Bug-Debian: https://bugs.debian.org/877670
Forwarded: https://github.com/samtools/htslib/pull/617
Author: Graham Inggs 
Last-Update: 2017-11-08
--- a/errmod.c
+++ b/errmod.c
@@ -82,10 +82,11 @@
 double le1 = log(1.0 - e);
 for (n = 1; n <= 255; ++n) {
 double *beta = em->beta + (q<<16|n<<8);
-sum1 = sum = 0.0;
-for (k = n; k >= 0; --k, sum1 = sum) {
-sum = sum1 + expl(lC[n<<8|k] + k*le + (n-k)*le1);
-beta[k] = -10. / M_LN10 * logl(sum1 / sum);
+sum1 = lC[n<<8|n] + n*le;
+beta[n] = INFINITY;
+for (k = n - 1; k >= 0; --k, sum1 = sum) {
+sum = sum1 + log1pl(expl(lC[n<<8|k] + k*le + (n-k)*le1 - sum1));
+beta[k] = -10. / M_LN10 * (sum1 - sum);
 }
 }
 }


Bug#877670: [Debian-med-packaging] Bug#877670: Bug#877670: bcftools FTBFS on armel armhf and ppc64el

2017-10-28 Thread Graham Inggs
FWIW, I tried building htslib 1.6 and bcftools 1.6, but the issue is
still present.
I also tried building htslib 1.5 and becftools 1.5 with -fsigned-char
but that didn't help either.

Looking closer at test/test.pl, I noticed the failing test is new, so
this is not a regression.  Simply dropping the line below was enough
to get the build to succeed on armhf:
test_mpileup($opts,in=>[qw(indel-AD.1)],out=>'mpileup/indel-AD.1.out',ref=>'indel-AD.1.fa',args=>q[-a
AD]);

I'm inclined to upload with a patch skipping this still, unless there
are objections.