Bug#885797: [Pkg-matrix-maintainers] Bug#885797: revolt: please build-depend on libglib2.0-dev-bin

[Boris Pek]

Hi,

>> I don't think we have any
>> uploads for Revolt planned in the near future, so we can just let the
>> NMU go through.
>
> Thanks, I've rescheduled it to 0-day so this bug can go away sooner.
>
> The collab-maint repository declared in the source package doesn't seem
> to exist, so I haven't pushed my changes. Please apply the change to
> whatever VCS you use for the next upload.

Imported using `gbp import-dscs`:
https://salsa.debian.org/matrix-team/revolt/commits/master

Thanks.

-- 
Boris

Bug#885797: revolt: please build-depend on libglib2.0-dev-bin

[Simon McVittie]

On Fri, 29 Dec 2017 at 21:31:51 -0500, Hubert Chathi wrote:
> I don't think we have any
> uploads for Revolt planned in the near future, so we can just let the
> NMU go through.

Thanks, I've rescheduled it to 0-day so this bug can go away sooner.

The collab-maint repository declared in the source package doesn't seem
to exist, so I haven't pushed my changes. Please apply the change to
whatever VCS you use for the next upload.

smcv

Bug#885797: [Pkg-matrix-maintainers] Bug#885797: revolt: please build-depend on libglib2.0-dev-bin

[Hubert Chathi]

On Fri, 29 Dec 2017 23:50:08 +, Simon McVittie  said:

[...]

> This is easily fixed by changing the Build-Depends to pull in either
> libglib2.0-dev-bin, or libglib2.0-dev. I'll do a delayed NMU with the
> obvious change when I get a bug number; or if a maintainer would
> prefer to take care of this, a suitable patch is attached.

Hi Simon,

Thank you for the report and for the NMU.  I don't think we have any
uploads for Revolt planned in the near future, so we can just let the
NMU go through.

-- 
Hubert Chathi  -- https://www.uhoreg.ca/
Jabber: hub...@uhoreg.ca -- Matrix: @uhoreg:matrix.org
PGP/GnuPG key: 4096R/F24C F749 6C73 DDB8 DCB8  72DE B2DE 88D3 113A 1368

Bug#885797: revolt: please build-depend on libglib2.0-dev-bin

[Simon McVittie]

Package: revolt
Version: 0.0+git20170627.3f5112b-2
Severity: serious
Tags: patch
Justification: fails to build from source (but built successfully in the past)

In bug #885019, the GNOME maintainers were asked to move the
glib-compile-resources tool to a more appropriate package to fix
cross-compiling. glib-compile-resources is a development tool and is not
needed by typical non-developer users, so moving it to libglib2.0-dev-bin
seemed most appropriate.

For the majority of packages that use glib-compile-resources, this had no
practical effect, because libglib2.0-dev depends on both. However,
revolt is unusual in that it uses glib-compile-resources without
depending on libglib2.0-dev (because it isn't native code). Depending
on libglib2.0-bin was previously enough to get glib-compile-resources,
but now isn't enough, making revolt FTBFS.

This is easily fixed by changing the Build-Depends to pull in either
libglib2.0-dev-bin, or libglib2.0-dev. I'll do a delayed NMU with the
obvious change when I get a bug number; or if a maintainer would prefer
to take care of this, a suitable patch is attached.

Thanks,
smcv
>From 3e10087807b360cc3d6d2ae208f92c3b9f28e9e6 Mon Sep 17 00:00:00 2001
From: Simon McVittie 
Date: Fri, 29 Dec 2017 23:32:27 +
Subject: [PATCH] Build-depend on libglib2.0-dev-bin as well as libglib2.0-bin

glib-compile-resources moved from -bin to -dev-bin in version
2.54.2-5 to fix #885019 (Closes: #nn)
---
 debian/changelog | 9 +
 debian/control   | 2 +-
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/debian/changelog b/debian/changelog
index c277bb9..5673bc0 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,12 @@
+revolt (0.0+git20170627.3f5112b-2.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Build-depend on libglib2.0-dev-bin as well as libglib2.0-bin.
+glib-compile-resources moved from -bin to -dev-bin in version
+2.54.2-5 to fix #885019 (Closes: #nn)
+
+ -- Simon McVittie   Fri, 29 Dec 2017 23:30:30 +
+
 revolt (0.0+git20170627.3f5112b-2) unstable; urgency=medium
 
   * Depend on gir1.2-webkit2-4.0 instead of directly on libwebkit2gtk-4.0.
diff --git a/debian/control b/debian/control
index 9834670..8c5b0c8 100644
--- a/debian/control
+++ b/debian/control
@@ -3,7 +3,7 @@ Section: net
 Priority: optional
 Maintainer: Matrix Packaging Team 
 Uploaders: Hubert Chathi 
-Build-Depends: debhelper (>=9), libglib2.0-bin, python3:any | python3-all:any | python3-dev:any | python3-all-dev:any, python3-gi
+Build-Depends: debhelper (>=9), libglib2.0-bin, libglib2.0-dev-bin, python3:any | python3-all:any | python3-dev:any | python3-all-dev:any, python3-gi
 Standards-Version: 3.9.8
 Homepage: https://github.com/aperezdc/revolt
 Vcs-Git: git://anonscm.debian.org/collab-maint/revolt.git
-- 
2.15.1