Bug#886670: libcgal-dev: CGAL_CXX_FLAGS_INIT contains flags that shouldn't be there
severity 886670 normal unblock 883986 by 886670 tag 886670 upstream forwarded 886670 https://github.com/CGAL/cgal/issues/2734 thanks On 08.01.2018 20:35, Adrian Bunk wrote: > While looking into fixing #883986 I ran into the following problem > due to openscad using CGAL_CXX_FLAGS_INIT: > > /usr/lib/x86_64-linux-gnu/cmake/CGAL/CGALConfig.cmake: > set(CGAL_CXX_FLAGS_INIT "-g -O2 > -fdebug-prefix-map=/build/cgal-d6DBFP/cgal-4.11=. -fstack-protector-strong > -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 > -frounding-math" ) > > The only flag that might be correct in this place is -frounding-math, > in case that is required for using CGAL. > > Exposing flags like -fdebug-prefix-map is simply wrong. > > (For #883986 the problem is the -g, that is also wrong here.) I agree and I have forwarded this as https://github.com/CGAL/cgal/issues/2734 > The severity might seem inflated, but this should be fixed > for fixing the RC #883986 FTBFS in openscad. However, I disagree about the severity. Since there is a simple workaround I've reset the severity to normal and removed the block relation. Joachim
Processed: Re: Bug#886670: libcgal-dev: CGAL_CXX_FLAGS_INIT contains flags that shouldn't be there
Processing commands for cont...@bugs.debian.org: > severity 886670 normal Bug #886670 [libcgal-dev] libcgal-dev: CGAL_CXX_FLAGS_INIT contains flags that shouldn't be there Severity set to 'normal' from 'serious' > unblock 883986 by 886670 Bug #883986 [src:openscad] openscad: FTBFS on mips/mipsel: virtual memory exhausted: Cannot allocate memory 883986 was blocked by: 886670 883986 was not blocking any bugs. Removed blocking bug(s) of 883986: 886670 > tag 886670 upstream Bug #886670 [libcgal-dev] libcgal-dev: CGAL_CXX_FLAGS_INIT contains flags that shouldn't be there Added tag(s) upstream. > forwarded 886670 https://github.com/CGAL/cgal/issues/2734 Bug #886670 [libcgal-dev] libcgal-dev: CGAL_CXX_FLAGS_INIT contains flags that shouldn't be there Set Bug forwarded-to-address to 'https://github.com/CGAL/cgal/issues/2734'. > thanks Stopping processing here. Please contact me if you need assistance. -- 883986: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=883986 886670: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=886670 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#886670: libcgal-dev: CGAL_CXX_FLAGS_INIT contains flags that shouldn't be there
Package: libcgal-dev Version: 4.11-2 Severity: serious Control: block 883986 by -1 While looking into fixing #883986 I ran into the following problem due to openscad using CGAL_CXX_FLAGS_INIT: /usr/lib/x86_64-linux-gnu/cmake/CGAL/CGALConfig.cmake: set(CGAL_CXX_FLAGS_INIT "-g -O2 -fdebug-prefix-map=/build/cgal-d6DBFP/cgal-4.11=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -frounding-math" ) The only flag that might be correct in this place is -frounding-math, in case that is required for using CGAL. Exposing flags like -fdebug-prefix-map is simply wrong. (For #883986 the problem is the -g, that is also wrong here.) The severity might seem inflated, but this should be fixed for fixing the RC #883986 FTBFS in openscad.
