Bug#887690: unattended-upgrades: FTBFS and Debci failure after testpackage was removed from Ubuntu server

2018-02-07 Thread Bálint Réczey
Hi Simon,

2018-02-07 23:25 GMT+07:00 Simon McVittie :
> Control: tags -1 + patch fixed-upstream
>
> On Fri, 19 Jan 2018 at 06:36:43 +0200, Adrian Bunk wrote:
>> The URI 'http://archive.ubuntu.com/ubuntu/test-package_2.0_all.deb' failed 
>> to download, aborting
>> The URI 'http://archive.ubuntu.com/ubuntu/test-package_2.0_all.deb' failed 
>> to download, aborting
>
> I think this is caused by a behaviour change in apt (see #886803).
> unattended-upgrades' test suite doesn't intend to *actually* download
> a test package from Ubuntu, it just pretends to do so by pre-populating
> an apt cache; but the filenames used in the apt cache (when the Version
> is not consistent with the Filename) have changed, so the pre-prepared
> file in the cache isn't used and the test fails.
>
> The attached patch (from the unattended-upgrades git repository) seems
> to resolve this for me. It just makes the Filename and the Version
> consistent with each other so that the problem situation doesn't arise.
>
> unattended-upgrades maintainers: is there an ETA for a 0.99 or 0.98.1
> release with this patch, or does someone need to NMU it? This is
> considered release-critical due to the FTBFS.

I'm trying the fix #875383 and release all the queued fixes this week.

Cheers,
Balint



Bug#887690: unattended-upgrades: FTBFS and Debci failure after testpackage was removed from Ubuntu server

2018-02-07 Thread Simon McVittie
Control: tags -1 + patch fixed-upstream

On Fri, 19 Jan 2018 at 06:36:43 +0200, Adrian Bunk wrote:
> The URI 'http://archive.ubuntu.com/ubuntu/test-package_2.0_all.deb' failed to 
> download, aborting
> The URI 'http://archive.ubuntu.com/ubuntu/test-package_2.0_all.deb' failed to 
> download, aborting

I think this is caused by a behaviour change in apt (see #886803).
unattended-upgrades' test suite doesn't intend to *actually* download
a test package from Ubuntu, it just pretends to do so by pre-populating
an apt cache; but the filenames used in the apt cache (when the Version
is not consistent with the Filename) have changed, so the pre-prepared
file in the cache isn't used and the test fails.

The attached patch (from the unattended-upgrades git repository) seems
to resolve this for me. It just makes the Filename and the Version
consistent with each other so that the problem situation doesn't arise.

unattended-upgrades maintainers: is there an ETA for a 0.99 or 0.98.1
release with this patch, or does someone need to NMU it? This is
considered release-critical due to the FTBFS.

Thanks,
smcv
>From 7cc70e402454a83c3e0b569833278d3956e79624 Mon Sep 17 00:00:00 2001
From: Balint Reczey 
Date: Wed, 10 Jan 2018 04:07:48 +0100
Subject: [PATCH] Fix version of test package in
 test_remove_unused_dependencies

Closes: #886803
---
 ...ve.ubuntu.com_ubuntu_dists_lucid-security_main_binary-amd64_Packages | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/root.unused-deps/var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_lucid-security_main_binary-amd64_Packages b/test/root.unused-deps/var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_lucid-security_main_binary-amd64_Packages
index e4b6475..b30ad6c 100644
--- a/test/root.unused-deps/var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_lucid-security_main_binary-amd64_Packages
+++ b/test/root.unused-deps/var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_lucid-security_main_binary-amd64_Packages
@@ -1,6 +1,6 @@
 Package: test-package
 Architecture: all
-Version: 2.0.test.pkg
+Version: 2.0
 Description-en: test package
 Filename: test-package_2.0_all.deb
 SHA256: 01704da7de63ca12109abff5c2c480ad9c757e669c4428424de23ec97bf24248
-- 
2.16.1



Processed: Re: Bug#887690: unattended-upgrades: FTBFS and Debci failure after testpackage was removed from Ubuntu server

2018-02-07 Thread Debian Bug Tracking System
Processing control commands:

> tags -1 + patch fixed-upstream
Bug #887690 [src:unattended-upgrades] unattended-upgrades: FTBFS and Debci 
failure after testpackage was removed from Ubuntu server
Added tag(s) fixed-upstream and patch.

-- 
887690: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=887690
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems



Bug#887690: unattended-upgrades: FTBFS and Debci failure after testpackage was removed from Ubuntu server

2018-01-18 Thread Adrian Bunk
Source: unattended-upgrades
Version: 0.98
Severity: serious

https://ci.debian.net/packages/u/unattended-upgrades/unstable/amd64/
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/unattended-upgrades.html

...
==
ERROR: test_remove_unused_dependencies (__main__.TestRemoveUnused)
--
Traceback (most recent call last):
  File "./test_remove_unused.py", line 100, in test_remove_unused_dependencies
options, rootdir="./root.unused-deps")
  File "/build/1st/unattended-upgrades-0.98/test/unattended_upgrade.py", line 
1462, in main
sys.exit(1)
SystemExit: 1

==
ERROR: test_remove_unused_dependencies_new_unused_only 
(__main__.TestRemoveUnused)
--
Traceback (most recent call last):
  File "./test_remove_unused.py", line 122, in 
test_remove_unused_dependencies_new_unused_only
options, rootdir="./root.unused-deps")
  File "/build/1st/unattended-upgrades-0.98/test/unattended_upgrade.py", line 
1462, in main
sys.exit(1)
SystemExit: 1

--
Ran 2 tests in 0.486s

FAILED (errors=2)
The URI 'http://archive.ubuntu.com/ubuntu/test-package_2.0_all.deb' failed to 
download, aborting
The URI 'http://archive.ubuntu.com/ubuntu/test-package_2.0_all.deb' failed to 
download, aborting
Makefile:6: recipe for target 'check' failed
make[2]: *** [check] Error 1