Bug#899248: closed by Niels Thykier <ni...@thykier.net> (Bug#899248: fixed in debhelper 11.3.1)

2018-05-22 Thread gregor herrmann
On Tue, 22 May 2018 20:14:28 +0200, gregor herrmann wrote:

> Maybe this is unrelated but I just found a situation where debhelper 11.3.1
> doesn't install the upstream changelog anymore.
> 
> + This is libcourriel-perl 0.47 in git at
>   https://salsa.debian.org/perl-team/modules/packages/libcourriel-perl

Same for a couple of other perl packages with either ./Changes or
./ChangeLog.
 
Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   NP: Lenny Kravitz: Let Love Rule


signature.asc
Description: Digital Signature


Bug#899248: closed by Niels Thykier <ni...@thykier.net> (Bug#899248: fixed in debhelper 11.3.1)

2018-05-22 Thread gregor herrmann
On Mon, 21 May 2018 20:39:10 +, Debian Bug Tracking System wrote:

>  debhelper (11.3.1) unstable; urgency=medium
>  .
>* dh_installchangelogs: Fix logic error that made
>  dh_installchangelogs incorrectly ignore explicitly passed
>  changelogs.  Thanks to Sven Joachim and Rene Engelhard
>  for reporting the bug.  (Closes: #899248)

Maybe this is unrelated but I just found a situation where debhelper 11.3.1
doesn't install the upstream changelog anymore.

Background:

+ This is libcourriel-perl 0.47 in git at
  https://salsa.debian.org/perl-team/modules/packages/libcourriel-perl

+ We have an upstream changelog at ./Changes:
  % find -iname "change*"
  ./Changes
  ./debian/changelog

+ Build log:
Preparing to unpack .../035-debhelper_11.3.1_all.deb ...
Unpacking debhelper (11.3.1) ...
...
   dh_installchangelogs
install -p -m0644 debian/changelog 
debian/libcourriel-perl/usr/share/doc/libcourriel-perl/changelog.Debian
install -p -m0644 debian/NEWS 
debian/libcourriel-perl/usr/share/doc/libcourriel-perl/NEWS.Debian

+ And lintian complained rightly so about the missing upstream
  changelog:
% debc | grep -i doc
drwxr-xr-x root/root 0 2018-05-22 06:39 ./usr/share/doc/
drwxr-xr-x root/root 0 2018-05-22 06:39 
./usr/share/doc/libcourriel-perl/
-rw-r--r-- root/root  1780 2018-05-20 18:34 
./usr/share/doc/libcourriel-perl/CONTRIBUTING.md.gz
-rw-r--r-- root/root  1028 2018-05-22 06:39 
./usr/share/doc/libcourriel-perl/NEWS.Debian.gz
-rw-r--r-- root/root  2443 2018-05-22 06:39 
./usr/share/doc/libcourriel-perl/changelog.Debian.gz
-rw-r--r-- root/root 10279 2018-05-22 06:39 
./usr/share/doc/libcourriel-perl/copyright
drwxr-xr-x root/root 0 2018-05-22 06:39 
./usr/share/doc/libcourriel-perl/examples/
-rw-r--r-- root/root  2760 2018-05-20 18:34 
./usr/share/doc/libcourriel-perl/examples/sendgrid


With debhelper 11.3 I see what I'm used to see:

   dh_installchangelogs
install -p -m0644 debian/changelog 
debian/libcourriel-perl/usr/share/doc/libcourriel-perl/changelog.Debian
install -p -m0644 debian/NEWS 
debian/libcourriel-perl/usr/share/doc/libcourriel-perl/NEWS.Debian
install -p -m0644 ./Changes 
debian/libcourriel-perl/usr/share/doc/libcourriel-perl/changelog



Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   NP: [DKP]: Lied von Breendonck (Belgien)


signature.asc
Description: Digital Signature