Bug#899365: [Pkg-mozext-maintainers] Bug#899365: webext-ublock-origin: webext package does not work in Firefox
Hello, On Sat, Jul 07 2018, Laurent Bigonville wrote: > Well that error is already in unstable, I would personally just upload > now to fix this bug that makes the extension unusable and then look at > these later This is fair enough, but since the package is looking for a new maintainer, I would still rather not. Please feel free to do a team upload or NMU. -- Sean Whitton signature.asc Description: PGP signature
Bug#899365: [Pkg-mozext-maintainers] Bug#899365: webext-ublock-origin: webext package does not work in Firefox
On Fri, 06 Jul 2018 21:17:49 +0100 Sean Whitton wrote: > Hello, > > On Fri, Jul 06 2018, Eugen Dedu wrote: > > > I confirm that the commit on salsa above makes ublock origin working > > with my firefox. > > Thank you both for taking the time to test! > > I can't upload the fix because it looks like there are missing source > problems: > > E: ublock-origin source: source-is-missing src/js/hntrie.js line length is 1357 characters (>512) > E: ublock-origin source: source-is-missing src/lib/codemirror/lib/codemirror.js line length is 1953 characters (>512) Well that error is already in unstable, I would personally just upload now to fix this bug that makes the extension unusable and then look at these later > > I think the latter is a false positive, but unfortunately I do not have > time to dig into this. > > -- > Sean Whitton
Bug#899365: [Pkg-mozext-maintainers] Bug#899365: webext-ublock-origin: webext package does not work in Firefox
Hello, On Fri, Jul 06 2018, Eugen Dedu wrote: > I confirm that the commit on salsa above makes ublock origin working > with my firefox. Thank you both for taking the time to test! I can't upload the fix because it looks like there are missing source problems: E: ublock-origin source: source-is-missing src/js/hntrie.js line length is 1357 characters (>512) E: ublock-origin source: source-is-missing src/lib/codemirror/lib/codemirror.js line length is 1953 characters (>512) I think the latter is a false positive, but unfortunately I do not have time to dig into this. -- Sean Whitton signature.asc Description: PGP signature
Bug#899365: [Pkg-mozext-maintainers] Bug#899365: webext-ublock-origin: webext package does not work in Firefox
On 07/06/2018 04:19 PM, Sean Whitton wrote: >> would you mind the fix? (i ment 'woudl you mind uploading the fix', sorry for the typo) > That is a fix for a different bug. I didn't upload it because this bug > is still present, making the package useless. Or is this bug no longer > reproducible? the mentioned commit makes the package work again with firefox, fixing #899365. Regards, Daniel
Bug#899365: [Pkg-mozext-maintainers] Bug#899365: webext-ublock-origin: webext package does not work in Firefox
On 06/07/18 16:19, Sean Whitton wrote: Hello Daniel, On Fri, Jul 06 2018, Daniel Baumann wrote: I've looked at the git repository on salsa, and your last commit: https://salsa.debian.org/daniel-guest/ublock-origin/commit/0b9e4452552ce6243ae088a7880ef4d67c82d5f8 fixes this for sid (provided one has fonts-font-awesome 4.x which got recently re-uploaded; it works flawlessly but doesn't display icons in the popup when using fonts-font-awesome 5.x). would you mind the fix? That is a fix for a different bug. I didn't upload it because this bug is still present, making the package useless. Or is this bug no longer reproducible? I confirm that the commit on salsa above makes ublock origin working with my firefox. -- Eugen
Bug#899365: [Pkg-mozext-maintainers] Bug#899365: webext-ublock-origin: webext package does not work in Firefox
Hello Daniel, On Fri, Jul 06 2018, Daniel Baumann wrote: > I've looked at the git repository on salsa, and your last commit: > > https://salsa.debian.org/daniel-guest/ublock-origin/commit/0b9e4452552ce6243ae088a7880ef4d67c82d5f8 > > fixes this for sid (provided one has fonts-font-awesome 4.x which got > recently re-uploaded; it works flawlessly but doesn't display icons in > the popup when using fonts-font-awesome 5.x). > > would you mind the fix? That is a fix for a different bug. I didn't upload it because this bug is still present, making the package useless. Or is this bug no longer reproducible? -- Sean Whitton
Bug#899365: [Pkg-mozext-maintainers] Bug#899365: webext-ublock-origin: webext package does not work in Firefox
On 06/07/18 14:26, Daniel Baumann wrote: Hi Sean, I've looked at the git repository on salsa, and your last commit: https://salsa.debian.org/daniel-guest/ublock-origin/commit/0b9e4452552ce6243ae088a7880ef4d67c82d5f8 fixes this for sid (provided one has fonts-font-awesome 4.x which got recently re-uploaded; it works flawlessly but doesn't display icons in the popup when using fonts-font-awesome 5.x). would you mind the fix? What a beautiful day! Finally, an Internet without ads again! Thank you for the information! (It did not worked after restarting firefox, no icon in the firefox's toolbar, I had to disable and enable the plugin too.) -- Eugen
Bug#899365: [Pkg-mozext-maintainers] Bug#899365: webext-ublock-origin: webext package does not work in Firefox
Hi Sean, I've looked at the git repository on salsa, and your last commit: https://salsa.debian.org/daniel-guest/ublock-origin/commit/0b9e4452552ce6243ae088a7880ef4d67c82d5f8 fixes this for sid (provided one has fonts-font-awesome 4.x which got recently re-uploaded; it works flawlessly but doesn't display icons in the popup when using fonts-font-awesome 5.x). would you mind the fix? Regards, Daniel
Bug#899365: [Pkg-mozext-maintainers] Bug#899365: webext-ublock-origin: webext package does not work in Firefox
Hello, On Fri, Jul 06 2018, Daniel Baumann wrote: > any progress/eta on this? unfortunatly, ublock-origin still doesn't > work with firefox, unless installing the upstream extension from > addons.mozilla.org. I'm afraid not. The package is looking for a new maintainer: https://bugs.debian.org/877041 -- Sean Whitton signature.asc Description: PGP signature
