Bug#902268: debhelper: skips multilib packages when building ncurses
On 2018-06-24 08:22 +, Niels Thykier wrote: > Niels Thykier: >> Sven Joachim: >>> Package: debhelper >>> Version: 11.3.3 >>> Severity: serious >>> >> >> Hi Sven, >> >> Are you certain it is introduced in 11.3.3? The messages / control >> check you highlight is much older than 11.3.3. >> >>>[...] > > Nvm, I reproduced it and I believe the attached patch fixes it. Yes, that works. :-) Cheers, Sven
Bug#902268: debhelper: skips multilib packages when building ncurses
Niels Thykier:
> Sven Joachim:
>> Package: debhelper
>> Version: 11.3.3
>> Severity: serious
>>
>
> Hi Sven,
>
> Are you certain it is introduced in 11.3.3? The messages / control
> check you highlight is much older than 11.3.3.
>
>>[...]
Nvm, I reproduced it and I believe the attached patch fixes it.
Thanks,
~Niels
>From 6b8c47d9507381a9813f18aeb9a3ce7b6c07f05f Mon Sep 17 00:00:00 2001
From: Niels Thykier
Date: Sun, 24 Jun 2018 08:20:31 +
Subject: [PATCH] Dh_Lib: Correct assignment of $build_profiles
Signed-off-by: Niels Thykier
---
debian/changelog | 8
lib/Debian/Debhelper/Dh_Lib.pm | 2 +-
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/debian/changelog b/debian/changelog
index 3aed2fc1..0671f395 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+debhelper (11.3.4) UNRELEASED; urgency=medium
+
+ * Dh_Lib.pm: Fix bug that made the parser assign the wrong
+value from the Build-Profiles field. Thanks to Sven Joachim
+for reporting the bug. (Closes: #902268)
+
+ -- Niels Thykier Sun, 24 Jun 2018 08:19:16 +
+
debhelper (11.3.3) unstable; urgency=medium
[ Niels Thykier ]
diff --git a/lib/Debian/Debhelper/Dh_Lib.pm b/lib/Debian/Debhelper/Dh_Lib.pm
index 1bc6c10b..7d4b0115 100644
--- a/lib/Debian/Debhelper/Dh_Lib.pm
+++ b/lib/Debian/Debhelper/Dh_Lib.pm
@@ -1718,7 +1718,7 @@ sub getpackages {
# because if we work on a package with a Build-Profiles
# field, then a high enough version of dpkg-dev is needed
# anyways
-my $build_profiles=$1;
+my $build_profiles = $value;
eval {
require Dpkg::BuildProfiles;
my @restrictions=Dpkg::BuildProfiles::parse_build_profiles($build_profiles);
--
2.18.0
Bug#902268: debhelper: skips multilib packages when building ncurses
Sven Joachim: > Package: debhelper > Version: 11.3.3 > Severity: serious > Hi Sven, Are you certain it is introduced in 11.3.3? The messages / control check you highlight is much older than 11.3.3. > Doing a test build of ncurses, I noticed that the dh_* tools skipped the > multilib packages, resulting in an incomplete build. This is > reproducible on both i386 and amd64. > > , > | $ grep -B1 "All requested packages have been excluded" > ncurses_6.1+20180210-4_amd64.build > | dh_installdocs -plib32tinfo6 > | dh_installdocs: All requested packages have been excluded (e.g. via a > Build-Profile or due to architecture restrictions). > | -- > |--link-doc=lib32tinfo6 > | dh_installdocs: All requested packages have been excluded (e.g. via a > Build-Profile or due to architecture restrictions). > | -- > | dh_makeshlibs -plib32tinfo6 -V "lib32tinfo6 (>= 6.1)" -- -c4 > | dh_makeshlibs: All requested packages have been excluded (e.g. via a > Build-Profile or due to architecture restrictions). > | dh_makeshlibs -plib32ncurses6 -V "lib32ncurses6 (>= 6.1)" -- -c4 > | dh_makeshlibs: All requested packages have been excluded (e.g. via a > Build-Profile or due to architecture restrictions). > | dh_makeshlibs -plib32ncursesw6 -V "lib32ncursesw6 (>= 6.1)" -- -c4 > | dh_makeshlibs: All requested packages have been excluded (e.g. via a > Build-Profile or due to architecture restrictions). > ` > > , > | $ grep "in control file but not in files list" > ncurses_6.1+20180210-4_amd64.build > | dpkg-genchanges: warning: package lib32tinfo6 in control file but not in > files list > | dpkg-genchanges: warning: package lib32ncurses6 in control file but not in > files list > | dpkg-genchanges: warning: package lib32ncursesw6 in control file but not in > files list > | dpkg-genchanges: warning: package lib32ncurses-dev in control file but not > in files list > ` > > > [...] Thanks, ~Niels
Bug#902268: debhelper: skips multilib packages when building ncurses
Package: debhelper Version: 11.3.3 Severity: serious Doing a test build of ncurses, I noticed that the dh_* tools skipped the multilib packages, resulting in an incomplete build. This is reproducible on both i386 and amd64. , | $ grep -B1 "All requested packages have been excluded" ncurses_6.1+20180210-4_amd64.build | dh_installdocs -plib32tinfo6 | dh_installdocs: All requested packages have been excluded (e.g. via a Build-Profile or due to architecture restrictions). | -- |--link-doc=lib32tinfo6 | dh_installdocs: All requested packages have been excluded (e.g. via a Build-Profile or due to architecture restrictions). | -- | dh_makeshlibs -plib32tinfo6 -V "lib32tinfo6 (>= 6.1)" -- -c4 | dh_makeshlibs: All requested packages have been excluded (e.g. via a Build-Profile or due to architecture restrictions). | dh_makeshlibs -plib32ncurses6 -V "lib32ncurses6 (>= 6.1)" -- -c4 | dh_makeshlibs: All requested packages have been excluded (e.g. via a Build-Profile or due to architecture restrictions). | dh_makeshlibs -plib32ncursesw6 -V "lib32ncursesw6 (>= 6.1)" -- -c4 | dh_makeshlibs: All requested packages have been excluded (e.g. via a Build-Profile or due to architecture restrictions). ` , | $ grep "in control file but not in files list" ncurses_6.1+20180210-4_amd64.build | dpkg-genchanges: warning: package lib32tinfo6 in control file but not in files list | dpkg-genchanges: warning: package lib32ncurses6 in control file but not in files list | dpkg-genchanges: warning: package lib32ncursesw6 in control file but not in files list | dpkg-genchanges: warning: package lib32ncurses-dev in control file but not in files list ` -- System Information: Debian Release: buster/sid APT prefers unstable APT policy: (500, 'unstable'), (101, 'experimental') Architecture: i386 (x86_64) Foreign Architectures: amd64 Kernel: Linux 4.17.2-nouveau (SMP w/2 CPU cores) Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE=de_DE.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) Versions of packages debhelper depends on: ii autotools-dev20180224.1 ii dh-autoreconf19 ii dh-strip-nondeterminism 0.042-1 ii dpkg 1.19.1 ii dpkg-dev 1.19.1 ii dwz 0.12-2 ii file 1:5.33-3 ii libdpkg-perl 1.19.1 ii man-db 2.8.3-2 ii perl 5.26.2-6 ii po-debconf 1.0.20 debhelper recommends no packages. Versions of packages debhelper suggests: ii dh-make 2.201801 -- no debconf information
