Bug#907819: jellyfish: Does not build on paths containing "-L"

2018-09-06 Thread Adrian Bunk
On Mon, Sep 03, 2018 at 12:09:58AM +0200, Santiago Vila wrote:
> severity 907819 serious
> thanks
> 
> > The buildds use a UUID, which cannot contain L.
> 
> Please take a look by yourself. Official build log of jellyfish on amd64:
> 
> https://buildd.debian.org/status/fetch.php?pkg=jellyfish=amd64=2.2.8-3%2Bb1=1530287126=0
> 
> It contains the following line:
> 
> I: NOTICE: Log filtering will replace 
> 'build/jellyfish-PmG8fS/jellyfish-2.2.8' with '<>'

I was blind, looked at CHROOT instead...

> The string "PmG8fS" is not a UUID, it's a random string from mktemp,
> and of course it *will* start with L (sooner or later).
> 
> (But I already explained this in my previous message).

Thanks for this.

As a side effect, I finally understand what is happening in #896861.

> Thanks.

cu
Adrian

-- 

   "Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
   "Only a promise," Lao Er said.
   Pearl S. Buck - Dragon Seed



Bug#907819: jellyfish: Does not build on paths containing "-L"

2018-09-02 Thread Santiago Vila
On Mon, Sep 03, 2018 at 01:00:15AM +0300, Adrian Bunk wrote:

> jellyfish doesn't do anything here that strikes me as wrong,
> my first suspects for the root cause would be libtool or automake.

Well, I see this kind of thing in examples/jf_count_dump/Makefile

LDFLAGS = -Wl,--rpath=$(shell pkg-config --libs-only-L jellyfish-2.0 | sed -e 
's/-L//g')

That might work if the output of pkg-config is somewhere in /usr/[...]
but I guess this is being used with the installed version at
WHATEVER/debian/tmp/[...].

Then there is the python script

swig/python/setup.py

which does stuff regarding libraries and paths, this is partially
patched by debian/patches/drop-rpath.

Thanks.



Processed: Re: Bug#907819: jellyfish: Does not build on paths containing "-L"

2018-09-02 Thread Debian Bug Tracking System
Processing commands for cont...@bugs.debian.org:

> severity 907819 serious
Bug #907819 [src:jellyfish] jellyfish: Does not build on paths containing "-L" 
resulting in random FTBFS when built by sbuild
Severity set to 'serious' from 'important'
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
907819: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=907819
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems



Processed: Re: Bug#907819: jellyfish: Does not build on paths containing "-L"

2018-09-02 Thread Debian Bug Tracking System
Processing control commands:

> severity -1 important
Bug #907819 [src:jellyfish] jellyfish: Does not build on paths containing "-L" 
resulting in random FTBFS when built by sbuild
Severity set to 'important' from 'serious'

-- 
907819: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=907819
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems



Bug#907819: jellyfish: Does not build on paths containing "-L"

2018-09-02 Thread Adrian Bunk
Control: severity -1 important

On Sun, Sep 02, 2018 at 10:36:28PM +0200, Santiago Vila wrote:
>...
> On Sun, Sep 02, 2018 at 09:43:28PM +0300, Adrian Bunk wrote:
>...
> > https://people.debian.org/~sanvila/build-logs/jellyfish/jellyfish_2.2.8-3_amd64-20180902T150417Z
> > 
> > ...
> > I: NOTICE: Log filtering will replace 
> > 'build/jellyfish-La3pVw/jellyfish-2.2.8' with '<>'
> > ...
> > x86_64-linux-gnu-g++ -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions 
> > -Wl,-z,relro -Wl,-z,relro -Wl,-z,now -g -O2 
> > -fdebug-prefix-map=/<>=. -fstack-protector-strong -Wformat 
> > -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 
> > build/temp.linux-amd64-3.7/jellyfish_wrap.o 
> > -L/build/jellyfisha3pVw/jellyfish-2.2.8/debian/tmp//usr/lib/x86_64-linux-gnu
> >  
> > -Wl,--enable-new-dtags,-R/<>/debian/tmp/usr/lib/x86_64-linux-gnu
> >  -ljellyfish-2.0 -lpthread -o 
> > /<>/.pybuild/cpython3_3.7_dna-jellyfish/build/_dna_jellyfish.cpython-37m-x86_64-linux-gnu.so
> > /usr/bin/ld: cannot find -ljellyfish-2.0
> > 
> > 
> > Something (libtool?) removes the "-L" from the "jellyfish-La3pVw",
> 
> Good catch! Yes, that's what it seems to happen!
> 
> 
> However, this can happen in any official buildd the same way it happened to 
> me.
> 
> In every build log there are three different messages about log filtering,
> like this:
> 
> I: NOTICE: Log filtering will replace 
> 'var/run/schroot/mount/sid-53306582-5e1d-46e9-87b2-1e8840f72cfe' with 
> '<>'
> 
> [...]
> 
> I: NOTICE: Log filtering will replace 
> 'build/jellyfish-La3pVw/jellyfish-2.2.8' with '<>'
> I: NOTICE: Log filtering will replace 'build/jellyfish-La3pVw' with 
> '<>'
> 
> 
> The first one is a UUID (alphanumeric) and by design it's clear that
> it will never contain "-L".
> 
> But the last two are chosen by sbuild randomly, using "mktemp -d" and
> the algorithm followed by sbuild to construct this random path does not
> seem to be different from buildd to the packaged version of sbuild I'm
> using.
> 
> So not only there may be a "-L" in a path in the official buildds,
> but it mathematically will (provided you try enough times).
> 
> So yes, this package FTBFS randomly in the official buildds too.

No, it cannot.

The buildds use a UUID, which cannot contain L.

I was lucky that you provided build logs this time, bugs without any 
logs are basically "minor moreinfo" since there is nothing that can
be done about such bugs.

Please double-check whether in other bugs you reported the buildpath 
contained strings like -l or -L or -I or similar that cannot happen
on the buildds, and that might have caused such build failures noone 
can reproduce.

And in any case, please ensure that all your bugs have a full
build log attached or linked (reproducible is fine).

> We could of course change the algorithm used by sbuild to construct
> this random path, but really, packages are supposed to be buildable
> in any path, and definitely on paths containing "-L".

jellyfish doesn't do anything here that strikes me as wrong,
my first suspects for the root cause would be libtool or automake.

> Thanks.

cu
Adrian

-- 

   "Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
   "Only a promise," Lao Er said.
   Pearl S. Buck - Dragon Seed



Processed: Re: Bug#907819: jellyfish: Does not build on paths containing "-L"

2018-09-02 Thread Debian Bug Tracking System
Processing commands for cont...@bugs.debian.org:

> retitle 907819 jellyfish: Does not build on paths containing "-L" resulting 
> in random FTBFS when built by sbuild
Bug #907819 [src:jellyfish] jellyfish: FTBFS randomly (ld: cannot find 
-ljellyfish-2.0)
Changed Bug title to 'jellyfish: Does not build on paths containing "-L" 
resulting in random FTBFS when built by sbuild' from 'jellyfish: FTBFS randomly 
(ld: cannot find -ljellyfish-2.0)'.
> severity 907819 serious
Bug #907819 [src:jellyfish] jellyfish: Does not build on paths containing "-L" 
resulting in random FTBFS when built by sbuild
Severity set to 'serious' from 'minor'
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
907819: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=907819
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems