Your message dated Sun, 13 Jan 2019 16:04:26 +0000
with message-id <e1giifo-0003ky...@fasolo.debian.org>
and subject line Bug#919172: fixed in ball 1.5.0+git20180813.37fc53c-2
has caused the Debian Bug report #919172,
regarding ball FTBFS on architectures where char is unsigned
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
919172: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=919172
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: ball
Version: 1.5.0+git20180813.37fc53c-1
Severity: serious
Tags: patch ftbfs

https://buildd.debian.org/status/package.php?p=ball&suite=sid

...
[  9%] Building CXX object CMakeFiles/BALL.dir/source/DATATYPE/hashGrid.C.o
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3: 
error: narrowing conversion of '-1' from 'int' to 'char' inside { } 
[-Wnarrowing]
   };
   ^
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3: 
error: narrowing conversion of '-1' from 'int' to 'char' inside { } 
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3: 
error: narrowing conversion of '-1' from 'int' to 'char' inside { } 
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3: 
error: narrowing conversion of '-1' from 'int' to 'char' inside { } 
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3: 
error: narrowing conversion of '-1' from 'int' to 'char' inside { } 
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3: 
error: narrowing conversion of '-1' from 'int' to 'char' inside { } 
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3: 
error: narrowing conversion of '-1' from 'int' to 'char' inside { } 
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3: 
error: narrowing conversion of '-1' from 'int' to 'char' inside { } 
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3: 
error: narrowing conversion of '-1' from 'int' to 'char' inside { } 
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3: 
error: narrowing conversion of '-1' from 'int' to 'char' inside { } 
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3: 
error: narrowing conversion of '-1' from 'int' to 'char' inside { } 
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3: 
error: narrowing conversion of '-1' from 'int' to 'char' inside { } 
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3: 
error: narrowing conversion of '-1' from 'int' to 'char' inside { } 
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3: 
error: narrowing conversion of '-1' from 'int' to 'char' inside { } 
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3: 
error: narrowing conversion of '-1' from 'int' to 'char' inside { } 
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3: 
error: narrowing conversion of '-1' from 'int' to 'char' inside { } 
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3: 
error: narrowing conversion of '-1' from 'int' to 'char' inside { } 
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3: 
error: narrowing conversion of '-1' from 'int' to 'char' inside { } 
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3: 
error: narrowing conversion of '-1' from 'int' to 'char' inside { } 
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3: 
error: narrowing conversion of '-1' from 'int' to 'char' inside { } 
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3: 
error: narrowing conversion of '-1' from 'int' to 'char' inside { } 
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3: 
error: narrowing conversion of '-1' from 'int' to 'char' inside { } 
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3: 
error: narrowing conversion of '-1' from 'int' to 'char' inside { } 
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3: 
error: narrowing conversion of '-1' from 'int' to 'char' inside { } 
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3: 
error: narrowing conversion of '-1' from 'int' to 'char' inside { } 
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3: 
error: narrowing conversion of '-1' from 'int' to 'char' inside { } 
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3: 
error: narrowing conversion of '-1' from 'int' to 'char' inside { } 
[-Wnarrowing]
make[5]: *** [CMakeFiles/BALL.dir/build.make:522: 
CMakeFiles/BALL.dir/source/DATATYPE/hashGrid.C.o] Error 1


Fix is attached.
Description: Fix FTBFS on architectures where char is unsigned
Author: Adrian Bunk <b...@debian.org>

--- ball-1.5.0+git20180813.37fc53c.orig/include/BALL/DATATYPE/hashGrid.h
+++ ball-1.5.0+git20180813.37fc53c/include/BALL/DATATYPE/hashGrid.h
@@ -32,7 +32,7 @@ namespace BALL
 {
        namespace __private
        {
-               extern const char BALL_EXPORT neighbour_table_[27][3];
+               extern const signed char BALL_EXPORT neighbour_table_[27][3];
        }
 
        template <typename Item> class HashGrid3;
--- ball-1.5.0+git20180813.37fc53c.orig/source/DATATYPE/hashGrid.C
+++ ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C
@@ -9,7 +9,7 @@ namespace BALL
 {
        namespace __private
        {
-               const char neighbour_table_[27][3] =
+               const signed char neighbour_table_[27][3] =
                {
                        { 0,  0,  0 }, { 0,  0, -1 }, { 0,  0,  1 },
                        { 0, -1, -1 }, { 0, -1,  0 }, { 0, -1,  1 },

--- End Message ---
--- Begin Message ---
Source: ball
Source-Version: 1.5.0+git20180813.37fc53c-2

We believe that the bug you reported is fixed in the latest version of
ball, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 919...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Andreas Tille <ti...@debian.org> (supplier of updated ball package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 13 Jan 2019 15:49:01 +0100
Source: ball
Binary: libball1.5-data libball1.5 libball1.5-dev libballview1.5 
libballview1.5-dev python-ball ballview libball1.5-doc
Architecture: source
Version: 1.5.0+git20180813.37fc53c-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Med Packaging Team 
<debian-med-packag...@lists.alioth.debian.org>
Changed-By: Andreas Tille <ti...@debian.org>
Description:
 ballview   - free molecular modeling and molecular graphics tool
 libball1.5 - Biochemical Algorithms Library
 libball1.5-data - Biochemical Algorithms Library (data files)
 libball1.5-dev - Header files for the Biochemical Algorithms Library
 libball1.5-doc - documentation for the BALL library
 libballview1.5 - Biochemical Algorithms Library, VIEW framework
 libballview1.5-dev - Header files for the VIEW part of the Biochemical 
Algorithms Libr
 python-ball - Python bindings for the Biochemical Algorithms Library
Closes: 784451 919172
Changes:
 ball (1.5.0+git20180813.37fc53c-2) unstable; urgency=medium
 .
   * Fix Build-Depends (Thanks for the hints to Adrian Bunk
     <b...@debian.org>)
     Closes: #784451
   * Fix FTBFS on architectures where char is unsigned
     (Thanks for the fix to Adrian Bunk <b...@debian.org>)
     Closes: #919172
Checksums-Sha1:
 86deaedbe497f07ece3e417f91ce6bb211efa50c 3045 
ball_1.5.0+git20180813.37fc53c-2.dsc
 84917dd92f6c0c2284d6803c5f12124b6732e592 12472 
ball_1.5.0+git20180813.37fc53c-2.debian.tar.xz
 357ae17fc48d412955697eef537c9e47f1bd2eca 21685 
ball_1.5.0+git20180813.37fc53c-2_amd64.buildinfo
Checksums-Sha256:
 17de0f9493bb081dac930c4ba479b3570ccf57198a82f89cada358a394af37a6 3045 
ball_1.5.0+git20180813.37fc53c-2.dsc
 7c147b00291d6039b9aa4abaa8bd39fd8a063596464a29f07a5e0f164da3bf7f 12472 
ball_1.5.0+git20180813.37fc53c-2.debian.tar.xz
 0f98ea0e4ac30cfd29ce00ddeec752bcc22afd178f14795366e9575c45e9eed2 21685 
ball_1.5.0+git20180813.37fc53c-2_amd64.buildinfo
Files:
 c27712227a107dfa0cdc8b828b072eaf 3045 science optional 
ball_1.5.0+git20180813.37fc53c-2.dsc
 522e8756e8fc4e8f6da52d96fd19ff8f 12472 science optional 
ball_1.5.0+git20180813.37fc53c-2.debian.tar.xz
 a53a77daa2932db383fda07210338b0f 21685 science optional 
ball_1.5.0+git20180813.37fc53c-2_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJFBAEBCgAvFiEE8fAHMgoDVUHwpmPKV4oElNHGRtEFAlw7XkMRHHRpbGxlQGRl
Ymlhbi5vcmcACgkQV4oElNHGRtHPrQ/8D0XtVjxUygqrEp17vS3P2mHBZf1SNIt1
M7a9TwDCGDkig7fRQmnb4rGM3JQQAWDtW9YbQlwPUxY1VptbZr4M1tWuBQkWF2/u
z772psDPXEQlc3lRu0Akf4DuK8ynfJTjpGzCHp+hz+j62NbGqjf/rG96CzwzjaAa
12FoWXcX4rzHavjLLHrx7/cZUZSKZdcJQ1qx5Crq9o4DvB572aNg/GERsbUdZHtW
JTBvx3xoXUvz/2vzE/DE7TlO2J32RKt34EtBi8A6bkeXxYy/ilEjygkDg6QmYpB7
VaRxfxrBNhclnwG4kuUpJIGo0IK3cgz+eNVcDq9nfXdqBsvyK3K/oszFmBveRU6e
gqt6Aqarcrfe5lvpW/Xt1g95W4a0qxM/Mhx5XFeRmxPCnV7jr8RM95/9TgrGVQuF
DI5sILo0xu3/XIl/tYvwaoTsBF6vY1T6b0KIkXM+uSUr/sCE7cXIYiB9duVSfmQI
BEp9IXCdp02BdHQSdZ18m/Mtu2A+HODo62/ymwkhyH7tGwr85QktwxG2gz9xuU2q
ADo8PfDyl3fedAGcQWgZjQvz7p4GZBe2xxnaOwiEeyJGJpeJ0AYnlBAiMi0nkqZN
llgTxawjWcIo0u+TwQuzFbYMBjrPBMJk4Ukb5mhqEAebApj0M7fc9Nl2n+RNLiU/
0XbuSMi2xPM=
=4eko
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to