Bug#926103: Freeze-exception for pcsc-cyberjack 3.99.5final.sp09-2

2019-04-09 Thread Ivo De Decker 

Hi,

On 4/9/19 12:14 AM, Reinhard Tartler wrote:

Hi Release Team,

Frank and I would like to see RC bug #926103 fixed in Debian 10. Please approve 
the attached debdiff, so that I can upload the fixed package to unstable.


We really prefer unblock request bugs instead of mails to the list, to 
make sure the request is tracked and doesn't get lost.


That said, please go ahead and do the upload of 3.99.5final.sp09-2 to 
unstable based on the diff you sent.



Thank you for your consideration.


Thanks,

Ivo

Bug#926103: Freeze-exception for pcsc-cyberjack 3.99.5final.sp09-2

2019-04-09 Thread Erik Brangs 

Hi,

On 09.04.19 00:14, Reinhard Tartler wrote:

Frank and I would like to see RC bug #926103 fixed in Debian 10. Please approve 
the attached debdiff, so that I can upload the fixed package to unstable.


I'm a user of the package and would like to see the fixed version in buster. I think 
you're supposed to file an unblock request (Section "Applying for an unblock" 
in the freeze policy at https://release.debian.org/buster/freeze_policy.html ).


Kind regards,

Erik Brangs

Bug#926103: Freeze-exception for pcsc-cyberjack 3.99.5final.sp09-2

2019-04-08 Thread Reinhard Tartler 
Hi Release Team,

Frank and I would like to see RC bug #926103 fixed in Debian 10. Please approve 
the attached debdiff, so that I can upload the fixed package to unstable.

Thank you for your consideration.

Best,
Reinhard
diff -Nru pcsc-cyberjack-3.99.5final.sp09/debian/changelog 
pcsc-cyberjack-3.99.5final.sp09/debian/changelog
--- pcsc-cyberjack-3.99.5final.sp09/debian/changelog2017-05-29 
14:33:13.0 -0400
+++ pcsc-cyberjack-3.99.5final.sp09/debian/changelog2019-04-08 
17:58:31.0 -0400
@@ -1,3 +1,11 @@
+pcsc-cyberjack (3.99.5final.sp09-2) unstable; urgency=medium
+
+  * Acknoledge NMU.
+  * Bug fix: "driver breaks with pcsc-lite versions >= 1.8.21", thanks
+to Peter Wienemann (Closes: #926103).
+
+ -- Reinhard Tartler   Mon, 08 Apr 2019 17:58:31 -0400
+
 pcsc-cyberjack (3.99.5final.sp09-1.1) unstable; urgency=medium
 
   * Non-maintainer upload.
diff -Nru pcsc-cyberjack-3.99.5final.sp09/debian/patches/series 
pcsc-cyberjack-3.99.5final.sp09/debian/patches/series
--- pcsc-cyberjack-3.99.5final.sp09/debian/patches/series   2017-05-29 
14:33:11.0 -0400
+++ pcsc-cyberjack-3.99.5final.sp09/debian/patches/series   2019-04-08 
17:58:31.0 -0400
@@ -1 +1,2 @@
 enable_pinpad_ecom.patch
+work-with-newer-pcsc-lite.patch
diff -Nru 
pcsc-cyberjack-3.99.5final.sp09/debian/patches/work-with-newer-pcsc-lite.patch 
pcsc-cyberjack-3.99.5final.sp09/debian/patches/work-with-newer-pcsc-lite.patch
--- 
pcsc-cyberjack-3.99.5final.sp09/debian/patches/work-with-newer-pcsc-lite.patch  
1969-12-31 19:00:00.0 -0500
+++ 
pcsc-cyberjack-3.99.5final.sp09/debian/patches/work-with-newer-pcsc-lite.patch  
2019-04-08 17:58:31.0 -0400
@@ -0,0 +1,58 @@
+commit 8ab61acfa0a8efc3c65098d4c621d761b7e05da1
+Author: Frank Neuber 
+Date:   Fri Apr 27 11:09:24 2018 +0200
+
+correct the large buffer problem with newer versions of pcscd
+
+--- a/cjeca32/EC30Reader.cpp
 b/cjeca32/EC30Reader.cpp
+@@ -162,21 +162,23 @@ CJ_RESULT CEC30Reader::CtApplicationData
+ {
+int Res;
+   uint32_t Len;
+-  uint16_t wLenRsp=0;
+-  uint16_t wLenErr=0;
++  uint32_t wLenRsp=0;
++  uint32_t wLenErr=0;
+   if(ResponseLen!=0)
+-  wLenRsp=(uint16_t)*ResponseLen;
++  wLenRsp=*ResponseLen;
+   if(ApplicationErrorLength!=NULL)
+-  wLenErr=(uint16_t)*ApplicationErrorLength;
+-  if(m_nApplicationResponseLength<(uint32_t)wLenRsp+wLenErr+4)
++  wLenErr=*ApplicationErrorLength;
++  Len=4+wLenRsp+wLenErr;
++  if(m_nApplicationResponseLength0xFFFB) // overflow or bigger than 0x - 4
++  return CJ_ERR_WRONG_PARAMETER;
+ 
+   
if((Res=Escape(ApplicationID,Function,InputData,InputLen,Result,m_pApplicationResponse,,Slot)))
+   {
+@@ -186,10 +188,14 @@ CJ_RESULT CEC30Reader::CtApplicationData
+   *ApplicationErrorLength=0;
+   return Res;
+   }
+-  memcpy(,m_pApplicationResponse,sizeof(wLenRsp));
+-  wLenRsp=ReaderToHostShort(wLenRsp);
+-  memcpy(,m_pApplicationResponse+2,sizeof(wLenErr));
+-  wLenErr=ReaderToHostShort(wLenErr);
++
++  uint16_t wLenRsp16 = 0;
++  uint16_t wLenErr16 = 0;
++  memcpy(,m_pApplicationResponse,sizeof(wLenRsp16));
++  wLenRsp=ReaderToHostShort(wLenRsp16);
++  memcpy(,m_pApplicationResponse+2,sizeof(wLenErr16));
++  wLenErr=ReaderToHostShort(wLenErr16);
++
+   if(ApplicationErrorLength)
+   {
+   if(wLenErr>*ApplicationErrorLength)