Processed: Re: Bug#926591: libelogind0: does not ship SONAME link /lib//libelogind.so.0 -> libsystemd.so.0.25.0

2019-04-08 Thread Debian Bug Tracking System
Processing control commands:

> tags -1 pending
Bug #926591 [libelogind0] libelogind0: does not ship SONAME link 
/lib//libelogind.so.0 -> libsystemd.so.0.25.0
Added tag(s) pending.

-- 
926591: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=926591
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems



Bug#926591: libelogind0: does not ship SONAME link /lib//libelogind.so.0 -> libsystemd.so.0.25.0

2019-04-08 Thread Mark Hindley
control: tags -1 pending

On Sun, Apr 07, 2019 at 02:12:54PM +0200, Andreas Beckmann wrote:
> I think the symlink setup is overly complicated by using both
> /lib and /usr/lib. You should either move everything to /lib
> (if that is really required for compatibility with libsystemd0)
> or just restrict to /usr/lib (as done in my patch).
> I also think you don't need libsystemd.so.0.25.0 symlinks at all,
> a libsystemd.so.0 -> libelogind.so.0 symlink should be sufficient.

Thanks for this. I have queued your patch for upload.

> This produces some noise in piuparts tests and therefore I'd like
> to see it fixed for buster.

Version 241.1-1 isn't in buster and I am not sure if it will make it in as there
is no sign of movement in the unblock request (#925489). But I am happy to fix
it in unstable.

Thanks

Mark



Bug#926591: libelogind0: does not ship SONAME link /lib//libelogind.so.0 -> libsystemd.so.0.25.0

2019-04-07 Thread Andreas Beckmann
Package: libelogind0
Version: 241.1-1+debian1
Severity: serious
Tags: patch
User: debian...@lists.debian.org
Usertags: piuparts

Hi,

during a test with piuparts I noticed your package does not ship the
SONAME link for its library (Policy 8.1).
That link got created later by ldconfig.

>From the attached log (scroll to the bottom...):

0m16.6s DEBUG: Starting command: ['chroot', '/srv/piuparts/tmp/tmpL2PdQe', 
'tmp/scripts/pre_remove_40_find_unowned_lib_links']
0m17.2s DUMP: 
  UNOWNED SYMLINK /lib/x86_64-linux-gnu/libelogind.so.0 -> libsystemd.so.0.25.0
0m17.2s DEBUG: Command ok: ['chroot', '/srv/piuparts/tmp/tmpL2PdQe', 
'tmp/scripts/pre_remove_40_find_unowned_lib_links']

I think the symlink setup is overly complicated by using both
/lib and /usr/lib. You should either move everything to /lib
(if that is really required for compatibility with libsystemd0)
or just restrict to /usr/lib (as done in my patch).
I also think you don't need libsystemd.so.0.25.0 symlinks at all,
a libsystemd.so.0 -> libelogind.so.0 symlink should be sufficient.

This produces some noise in piuparts tests and therefore I'd like
to see it fixed for buster.

Andreas
>From 331f7543426163abf628ae13feee4c2253e930c8 Mon Sep 17 00:00:00 2001
From: Andreas Beckmann 
Date: Sun, 7 Apr 2019 13:32:25 +0200
Subject: [PATCH] simplify compat symlink setup

---
 debian/changelog | 3 +++
 debian/libelogind0.links | 3 +--
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index 572ae4b8f..9ff0bef1d 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -3,6 +3,9 @@ elogind (241.1-2~wip1) UNRELEASED; urgency=medium
   [ Andreas Messer ]
   * Retire package maintenance
 
+  [ Andreas Beckmann ]
+  * Simplify compat symlink setup.  (Closes: #xx)
+
  -- Andreas Messer   Fri, 15 Mar 2019 18:06:50 +0100
 
 elogind (241.1-1) unstable; urgency=medium
diff --git a/debian/libelogind0.links b/debian/libelogind0.links
index 47785742c..dd1a34455 100755
--- a/debian/libelogind0.links
+++ b/debian/libelogind0.links
@@ -1,3 +1,2 @@
 #! /usr/bin/dh-exec
-usr/lib/${DEB_HOST_MULTIARCH}/libelogind.so.0.25.0 
lib/${DEB_HOST_MULTIARCH}/libsystemd.so.0.25.0
-lib/${DEB_HOST_MULTIARCH}/libsystemd.so.0.25.0 
lib/${DEB_HOST_MULTIARCH}/libsystemd.so.0
+usr/lib/${DEB_HOST_MULTIARCH}/libelogind.so.0 
usr/lib/${DEB_HOST_MULTIARCH}/libsystemd.so.0
-- 
2.11.0



libelogind0_241.1-1+debian1.log.gz
Description: application/gzip