Bug#927126: Fwd: Bug#929342: unblock: aqemu/0.9.2-2.2
Le 11/06/2019 à 21:58, Paul Gevers a écrit : > Hi Alexis, > > [Note: when you think you have covered questions asked, please remove > the moreinfo tag, as it will make the bug show up in the list of bugs > that need attention from us]. Ok, I guess that tag should be removed once aqemu/0.9.2-2.3 enter unstable, right ? > > On 06-06-2019 22:16, Alexis Murzeau wrote: >> The modification I've done in version aqemu/0.9.2-2.3 specifically fix >> descriptions that was referring to VLAN or Virtual LAN (all instances) >> as reported by Jonathan. >> I've reused the description of the various command line arguments that >> no longer accept the vlan parameter from the qemu man page. >> >> (aqemu/0.9.2-2.3 is not in unstable as of now). >> >> This is the diff between aqemu/0.9.2-2.2 (unstable) and aqemu/0.9.2-2.3 >> (upload candidate on mentors.debian.net): >> >> https://salsa.debian.org/amurzeau-guest/aqemu/compare/debian%2F0.9.2-2.2...debian%2F0.9.2-2.3#380c8035425c8dcf8fb5ead9e2d4e5bc1a9f7192 > > This looks OK, so I think it is best to find a sponsor to upload that, > such that we can proceed with unblocking when the full patch is reviewed. > >> And the diff between actual buster version (aqemu/0.9.2-2.1) and >> aqemu/0.9.2-2.3: >> >> https://salsa.debian.org/amurzeau-guest/aqemu/compare/debian%2F0.9.2-2.1...debian%2F0.9.2-2.3 > > I specifically note that I have *not* checked the full diff. > > Paul > I will make an RFS since Abhijith does not seem available to do the upload. -- Alexis Murzeau PGP: B7E6 0EBB 9293 7B06 BDBC 2787 E7BD 1904 F480 937F signature.asc Description: OpenPGP digital signature
Bug#927126: Fwd: Bug#929342: unblock: aqemu/0.9.2-2.2
Hi Alexis, [Note: when you think you have covered questions asked, please remove the moreinfo tag, as it will make the bug show up in the list of bugs that need attention from us]. On 06-06-2019 22:16, Alexis Murzeau wrote: > The modification I've done in version aqemu/0.9.2-2.3 specifically fix > descriptions that was referring to VLAN or Virtual LAN (all instances) > as reported by Jonathan. > I've reused the description of the various command line arguments that > no longer accept the vlan parameter from the qemu man page. > > (aqemu/0.9.2-2.3 is not in unstable as of now). > > This is the diff between aqemu/0.9.2-2.2 (unstable) and aqemu/0.9.2-2.3 > (upload candidate on mentors.debian.net): > > https://salsa.debian.org/amurzeau-guest/aqemu/compare/debian%2F0.9.2-2.2...debian%2F0.9.2-2.3#380c8035425c8dcf8fb5ead9e2d4e5bc1a9f7192 This looks OK, so I think it is best to find a sponsor to upload that, such that we can proceed with unblocking when the full patch is reviewed. > And the diff between actual buster version (aqemu/0.9.2-2.1) and > aqemu/0.9.2-2.3: > > https://salsa.debian.org/amurzeau-guest/aqemu/compare/debian%2F0.9.2-2.1...debian%2F0.9.2-2.3 I specifically note that I have *not* checked the full diff. Paul signature.asc Description: OpenPGP digital signature
Bug#927126: Fwd: Bug#929342: unblock: aqemu/0.9.2-2.2
Le 06/06/2019 à 21:34, Paul Gevers a écrit : > Hi Alexis, > > On Sun, 2 Jun 2019 22:35:47 +0200 Alexis Murzeau wrote: >> Did you have any chance to look at this ? Is this upload ok ? > > Looking at the message header (the TO field) you addressed you sponsor > with this question, right? I think you should however be able to answer > the question by Jonathan yourself. Yes, it was addressed to Abhijith PA. > > """ > This might benefit from another read; it seems to remove the vlan > parameter but still refer to it in the text? It's worth checking through > for any other similar instances. > """ > > Please comment on it, and we can follow up again. > > Paul > The modification I've done in version aqemu/0.9.2-2.3 specifically fix descriptions that was referring to VLAN or Virtual LAN (all instances) as reported by Jonathan. I've reused the description of the various command line arguments that no longer accept the vlan parameter from the qemu man page. (aqemu/0.9.2-2.3 is not in unstable as of now). This is the diff between aqemu/0.9.2-2.2 (unstable) and aqemu/0.9.2-2.3 (upload candidate on mentors.debian.net): https://salsa.debian.org/amurzeau-guest/aqemu/compare/debian%2F0.9.2-2.2...debian%2F0.9.2-2.3#380c8035425c8dcf8fb5ead9e2d4e5bc1a9f7192 And the diff between actual buster version (aqemu/0.9.2-2.1) and aqemu/0.9.2-2.3: https://salsa.debian.org/amurzeau-guest/aqemu/compare/debian%2F0.9.2-2.1...debian%2F0.9.2-2.3 -- Alexis Murzeau PGP: B7E6 0EBB 9293 7B06 BDBC 2787 E7BD 1904 F480 937F signature.asc Description: OpenPGP digital signature
Bug#927126: Fwd: Bug#929342: unblock: aqemu/0.9.2-2.2
Hi Alexis, On Sun, 2 Jun 2019 22:35:47 +0200 Alexis Murzeau wrote: > Did you have any chance to look at this ? Is this upload ok ? Looking at the message header (the TO field) you addressed you sponsor with this question, right? I think you should however be able to answer the question by Jonathan yourself. """ This might benefit from another read; it seems to remove the vlan parameter but still refer to it in the text? It's worth checking through for any other similar instances. """ Please comment on it, and we can follow up again. Paul signature.asc Description: OpenPGP digital signature
Bug#927126: Fwd: Bug#929342: unblock: aqemu/0.9.2-2.2
Le 28/05/2019 à 00:16, Alexis Murzeau a écrit : > Le 27/05/2019 à 21:58, Alexis Murzeau a écrit : >> Le 27/05/2019 à 08:02, Abhijith PA a écrit : >>> On 26 May 2019 4:01:33 PM IST, Alexis Murzeau wrote: Ok, I have changed them to use what's is in the qemu-system manpage. Here is the commit on salsa: [0] Also, while aqemu will be able to run qemu again, I think it won't be able to create multiple virtual hub as the command line option "-net nic" only use the default hub ID 0. I don't know if this a serious issue that should be fixed too. In the meanwhile, I guess aqemu will still be able to create multiple nic but all of them will be connected to the same default hub. What do you think of this ? >>> >>> What is the upstream preferred way of doing this ? >>> [0] https://salsa.debian.org/amurzeau-guest/aqemu/commit/26087ea3c3700bc5a019ae8cc0f84eb14954ef3d >>> >> >> I didn't ask upstream about it but given the last commit is in 2017 and >> the change I've backported was partly made by someone else in a fork, I >> don't expect any response from upstream. >> >> I think updating aqemu to be able to create multiple virtual hub again >> is possible but would require more changes than a small patch. I think >> it would require to remove the use of old -net option of qemu to the >> newer -netdev. >> > > For reference, the original issue about the vlan argument was also > reported upstream in 09/2018 as: > https://github.com/tobimensch/aqemu/issues/58 > > I'm not an aqemu user myself, but if you think that's ok anyway as at > least configurations with single nic are working now, I've uploaded the > package on mentors, here is the dsc link: > > https://mentors.debian.net/debian/pool/main/a/aqemu/aqemu_0.9.2-2.3.dsc > Hi, Did you have any chance to look at this ? Is this upload ok ? -- Alexis Murzeau PGP: B7E6 0EBB 9293 7B06 BDBC 2787 E7BD 1904 F480 937F signature.asc Description: OpenPGP digital signature
