Bug#931695: libgit-raw-perl: FTBFS with libgit2 0.28
On Thu, 28 Nov 2019 18:02:20 +, Peter Green wrote:
> On 28/11/2019 16:19, gregor herrmann wrote:
> > > A debdiff should appear soon at
> > > https://debdiffs.raspbian.org/main/libg/libgit-raw-perl
> > … this is still a 404 (and the pool/ directory also still has the old
> > version)
> Apologies, it appears that rust built-using generation does not
> like binnmus and this has snarled up our update process. I am
> working on un-snarling it now and the debdiff will be generated
> when it is unsnarled.
No worries, and good luck in fixing the build infrastructure.
> > As I don't see any obvious problems with the clean target (I can also
> > build twice in a row), could you send your fix to the BTS please?
>
> override_dh_auto_clean:
> dh_auto_clean
> rm -f t/merge_repo/test1
I see, thank you.
> It would not surprise me if said file is only left behind after the
> build fails with a testsuite failure, and not after a successful
> build.
Right, that makes sense.
*quick grep*
== t/15-merge.t ==
my $path = rel2abs(catfile('t', 'merge_repo'));
make_path($path);
…
rmtree $path;
So yeah, t/merge_repo is removed in the test which failed
before the patch.
Hm, I guess if the build fails with a failing test we are not very
worried about a stray subdirectory in t/ :)
Ok, I uploaded -7 earlier tonight, so unless new problems emerge
you should be able to sync it from Debian/bullseye in a couple of
days.
Thanks again,
gregor
--
.''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org
: :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06
`. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
`- NP: Bjørn Berge: Heartbreaker
signature.asc
Description: Digital Signature
Bug#931695: libgit-raw-perl: FTBFS with libgit2 0.28
On 28/11/2019 16:19, gregor herrmann wrote: A debdiff should appear soon at https://debdiffs.raspbian.org/main/libg/libgit-raw-perl … this is still a 404 (and the pool/ directory also still has the old version) Apologies, it appears that rust built-using generation does not like binnmus and this has snarled up our update process. I am working on un-snarling it now and the debdiff will be generated when it is unsnarled. As I don't see any obvious problems with the clean target (I can also build twice in a row), could you send your fix to the BTS please? override_dh_auto_clean: dh_auto_clean rm -f t/merge_repo/test1 It would not surprise me if said file is only left behind after the build fails with a testsuite failure, and not after a successful build.
Bug#931695: libgit-raw-perl: FTBFS with libgit2 0.28
On Thu, 28 Nov 2019 02:18:55 +, Peter Green wrote: > Some poking around revealed that upstream fixed this by removing > the last (NULL) parameter from the call. This was done in a commit > titled "minor fixes". > https://github.com/jacquesg/p5-Git-Raw/commit/30f7a4491ab453d28ae1fa1b393fcd023f6c344d Thanks! I can confirm that the second hunk of the patch makes the package build (module tests) in Debian/sid as well. > . There was also another apparently unrelated change in the commit, > which did not seem relavent to the version in Debian. That's already there as debian/patches/fix-33-worktree.patch > A couple of tests failed, but that could have just been my build > environment, I decided this was good enough to disable the > testsuite and upload to raspbian. I also found fixes for the tests in the upstream git repo. > While working on this I ran into an issue with the clean target not > cleaning up properly, so I fixed that too. That sounds interesting but > A debdiff should appear soon at > https://debdiffs.raspbian.org/main/libg/libgit-raw-perl … this is still a 404 (and the pool/ directory also still has the old version) As I don't see any obvious problems with the clean target (I can also build twice in a row), could you send your fix to the BTS please? Cheers, gregor -- .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe `- NP: Carole King: Eventually signature.asc Description: Digital Signature
Bug#931695: libgit-raw-perl: FTBFS with libgit2 0.28
tags 931695 +patch thanks Some poking around revealed that upstream fixed this by removing the last (NULL) parameter from the call. This was done in a commit titled "minor fixes". https://github.com/jacquesg/p5-Git-Raw/commit/30f7a4491ab453d28ae1fa1b393fcd023f6c344d . There was also another apparently unrelated change in the commit, which did not seem relavent to the version in Debian. I did a test build with this change in a raspbian bullseye-staging chroot. A couple of tests failed, but that could have just been my build environment, I decided this was good enough to disable the testsuite and upload to raspbian. While working on this I ran into an issue with the clean target not cleaning up properly, so I fixed that too. A debdiff should appear soon at https://debdiffs.raspbian.org/main/libg/libgit-raw-perl No intent to NMU in debian.
