Bug#932073: closed by Niels Thykier (Bug#932073: fixed in debhelper 12.2.1)
Helmut Grohne: > Control: reopen -1 > Control: affects -1 + src:dropbear > > On Tue, Jul 16, 2019 at 08:42:09PM +, Debian Bug Tracking System wrote: >>* dh_installinit: Fix regression where dh_installinit bailed >> out on --name if only one of the acted on packages had an >> init script file. Thanks to Helmut Grohne for reporting >> the issue. (Closes: #932073) > > The bug is partially fixed. A full build of openssh and dropbear now > works. At least the following situation (dropbar) is still broken: > > The init script lives in an arch-all package, you pass the relevant > --name and you perform an arch-only build. Here is a cross build log, > but it fully reproduces natively: > > http://crossqa.debian.net/build/dropbear_2019.78-1_mips_20190717050430.log > > I'm also confused by the following message: > > dh_link: No packages to build. Architecture mismatch: amd64, want: all any > > It happens both during native and during cross builds of dropbear. I > would have assumed that "amd64" and "mips" match the "any" part of "all > any". I'd appreciate if someone could enlighten me about this aspect. > > Helmut > Thanks reopening the bug. I have considered it for a while and I think the correct answer is to take a step back and consider whether this is truly the best approach (e.g. Guillem filed #932152 as an alternative that completely replaces --name and the related issues). Accordingly, I will revert the change and reopen #462389. For reference, I am aware of at least 3 suggested changes/patches related to this bug after Helmut reopened it. (Those are Dmitry's follow plus two independent merge requests on salsa). Thanks, ~Niels
Bug#932073: closed by Niels Thykier (Bug#932073: fixed in debhelper 12.2.1)
control: tags -1 +confirmed
[2019-07-17 07:41] Helmut Grohne
> part text/plain1094
> Control: reopen -1
> Control: affects -1 + src:dropbear
>
> On Tue, Jul 16, 2019 at 08:42:09PM +, Debian Bug Tracking System wrote:
> >* dh_installinit: Fix regression where dh_installinit bailed
> > out on --name if only one of the acted on packages had an
> > init script file. Thanks to Helmut Grohne for reporting
> > the issue. (Closes: #932073)
>
> The bug is partially fixed. A full build of openssh and dropbear now
> works. At least the following situation (dropbar) is still broken:
>
> The init script lives in an arch-all package, you pass the relevant
> --name and you perform an arch-only build. Here is a cross build log,
> but it fully reproduces natively:
Yep, -A/-B separation. Can someone remind me its purpose?
As for code, then instead of "$dh{DOPACKAGES}" there must be
"getpackages()", like this. Not sure how to write regression test for
this situation.
diff --git a/dh_installinit b/dh_installinit
index 5aecf25b..6a7abaf8 100755
--- a/dh_installinit
+++ b/dh_installinit
@@ -233,7 +233,7 @@ init(options => {
my %snippet_options = ('snippet-order' => 'service');
if (my $name = $dh{NAME}) {
- if (!grep { -f "debian/$_.${name}.init" || -f
"debian/$_.${name}.default" } @{$dh{DOPACKAGES}}) {
+ if (!grep { -f "debian/$_.${name}.init" || -f
"debian/$_.${name}.default" } getpackages()) {
error("--name=$dh{NAME} option specified, but init script nor
default file not found");
}
}
--
Note, that I send and fetch email in batch, once in a few days.
Please, mention in body of your reply when you add or remove recepients.
Processed: Re: Bug#932073: closed by Niels Thykier (Bug#932073: fixed in debhelper 12.2.1)
Processing control commands: > tags -1 +confirmed Bug #932073 [debhelper] dh_installinit fails with "--name=foo option specified, but init script not found" Bug #932170 [debhelper] bird2: FTBFS (dh_installinit: --name=bird option specified, but init script not found) Added tag(s) confirmed. Added tag(s) confirmed. -- 932073: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=932073 932170: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=932170 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#932073: closed by Niels Thykier (Bug#932073: fixed in debhelper 12.2.1)
Control: reopen -1 Control: affects -1 + src:dropbear On Tue, Jul 16, 2019 at 08:42:09PM +, Debian Bug Tracking System wrote: >* dh_installinit: Fix regression where dh_installinit bailed > out on --name if only one of the acted on packages had an > init script file. Thanks to Helmut Grohne for reporting > the issue. (Closes: #932073) The bug is partially fixed. A full build of openssh and dropbear now works. At least the following situation (dropbar) is still broken: The init script lives in an arch-all package, you pass the relevant --name and you perform an arch-only build. Here is a cross build log, but it fully reproduces natively: http://crossqa.debian.net/build/dropbear_2019.78-1_mips_20190717050430.log I'm also confused by the following message: dh_link: No packages to build. Architecture mismatch: amd64, want: all any It happens both during native and during cross builds of dropbear. I would have assumed that "amd64" and "mips" match the "any" part of "all any". I'd appreciate if someone could enlighten me about this aspect. Helmut
Processed: Re: Bug#932073 closed by Niels Thykier (Bug#932073: fixed in debhelper 12.2.1)
Processing control commands:
> reopen -1
Bug #932073 {Done: Niels Thykier } [debhelper]
dh_installinit fails with "--name=foo option specified, but init script not
found"
Bug #932170 {Done: Niels Thykier } [debhelper] bird2: FTBFS
(dh_installinit: --name=bird option specified, but init script not found)
'reopen' may be inappropriate when a bug has been closed with a version;
all fixed versions will be cleared, and you may need to re-add them.
Bug reopened
No longer marked as fixed in versions debhelper/12.2.1.
No longer marked as fixed in versions debhelper/12.2.1.
> affects -1 + src:dropbear
Bug #932073 [debhelper] dh_installinit fails with "--name=foo option specified,
but init script not found"
Bug #932170 [debhelper] bird2: FTBFS (dh_installinit: --name=bird option
specified, but init script not found)
Added indication that 932073 affects src:dropbear
Added indication that 932170 affects src:dropbear
--
932073: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=932073
932170: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=932170
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
