Bug#934034: monkeysphere: FTBFS in stretch

2019-08-14 Thread Chris Lamb
Dear Niels,

>  1) The current bug metadata suggests it affects sid.  Please ensure the
> bug is resolved in sid (by fixing it in sid or correcting bug
> metadata as appropriate).

I cannot reproduce in buster, sid or experimental and have thus
adjusting the metadata of #934034 to match.

>  2) File an opu (and a separate pu bug if it also affects buster) with
> the full debdiff (including changelog). This ensures that the stable
> release team will get have a look at the issue.

I've filed this as #934775 and further I completely understand the
underlying reasons for insisting on such a process.

> Thanks for considering to fix bugs in stretch.

No problem; thank you for your advice and patient guidance.


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org  chris-lamb.co.uk
   `-



Bug#934034: monkeysphere: FTBFS in stretch

2019-08-13 Thread Niels Thykier
Chris Lamb:
> [Correctly adding t...@release.debian.org to CC...]
> 
> Hi Santiago,
> 
>> For completeness I would also make the build-dependency on gnupg to be
>> versioned.
> 
> Good idea; updated patch attached.
> 
> Stable release managers, would you consider this for the next stretch
> point release?
> 
> 
> Regards,
> 

Hi Chris,

Thanks for considering to fix bugs in stretch.

Please use the process described in [1] to ensure we will get to look at it:

 1) The current bug metadata suggests it affects sid.  Please ensure the
bug is resolved in sid (by fixing it in sid or correcting bug
metadata as appropriate).

 2) File an opu (and a separate pu bug if it also affects buster) with
the full debdiff (including changelog). This ensures that the stable
release team will get have a look at the issue.


We are quite insisting on 2) as it is very hard for us to keep track of
non-bugs requests.  This is a lesson learned time and again (both for us
and Debian contributors).


As for your concrete diff (IANASRM, but my personally take is that): It
looks like something we would accept as stable update. Note that [1]
describes some short cuts that may or may not be applicable to your
situation.

Thanks,
~Niels

[1] https://lists.debian.org/debian-devel-announce/2019/08/msg0.html



Bug#934034: monkeysphere: FTBFS in stretch

2019-08-13 Thread Chris Lamb
[Correctly adding t...@release.debian.org to CC...]

Hi Santiago,

> For completeness I would also make the build-dependency on gnupg to be
> versioned.

Good idea; updated patch attached.

Stable release managers, would you consider this for the next stretch
point release?


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org  chris-lamb.co.uk
   `-diff --git a/debian/control b/debian/control
index 95750f4..19c4dbb 100644
--- a/debian/control
+++ b/debian/control
@@ -9,7 +9,7 @@ Build-Depends:
  cpio,
  debhelper (>= 10~),
  dpkg-dev (>= 1.17.14),
- gnupg ,
+ gnupg (>= 2.1.18-8~deb9u4) ,
  gnupg-agent ,
  libassuan-dev,
  libcrypt-openssl-rsa-perl ,
diff --git a/tests/keytrans b/tests/keytrans
index fd9a144..5b23a16 100755
--- a/tests/keytrans
+++ b/tests/keytrans
@@ -137,9 +137,9 @@ gpg --list-keys
 cat >"$TEMPDIR"/expectedout <"$TEMPDIR"/expectedout <"$TEMPDIR"/expectedout <

Bug#934034: monkeysphere: FTBFS in stretch

2019-08-13 Thread Chris Lamb
[Adding rele...@lists.debian.org to CC]

Hi Santiago,

> For completeness I would also make the build-dependency on gnupg to be
> versioned.

Good idea; updated patch attached.

Stable release managers, would you consider this for the next stretch
point release?


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org  chris-lamb.co.uk
   `-diff --git a/debian/control b/debian/control
index 95750f4..19c4dbb 100644
--- a/debian/control
+++ b/debian/control
@@ -9,7 +9,7 @@ Build-Depends:
  cpio,
  debhelper (>= 10~),
  dpkg-dev (>= 1.17.14),
- gnupg ,
+ gnupg (>= 2.1.18-8~deb9u4) ,
  gnupg-agent ,
  libassuan-dev,
  libcrypt-openssl-rsa-perl ,
diff --git a/tests/keytrans b/tests/keytrans
index fd9a144..5b23a16 100755
--- a/tests/keytrans
+++ b/tests/keytrans
@@ -137,9 +137,9 @@ gpg --list-keys
 cat >"$TEMPDIR"/expectedout <"$TEMPDIR"/expectedout <"$TEMPDIR"/expectedout <

Bug#934034: monkeysphere: FTBFS in stretch

2019-08-10 Thread Santiago Vila
Hi.

I confirm that the patch by Chris Lamb fixes the build failure.

For completeness I would also make the build-dependency on gnupg to be
versioned.

Thanks.



Bug#934034: monkeysphere: FTBFS in stretch (failing tests)

2019-08-06 Thread Santiago Vila
Package: src:monkeysphere
Version: 0.41-1
Severity: serious
Tags: ftbfs

Dear maintainer:

I tried to build this package in stretch but it failed:


[...]
 debian/rules build-indep
dh build-indep
   dh_testdir -i
   dh_update_autotools_config -i
   dh_autoreconf -i
   dh_auto_configure -i
   dh_auto_build -i
make -j1
make[1]: Entering directory '/<>'
gcc -o src/agent-transfer/agent-transfer -g -O2 
-fdebug-prefix-map=/<>=. -fstack-protector-strong -Wformat 
-Werror=format-security   --pedantic -Wall -Werror -std=c99 -Wdate-time 
-D_FORTIFY_SOURCE=2 -Wl,-z,relro -Wl,-z,now src/agent-transfer/main.c -lassuan 
-L/usr/lib/x86_64-linux-gnu -lgpg-error -lgcrypt
mkdir -p replaced/src/
sed < src/monkeysphere > replaced/src/monkeysphere \
-e 's:__SYSSHAREDIR_PREFIX__:/usr:' \
-e 's:__SYSCONFDIR_PREFIX__::' \
-e 's:__SYSDATADIR_PREFIX__:/var/lib:'
mkdir -p replaced/src/
sed < src/monkeysphere-host > replaced/src/monkeysphere-host \
-e 's:__SYSSHAREDIR_PREFIX__:/usr:' \
-e 's:__SYSCONFDIR_PREFIX__::' \
-e 's:__SYSDATADIR_PREFIX__:/var/lib:'
mkdir -p replaced/src/
sed < src/monkeysphere-authentication > 
replaced/src/monkeysphere-authentication \
-e 's:__SYSSHAREDIR_PREFIX__:/usr:' \
-e 's:__SYSCONFDIR_PREFIX__::' \
-e 's:__SYSDATADIR_PREFIX__:/var/lib:'
mkdir -p replaced/src/share/
sed < src/share/defaultenv > replaced/src/share/defaultenv \
-e 's:__SYSSHAREDIR_PREFIX__:/usr:' \
-e 's:__SYSCONFDIR_PREFIX__::' \
-e 's:__SYSDATADIR_PREFIX__:/var/lib:'
mkdir -p replaced/src/transitions/
sed < src/transitions/0.23 > replaced/src/transitions/0.23 \
-e 's:__SYSSHAREDIR_PREFIX__:/usr:' \
-e 's:__SYSCONFDIR_PREFIX__::' \
-e 's:__SYSDATADIR_PREFIX__:/var/lib:'
mkdir -p replaced/src/transitions/
sed < src/transitions/0.28 > replaced/src/transitions/0.28 \
-e 's:__SYSSHAREDIR_PREFIX__:/usr:' \
-e 's:__SYSCONFDIR_PREFIX__::' \
-e 's:__SYSDATADIR_PREFIX__:/var/lib:'
mkdir -p replaced/src/transitions/
sed < src/transitions/README.txt > replaced/src/transitions/README.txt \
-e 's:__SYSSHAREDIR_PREFIX__:/usr:' \
-e 's:__SYSCONFDIR_PREFIX__::' \
-e 's:__SYSDATADIR_PREFIX__:/var/lib:'
mkdir -p replaced/man/man1/
sed < man/man1/monkeysphere.1 > replaced/man/man1/monkeysphere.1 \
-e 's:__SYSSHAREDIR_PREFIX__:/usr:' \
-e 's:__SYSCONFDIR_PREFIX__::' \
-e 's:__SYSDATADIR_PREFIX__:/var/lib:'
gzip -n replaced/man/man1/monkeysphere.1
mkdir -p replaced/man/man1/
sed < man/man1/agent-transfer.1 > replaced/man/man1/agent-transfer.1 \
-e 's:__SYSSHAREDIR_PREFIX__:/usr:' \
-e 's:__SYSCONFDIR_PREFIX__::' \
-e 's:__SYSDATADIR_PREFIX__:/var/lib:'
gzip -n replaced/man/man1/agent-transfer.1
mkdir -p replaced/man/man1/
sed < man/man1/openpgp2ssh.1 > replaced/man/man1/openpgp2ssh.1 \
-e 's:__SYSSHAREDIR_PREFIX__:/usr:' \
-e 's:__SYSCONFDIR_PREFIX__::' \
-e 's:__SYSDATADIR_PREFIX__:/var/lib:'
gzip -n replaced/man/man1/openpgp2ssh.1
mkdir -p replaced/man/man1/
sed < man/man1/pem2openpgp.1 > replaced/man/man1/pem2openpgp.1 \
-e 's:__SYSSHAREDIR_PREFIX__:/usr:' \
-e 's:__SYSCONFDIR_PREFIX__::' \
-e 's:__SYSDATADIR_PREFIX__:/var/lib:'
gzip -n replaced/man/man1/pem2openpgp.1
mkdir -p replaced/man/man8/
sed < man/man8/monkeysphere-authentication.8 > 
replaced/man/man8/monkeysphere-authentication.8 \
-e 's:__SYSSHAREDIR_PREFIX__:/usr:' \
-e 's:__SYSCONFDIR_PREFIX__::' \
-e 's:__SYSDATADIR_PREFIX__:/var/lib:'
gzip -n replaced/man/man8/monkeysphere-authentication.8
mkdir -p replaced/man/man8/
sed < man/man8/monkeysphere-host.8 > replaced/man/man8/monkeysphere-host.8 \
-e 's:__SYSSHAREDIR_PREFIX__:/usr:' \
-e 's:__SYSCONFDIR_PREFIX__::' \
-e 's:__SYSDATADIR_PREFIX__:/var/lib:'
gzip -n replaced/man/man8/monkeysphere-host.8
mkdir -p replaced/man/man7/
sed < man/man7/monkeysphere.7 > replaced/man/man7/monkeysphere.7 \
-e 's:__SYSSHAREDIR_PREFIX__:/usr:' \
-e 's:__SYSCONFDIR_PREFIX__::' \
-e 's:__SYSDATADIR_PREFIX__:/var/lib:'
gzip -n replaced/man/man7/monkeysphere.7
make[1]: Leaving directory '/<>'
   dh_auto_test -i
make -j1 test
make[1]: Entering directory '/<>'
MONKEYSPHERE_TEST_NO_EXAMINE=true ./tests/keytrans
##
### generating openpgp key...
gpg: keybox '/<>/tests/tmp/ms.5MW/pubring.kbx' created
gpg: /<>/tests/tmp/ms.5MW/trustdb.gpg: trustdb created
gpg: key A28F4C7A72BA3ACE marked as ultimately trusted
gpg: directory '/<>/tests/tmp/ms.5MW/openpgp-revocs.d' created
gpg: revocation certificate stored as 
'/<>/tests/tmp/ms.5MW/openpgp-revocs.d/110B0A0392E152A667CDA1E5A28F4C7A72BA3ACE.rev'
gpg: done
##
### retrieving key timestamp...
gpg: checking the trustdb
gpg: marginals needed: 3  completes needed: 1  trust model: pgp
gpg: depth: 0  valid:   1  signed:   0  trust: 0-, 0q, 0n, 0m, 0f, 1u
##
### exporting key to ssh file...
##
### reconvert key, and compare to key in gpg