Bug#939561: soapybladerf ftbfs in unstable

[Andreas Bombe]

On Thu, Sep 12, 2019 at 04:42:53PM +0100, peter green wrote:
> tags 939561 +fixed-upstream
> tags 939561 +patch
> thanks
> 
> Some googling revealed that upstream had fixed this issue 
> https://github.com/pothosware/SoapyBladeRF/pull/19 . I was able to take the 
> upstream pull request, turn it into a patch series and apply it to the Debian 
> package.
> 
> I have uploaded my fix to raspbian, a debdiff can be found at 
> http://debdiffs.raspbian.org/main/s/soapybladerf/soapybladerf_0.3.5-1+rpi1.debdiff
>  , no intent to NMU in Debian.

Thanks for this, I'm going to use it to upload a fixed revision of the
current version to Debian. I am working on updating all soapysdr modules
now, but with the ABI version change all the transitioning will take a
while so this is a welcome help to cover for the time until that
completes.

Bug#939561: soapybladerf ftbfs in unstable

[peter green]

tags 939561 +fixed-upstream
tags 939561 +patch
thanks

Some googling revealed that upstream had fixed this issue 
https://github.com/pothosware/SoapyBladeRF/pull/19 . I was able to take the 
upstream pull request, turn it into a patch series and apply it to the Debian 
package.

I have uploaded my fix to raspbian, a debdiff can be found at 
http://debdiffs.raspbian.org/main/s/soapybladerf/soapybladerf_0.3.5-1+rpi1.debdiff
 , no intent to NMU in Debian.

Bug#939561: soapybladerf ftbfs in unstable

[Matthias Klose]

Package: src:soapybladerf
Version: 0.3.5-1
Severity: serious
Tags: sid bullseye

soapybladerf ftbfs in unstable:

/usr/bin/c++  -DHAS_BLADERF_GAIN_MODE -DbladeRFSupport_EXPORTS 
-I/<>  -g -O2 -fdebug-prefix-map=/<>=. 
-fstack-protector-strong -Wformat -Werror=format-security -Wdate-time 
-D_FORTIFY_SOURCE=2 -fvisibility-inlines-hidden -std=c++11 -fPIC 
-Wno-unused-parameter -Wall -Wextra -fvisibility=hidden -std=gnu++11 -o 
CMakeFiles/bladeRFSupport.dir/bladeRF_Streaming.cpp.o -c 
/<>/bladeRF_Streaming.cpp
/<>/bladeRF_Streaming.cpp: In member function ‘virtual 
SoapySDR::Stream* bladeRF_SoapySDR::setupStream(int, const string&, const 
std::vector&, const Kwargs&)’:
/<>/bladeRF_Streaming.cpp:125:17: error: invalid conversion from 
‘bladerf_module’ {aka ‘int’} to ‘bladerf_channel_layout’ [-fpermissive]

  125 | _dir2mod(direction),
  | ^~~
  | |
  | bladerf_module {aka int}
In file included from /<>/bladeRF_SoapySDR.hpp:26,
 from /<>/bladeRF_Streaming.cpp:22:
/usr/include/libbladeRF.h:2555:58: note:   initializing argument 2 of ‘int 
bladerf_sync_config(bladerf*, bladerf_channel_layout, bladerf_format, unsigned 
int, unsigned int, unsigned int, unsigned int)’

 2555 |   bladerf_channel_layout layout,
  |   ~~~^~
/<>/bladeRF_Streaming.cpp: In member function ‘virtual int 
bladeRF_SoapySDR::writeStream(SoapySDR::Stream*, const void* const*, size_t, 
int&, long long int, long int)’:
/<>/bladeRF_Streaming.cpp:387:41: error: invalid conversion from 
‘bladerf_channel’ {aka ‘int’} to ‘bladerf_direction’ [-fpermissive]

  387 | bladerf_get_timestamp(_dev, BLADERF_MODULE_TX, 
);
  | ^
  | |
  | bladerf_channel {aka int}
/usr/include/libbladeRF.h:2481:55: note:   initializing argument 2 of ‘int 
bladerf_get_timestamp(bladerf*, bladerf_direction, bladerf_timestamp*)’

 2481 | bladerf_direction dir,
  | ~~^~~
/<>/bladeRF_Settings.cpp: In member function ‘virtual double 
bladeRF_SoapySDR::getFrequency(int, size_t, const string&) const’:
/<>/bladeRF_Settings.cpp:411:64: error: cannot convert ‘unsigned 
int*’ to ‘bladerf_frequency*’ {aka ‘long unsigned int*’}

  411 | int ret = bladerf_get_frequency(_dev, _dir2mod(direction), );
  |^
  ||
  |unsigned 
int*

In file included from /<>/bladeRF_SoapySDR.hpp:26,
 from /<>/bladeRF_Settings.cpp:22:
/usr/include/libbladeRF.h:1277:56: note:   initializing argument 3 of ‘int 
bladerf_get_frequency(bladerf*, bladerf_channel, bladerf_frequency*)’

 1277 | bladerf_frequency *frequency);
  | ~~~^
/<>/bladeRF_Settings.cpp: In member function ‘virtual long long int 
bladeRF_SoapySDR::getHardwareTime(const string&) const’:
/<>/bladeRF_Settings.cpp:570:49: error: invalid conversion from 
‘bladerf_channel’ {aka ‘int’} to ‘bladerf_direction’ [-fpermissive]
  570 | const int ret = bladerf_get_timestamp(_dev, BLADERF_MODULE_RX, 
);

  | ^
  | |
  | bladerf_channel {aka 
int}
/usr/include/libbladeRF.h:2481:55: note:   initializing argument 2 of ‘int 
bladerf_get_timestamp(bladerf*, bladerf_direction, bladerf_timestamp*)’

 2481 | bladerf_direction dir,
  | ~~^~~
/<>/bladeRF_Settings.cpp: In member function ‘virtual void 
bladeRF_SoapySDR::writeSetting(const string&, const string&)’:
/<>/bladeRF_Settings.cpp:823:50: error: ‘bladerf_module’ is not a 
class, namespace, or enumeration
  823 | bladerf_xb200_set_path(_dev, 
bladerf_module::BLADERF_MODULE_RX, bladerf_xb200_path::BLADERF_XB200_BYPASS);

  |  ^~
In file included from /<>/bladeRF_SoapySDR.hpp:26,
 from /<>/bladeRF_Settings.cpp:22:
/<>/bladeRF_Settings.cpp:823:66: error: expected unqualified-id 
before ‘(’ token
  823 | bladerf_xb200_set_path(_dev, 
bladerf_module::BLADERF_MODULE_RX, bladerf_xb200_path::BLADERF_XB200_BYPASS);
  | 
^
/<>/bladeRF_Settings.cpp:823:66: error: expected primary-expression 
before ‘)’ token
  823 | bladerf_xb200_set_path(_dev,