Bug#941917: nginx: FTBFS on several architectures: luajit.h: No such file or directory

2019-10-13 Thread Christos Trochalakis

On Mon, Oct 07, 2019 at 06:16:48PM +0300, Niko Tyni wrote:

This package failed to build from source on arm64, mips64el, ppc64el
and s390x, but earlier versions built there successfully in the past.

This is preventing 1.16.1-1 testing migration and is a blocker for
the ongoing Perl 5.30 transition.

See https://buildd.debian.org/status/package.php?p=nginx=unstable

From the arm64 log:

 cc -c -fPIC -g -O2 -fdebug-prefix-map=/<>=. -fstack-protector-strong -Wformat -Werror=format-security -g -O2 -fdebug-prefix-map=/<>=. 
-fstack-protector-strong -Wformat -Werror=format-security -fPIC -Wdate-time -D_FORTIFY_SOURCE=2 -DNDK_SET_VAR -I src/core -I src/event -I src/event/modules -I src/os/unix -I 
src/http/modules/perl -I /<>/debian/modules/http-ndk/objs -I objs/addon/ndk -I /<>/debian/modules/http-ndk/src -I 
/<>/debian/modules/http-ndk/objs -I objs/addon/ndk -I /<>/debian/modules/nchan/src -I 
/<>/debian/modules/http-lua/src/api -I /usr/include/lua5.1 -I /<>/debian/modules/rtmp -I /usr/include/libxml2 -I objs -I src/http -I 
src/http/modules -I src/http/v2 -I /<>/debian/modules/http-ndk/src -I src/mail -I src/stream \
-o objs/addon/src/ngx_http_lua_log.o \
/<>/debian/modules/http-lua/src/ngx_http_lua_log.c
 In file included from 
/<>/debian/modules/http-lua/src/ngx_http_lua_script.h:11,
  from 
/<>/debian/modules/http-lua/src/ngx_http_lua_script.c:13:
 /<>/debian/modules/http-lua/src/ngx_http_lua_common.h:20:10: 
fatal error: luajit.h: No such file or directory
20 | #include 
   |  ^~
 compilation terminated.
 make[3]: *** [objs/Makefile:2443: objs/addon/src/ngx_http_lua_script.o] Error 1



Sorry for the long delay. I uploaded 1.16.1-2 yesterday which downgrades
http-lua to v0.0.13, the last working version, to unblock the perl
transition.

Copying from the http-lua's README (master, not yet released v0.0.16):
https://github.com/openresty/lua-nginx-module


Since version v0.10.16 of this module, the standard Lua interpreter
(also known as "PUC-Rio Lua") is not supported anymore.


So I am working on a patch that skips building the module for non luajit
archs.



Bug#941917: nginx: FTBFS on several architectures: luajit.h: No such file or directory

2019-10-12 Thread gregor herrmann
On Thu, 10 Oct 2019 23:46:26 +0200, gregor herrmann wrote:

> Any news here? This is the last blocker for the perl 5.30 transition.

The release team managed to binNMU nginx 1.14.2-3 in
testing-proposed-updates against perl 5.30, so this is not a blocker
anymore.


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   NP: Der Junge mit der Gitarre: Nie wieder Grand Prix


signature.asc
Description: Digital Signature


Bug#941917: nginx: FTBFS on several architectures: luajit.h: No such file or directory

2019-10-12 Thread Roland Rosenfeld
On Sa, 12 Okt 2019, Roland Rosenfeld wrote:

> Looking at the salsa git repository of nignx, the following commit
> seems to trigger the problem:
> 
> https://salsa.debian.org/nginx-team/nginx/commit/132704ab76aa72ce29d00e4acd50d3218693558b#f072d72ac821d4e63439739975074c7c5aed9bf7
> 
> commit 132704ab76aa72ce29d00e4acd50d3218693558b
> Author: Christos Trochalakis 
> Date:   Mon Sep 9 17:32:06 2019 +0300
> 
> http-lua: Upgrade to 0.10.15
> 
> [...]
> --- a/debian/modules/http-lua/src/ngx_http_lua_common.h
> +++ b/debian/modules/http-lua/src/ngx_http_lua_common.h
> @@ -17,7 +17,7 @@
>  #include 
>  #include 
>  
> -#include 
> +#include 
>  #include 
>  #include 
> [...]

And here is the upstream commit for this:
https://github.com/openresty/lua-nginx-module/commit/7286812116940216344ade33722c49ae47037605

Greetings
Roland



Bug#941917: nginx: FTBFS on several architectures: luajit.h: No such file or directory

2019-10-12 Thread Roland Rosenfeld
On Di, 08 Okt 2019, Hideki Yamane wrote:

>  In debian/control, Build-Depends: libluajit-5.1-dev [i386 amd64
>  kfreebsd-i386 armel armhf powerpc powerpcspe mips mipsel] is wrong,
>  as https://buildd.debian.org/status/package.php?p=luajit=sid
>  says below archs are built.

>  So, it should be libluajit-5.1-dev [amd64 arm64 armel armhf i386
>  mips64el mipsel ppc64el hurd-i386 kfreebsd-amd64 kfreebsd-i386
>  powerpc ppc64] and so on.

That should be correct, but it does not solve the problem for s390x,
where libluajit-5.1-dev still does not exist.

> And it seems that it should check whether its arch has
> libluajit-5.1-dev or not.

That's the root problem.
Looking at the salsa git repository of nignx, the following commit
seems to trigger the problem:

https://salsa.debian.org/nginx-team/nginx/commit/132704ab76aa72ce29d00e4acd50d3218693558b#f072d72ac821d4e63439739975074c7c5aed9bf7

commit 132704ab76aa72ce29d00e4acd50d3218693558b
Author: Christos Trochalakis 
Date:   Mon Sep 9 17:32:06 2019 +0300

http-lua: Upgrade to 0.10.15

[...]
--- a/debian/modules/http-lua/src/ngx_http_lua_common.h
+++ b/debian/modules/http-lua/src/ngx_http_lua_common.h
@@ -17,7 +17,7 @@
 #include 
 #include 
 
-#include 
+#include 
 #include 
 #include 
[...]

So here we may need a mechanism that checks whether luajit.h exists
and falls back to lua.h otherwise or stop building nginx on systems
where libluajit-5.1-dev does not exist.

From my point of view this should not be a blocker of the perl
transition, since nginx 1.16.1-1 with the above change was uploaded
2019-09-12 and never successfully built on arm64, mpis64el, ppc64el
and s390x while the perl migration started at 2019-10-05.

I expect the testing version 1.14.2-3 to build without problems with
perl 5.30.0-6 on these architectures...

Greetings
Roland



Bug#941917: nginx: FTBFS on several architectures: luajit.h: No such file or directory

2019-10-11 Thread gregor herrmann
On Thu, 10 Oct 2019 23:46:26 +0200, gregor herrmann wrote:

> Do I understand this correctly that changing the architecture list
> should fix the bug short-term and then the failing luajit detection
> should be fixed as well? At least the first part would be quite easy.

A quick test on the arm64 porterbox seems to indicate that a simple
update of the architecture list for the liblua* build dependencies is
indeed enough to fix the immediate problem.


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   NP: Police: Wrapped Around Your Finger


signature.asc
Description: Digital Signature


Bug#941917: nginx: FTBFS on several architectures: luajit.h: No such file or directory

2019-10-10 Thread gregor herrmann
On Tue, 08 Oct 2019 01:07:04 +0900, Hideki Yamane wrote:

>  In debian/control, Build-Depends: libluajit-5.1-dev [i386 amd64 
> kfreebsd-i386 armel armhf powerpc powerpcspe mips mipsel]
>  is wrong, as https://buildd.debian.org/status/package.php?p=luajit=sid 
> says below archs are built.
[..] 
>  So, it should be libluajit-5.1-dev [amd64 arm64 armel armhf i386 mips64el 
> mipsel ppc64el hurd-i386 kfreebsd-amd64 kfreebsd-i386 powerpc ppc64] and so 
> on.
>  And it seems that it should check whether its arch has libluajit-5.1-dev or 
> not.

Any news here? This is the last blocker for the perl 5.30 transition.

Do I understand this correctly that changing the architecture list
should fix the bug short-term and then the failing luajit detection
should be fixed as well? At least the first part would be quite easy.


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   NP: Dave Brubeck: Unsquare Dance


signature.asc
Description: Digital Signature


Bug#941917: nginx: FTBFS on several architectures: luajit.h: No such file or directory

2019-10-07 Thread Hideki Yamane
Hi,

 In debian/control, Build-Depends: libluajit-5.1-dev [i386 amd64 kfreebsd-i386 
armel armhf powerpc powerpcspe mips mipsel]
 is wrong, as https://buildd.debian.org/status/package.php?p=luajit=sid 
says below archs are built.

amd64
arm64
armel
armhf
i386
mips64el
mipsel
ppc64el
hurd-i386
kfreebsd-amd64
kfreebsd-i386
powerpc
ppc64

 So, it should be libluajit-5.1-dev [amd64 arm64 armel armhf i386 mips64el 
mipsel ppc64el hurd-i386 kfreebsd-amd64 kfreebsd-i386 powerpc ppc64] and so on.
 And it seems that it should check whether its arch has libluajit-5.1-dev or 
not.


-- 
Regards,

 Hideki Yamane henrich @ debian.org/iijmio-mail.jp



Bug#941917: nginx: FTBFS on several architectures: luajit.h: No such file or directory

2019-10-07 Thread Niko Tyni
Source: nginx
Version: 1.16.1-1
Severity: serious
Tags: ftbfs
Control: block 935737 with -1

This package failed to build from source on arm64, mips64el, ppc64el
and s390x, but earlier versions built there successfully in the past.

This is preventing 1.16.1-1 testing migration and is a blocker for
the ongoing Perl 5.30 transition.

See https://buildd.debian.org/status/package.php?p=nginx=unstable

>From the arm64 log:

  cc -c -fPIC -g -O2 -fdebug-prefix-map=/<>=. 
-fstack-protector-strong -Wformat -Werror=format-security -g -O2 
-fdebug-prefix-map=/<>=. -fstack-protector-strong -Wformat 
-Werror=format-security -fPIC -Wdate-time -D_FORTIFY_SOURCE=2 -DNDK_SET_VAR -I 
src/core -I src/event -I src/event/modules -I src/os/unix -I 
src/http/modules/perl -I /<>/debian/modules/http-ndk/objs -I 
objs/addon/ndk -I /<>/debian/modules/http-ndk/src -I 
/<>/debian/modules/http-ndk/objs -I objs/addon/ndk -I 
/<>/debian/modules/nchan/src -I 
/<>/debian/modules/http-lua/src/api -I /usr/include/lua5.1 -I 
/<>/debian/modules/rtmp -I /usr/include/libxml2 -I objs -I 
src/http -I src/http/modules -I src/http/v2 -I 
/<>/debian/modules/http-ndk/src -I src/mail -I src/stream \
-o objs/addon/src/ngx_http_lua_log.o \
/<>/debian/modules/http-lua/src/ngx_http_lua_log.c
  In file included from 
/<>/debian/modules/http-lua/src/ngx_http_lua_script.h:11,
   from 
/<>/debian/modules/http-lua/src/ngx_http_lua_script.c:13:
  /<>/debian/modules/http-lua/src/ngx_http_lua_common.h:20:10: 
fatal error: luajit.h: No such file or directory
 20 | #include 
|  ^~
  compilation terminated.
  make[3]: *** [objs/Makefile:2443: objs/addon/src/ngx_http_lua_script.o] Error 
1
 
-- 
Niko Tyni   nt...@debian.org