Bug#944151: remctl: attempts internet connection during testsuite

[Russ Allbery]

Now fixed, although I got the changelog message wrong because I still
didn't understand properly.  Ugh.  I could have sworn that Debian buildds
didn't allow network access.  I'll fix the changelog message in a future
upload.

Thank you!

-- 
Russ Allbery (r...@debian.org)  

Bug#944151: remctl: attempts internet connection during testsuite

[Russ Allbery]

Gianfranco Costamagna  writes:

> Hello, according to build log:
> Testing Python extension
> running pytest
> Searching for typing
> Reading https://pypi.org/simple/typing/
> Downloading 
> https://files.pythonhosted.org/packages/fe/2e/b480ee1b75e6d17d2993738670e75c1feeb9ff7f64452153cf018051cc92/typing-3.7.4.1-py3-none-any.whl#sha256=f38d83c5a7a7086543a0f649564d661859c5146a85775ab90c0d2f93ffaa9714
> Best match: typing 3.7.4.1
> Processing typing-3.7.4.1-py3-none-any.whl
> Installing typing-3.7.4.1-py3-none-any.whl to /<>/python/.eggs

Ah, thank you, I thought setuptools was much smarter than apparently it
actually is.  I'll look at this tonight; I may fix this upstream instead
of only in the Debian package if it doesn't take too long to do.

-- 
Russ Allbery (r...@debian.org)  

Bug#944151: remctl: attempts internet connection during testsuite

[Gianfranco Costamagna]

control: tags -1 patch
On 05/11/19 07:55, Gianfranco Costamagna wrote:
> Source: remctl
> Version: 3.16-3
> Severity: serious
> 
> Hello, according to build log:
> Testing Python extension
> running pytest
> Searching for typing
> Reading https://pypi.org/simple/typing/
> Downloading 
> https://files.pythonhosted.org/packages/fe/2e/b480ee1b75e6d17d2993738670e75c1feeb9ff7f64452153cf018051cc92/typing-3.7.4.1-py3-none-any.whl#sha256=f38d83c5a7a7086543a0f649564d661859c5146a85775ab90c0d2f93ffaa9714
> Best match: typing 3.7.4.1
> Processing typing-3.7.4.1-py3-none-any.whl
> Installing typing-3.7.4.1-py3-none-any.whl to /<>/python/.eggs
> 
> it does internet connection during its build...
> You can see a failure in Ubuntu, where internet connection is more strictly 
> disabled.
> https://launchpadlibrarian.net/449766521/buildlog_ubuntu-focal-amd64.remctl_3.16-3_BUILDING.txt.gz
> 
> Can you please move into an autopkgtest or patch to avoid it?
> 

looks like typing is a Python2 package, while with Python3 it is natively 
supported, so that dependency has to be conditionalized
for Python2 builds, or dropped since we do not provide Python2 anymore in the 
Debian packaging.

diff -Nru remctl-3.16/debian/changelog remctl-3.16/debian/changelog
--- remctl-3.16/debian/changelog2019-11-03 18:52:30.0 +
+++ remctl-3.16/debian/changelog2019-11-05 06:55:51.0 +
@@ -1,3 +1,10 @@
+remctl (3.16-3.1) unstable; urgency=medium
+
+  * Fix build by avoiding typing install_require (useless with python3 only
+package) Closes: #944151
+
+ -- Gianfranco Costamagna   Tue, 05 Nov 2019 
07:55:51 +0100
+
 remctl (3.16-3) unstable; urgency=medium
 
   * Fix syntax of Python autopkgtest script to work with both Python 2 and
diff -Nru remctl-3.16/debian/patches/no-typing.patch 
remctl-3.16/debian/patches/no-typing.patch
--- remctl-3.16/debian/patches/no-typing.patch  1970-01-01 00:00:00.0 
+
+++ remctl-3.16/debian/patches/no-typing.patch  2019-11-05 06:55:51.0 
+
@@ -0,0 +1,14 @@
+Description: Typing is native in Python3, so no need to have it specified in 
setup.py file, avoiding internet connection during build
+Author: Gianfranco Costamagna 
+Last-Update: 2019-11-05
+
+--- remctl-3.16.orig/python/setup.py
 remctl-3.16/python/setup.py
+@@ -111,7 +111,6 @@ kwargs = {
+ "description": doclines[0],
+ "long_description": "\n".join(doclines[2:]),
+ "license": "MIT",
+-"install_requires": ["typing"],
+ "setup_requires": ["pytest-runner"],
+ "tests_require": ["pytest"],
+ "classifiers": [
diff -Nru remctl-3.16/debian/patches/series remctl-3.16/debian/patches/series
--- remctl-3.16/debian/patches/series   1970-01-01 00:00:00.0 +
+++ remctl-3.16/debian/patches/series   2019-11-05 06:55:51.0 +
@@ -0,0 +1 @@
+no-typing.patch

Bug#944151: remctl: attempts internet connection during testsuite

[Gianfranco Costamagna]

Source: remctl
Version: 3.16-3
Severity: serious

Hello, according to build log:
Testing Python extension
running pytest
Searching for typing
Reading https://pypi.org/simple/typing/
Downloading 
https://files.pythonhosted.org/packages/fe/2e/b480ee1b75e6d17d2993738670e75c1feeb9ff7f64452153cf018051cc92/typing-3.7.4.1-py3-none-any.whl#sha256=f38d83c5a7a7086543a0f649564d661859c5146a85775ab90c0d2f93ffaa9714
Best match: typing 3.7.4.1
Processing typing-3.7.4.1-py3-none-any.whl
Installing typing-3.7.4.1-py3-none-any.whl to /<>/python/.eggs

it does internet connection during its build...
You can see a failure in Ubuntu, where internet connection is more strictly 
disabled.
https://launchpadlibrarian.net/449766521/buildlog_ubuntu-focal-amd64.remctl_3.16-3_BUILDING.txt.gz

Can you please move into an autopkgtest or patch to avoid it?

thanks

Gianfranco