Bug#945602: wrong path for constants.xml/presets.xml prevent the program from starting

2019-12-02 Thread Boyuan Yang
X-Debbugs-CC: Gürkan Myczko 

Dear Gürkan,

On Thu, 28 Nov 2019 20:50:08 + nodiscc  wrote:
> Thqnk you, is there any chance for this fix to land in Debian stable?
> Or do we have to wait for the next release (i believe it will be
> available in stable due to the high severity)

I am proposing to fix this bug in Stable via stable-proposed-updates mechanism
(https://www.debian.org/releases/proposed-updates). The full diff is as
follows. I have tested and this surely fixes Debian Bug 945602.

Please let me know if that works for you. I can help to initiate the pu
process and make upload onto p-u-new queue if everything is okay.

Thanks and looking forward to your reply.

-- 
Best,
Boyuan Yang



diff --git a/debian/changelog b/debian/changelog
index bff76ce..caab792 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+qwinff (0.2.1-1+deb10u1) buster; urgency=medium
+
+  * debian/rules: Export DATA_PATH to fix crashing caused by
+incorrect file detection. (Closes: #945602)
+
+ -- Boyuan Yang   Mon, 02 Dec 2019 16:50:26 -0500
+
 qwinff (0.2.1-1) unstable; urgency=medium
 
   * Initial release. (Closes: #731153)
diff --git a/debian/rules b/debian/rules
index fef1c1c..48d906a 100755
--- a/debian/rules
+++ b/debian/rules
@@ -12,6 +12,7 @@ export DEB_LDFLAGS_MAINT_APPEND = -Wl,--as-needed
 
 export QTDIR=/usr/share/qt5
 export QT_SELECT=qt5
+export DATA_PATH=\"/usr/share/qwinff/\"
 
 %:
dh $@


signature.asc
Description: This is a digitally signed message part


Bug#945602: wrong path for constants.xml/presets.xml prevent the program from starting

2019-11-28 Thread nodiscc
Thqnk you, is there any chance for this fix to land in Debian stable?
Or do we have to wait for the next release (i believe it will be
available in stable due to the high severity)

Thanks again

Le jeu. 28 nov. 2019 à 09:52, Gürkan Myczko  a écrit :
>
> Hi,
>
> I can confirm this is really broken, however it was working for me for
> whatever reason,
> or how else did I create the
> https://screenshots.debian.net/package/qwinff screenshot?
>
> Anyways, a fixed version is on it's way:
> http://phd-sid.ethz.ch/debian/qwinff/
>
> Best,



Bug#945602: wrong path for constants.xml/presets.xml prevent the program from starting

2019-11-28 Thread Gürkan Myczko

Hi,

I can confirm this is really broken, however it was working for me for 
whatever reason,
or how else did I create the 
https://screenshots.debian.net/package/qwinff screenshot?


Anyways, a fixed version is on it's way:
http://phd-sid.ethz.ch/debian/qwinff/

Best,



Bug#945602: wrong path for constants.xml/presets.xml prevent the program from starting

2019-11-27 Thread nodiscc
Package: qwinff
Version: 0.2.1-1
Severity: grave

Steps to reproduce the problem:
 - run qwinff from the desktop launcher of from a terminal emulator

What happens:
 - An error dialog is shown with the message "Cannot load
/home/user/constants.xml. The program will exit now."
 - In addition, when qwinff is launched from a terminal, there is the
error "Failed to read file: "/home/user/constants.xml"
 - Clicking the "Ok" button closes the error message, but the program
is in fact still running (appears in ps aux output/task managers).
When run from a terminal it does not give back STDIN unless I
stop/kill/Ctrl+C it

Workaround:
 - a quick search reveals a file /usr/share/qwinff/constants.xml.
Copying this file to /home/user/constants.xml makes the error message
disappear. A second message is shown about missing presets.xml, the
same workaround can be applied (it's also in /usr/share/qwinff/)

Suggested fix:
I don't know. The makefile
(https://github.com/qwinff/qwinff/blob/master/Makefile#L65)
explicitely says to install these files in $(DATA_PATH) so I assume
this path was incorrectly set when the package was built. Rebuild and
test this time :)

Severity grave because the program does not work at all by default
unless you find the workaround.

Thank you in advance