Bug#950211: python-virustotal-api fails autopkg test
Hi Matthias, >>> Or you remove the autodep8 test from debian/control. >> Indeed that is what I changed in 1.1.11-2 which should be in both sid >> and bullseye by now -- I changed the autopkgtest definition and added >> custom test scripts reflecting the situation. >> >> All tests are green so far now [3]. Where did you get your log snippet from? > > http://autopkgtest.ubuntu.com/packages/p/python-virustotal-api/focal/amd64 But version 1.1.11-2 (without the ubuntu1 patch) also passes its autopkgtest in the list on that page (row 3)? > that's what I changed, it's still in the control file. > > http://launchpadlibrarian.net/462719068/python-virustotal-api_1.1.11-2_1.1.11-2ubuntu1.diff.gz This would also only cause the CI to run the regular autopkgtest in debian/tests, instead of the failing Python-specific ones that assume a particular mapping from import name to package name. My change in 1.1.11-2 does the same: diff --git a/debian/control b/debian/control index 83a6cfe..6032eda 100644 --- a/debian/control +++ b/debian/control @@ -9,7 +9,7 @@ Build-Depends: debhelper-compat (= 12), python3-setuptools, python3-requests Standards-Version: 4.5.0 -Testsuite: autopkgtest-pkg-python +Testsuite: autopkgtest Vcs-Git: https://salsa.debian.org/debian/python-virustotal-api.git Vcs-Browser: https://salsa.debian.org/debian/python-virustotal-api Homepage: https://github.com/blacktop/virustotal-api Plus adding a separate, explicit test setup in d/tests, of course. I do not see where removing the Testsuite line would change anything compared to 1.1.11-2, given that the autopkgtest for that’s version passes even on Ubuntu’s CI. Am I missing something? Cheers Sascha signature.asc Description: Message signed with OpenPGP
Bug#950211: python-virustotal-api fails autopkg test
On 1/30/20 11:05 AM, Sascha Steinbiss wrote: > > Hi Matthias, > >> the autodep8 test fails, because the package is wrongly named. The package >> name >> should be python-virustotal-apis? > > I wanted to be in line with the name of the package on PyPi [1] as that > how I would look for this package if I wanted to use it. > 'virustotal-api' is also the module name according to upstream's > setup.py [2] > > Looks like upstream themselves seem to use diverging names by using > virus_total_apis as the module to import :/ > >> Or you remove the autodep8 test from debian/control. > Indeed that is what I changed in 1.1.11-2 which should be in both sid > and bullseye by now -- I changed the autopkgtest definition and added > custom test scripts reflecting the situation. > > All tests are green so far now [3]. Where did you get your log snippet from? http://autopkgtest.ubuntu.com/packages/p/python-virustotal-api/focal/amd64 that's what I changed, it's still in the control file. http://launchpadlibrarian.net/462719068/python-virustotal-api_1.1.11-2_1.1.11-2ubuntu1.diff.gz
Bug#950211: python-virustotal-api fails autopkg test
Hi Matthias, > the autodep8 test fails, because the package is wrongly named. The package > name > should be python-virustotal-apis? I wanted to be in line with the name of the package on PyPi [1] as that how I would look for this package if I wanted to use it. 'virustotal-api' is also the module name according to upstream's setup.py [2] Looks like upstream themselves seem to use diverging names by using virus_total_apis as the module to import :/ > Or you remove the autodep8 test from debian/control. Indeed that is what I changed in 1.1.11-2 which should be in both sid and bullseye by now -- I changed the autopkgtest definition and added custom test scripts reflecting the situation. All tests are green so far now [3]. Where did you get your log snippet from? Best regards Sascha [1] https://pypi.org/project/virustotal-api/ [2] https://github.com/blacktop/virustotal-api/blob/master/setup.py#L25 [3] https://ci.debian.net/packages/p/python-virustotal-api/ signature.asc Description: OpenPGP digital signature
Bug#950211: python-virustotal-api fails autopkg test
Package: src:python-virustotal-api Version: 1.1.11-2 Severity: serious Tags: sid bullseye the autodep8 test fails, because the package is wrongly named. The package name should be python-virustotal-apis? Or you remove the autodep8 test from debian/control. Setting up autopkgtest-satdep (0) ... (Reading database ... 65026 files and directories currently installed.) Removing autopkgtest-satdep (0) ... autopkgtest [10:19:31]: test autodep8-python3: set -e ; for py in $(py3versions -r 2>/dev/null) ; do cd "$AUTOPKGTEST_TMP" ; echo "Testing with $py:" ; $py -c "import virustotal_api; print(virustotal_api)" ; done autopkgtest [10:19:31]: test autodep8-python3: [--- Testing with python3.7: Traceback (most recent call last): File "", line 1, in ModuleNotFoundError: No module named 'virustotal_api' autopkgtest [10:19:31]: test autodep8-python3: ---] autodep8-python3 FAIL non-zero exit status 1 autopkgtest [10:19:32]: test autodep8-python3: - - - - - - - - - - results - - - - - - - - - - autopkgtest [10:19:32]: summary autodep8-python3 FAIL non-zero exit status 1
