Bug#956822: xpra: FTBFS on armel and armhf

[Dmitry Smirnov]

On Wednesday, 22 July 2020 11:17:44 PM AEST Gianfranco Costamagna wrote:
> based on upstream suggestion, I removed the patch

Thanks for your help.

The trouble is that the patch is actually useful and without it detection
result differs. Just removing the patch is not ideal (I tried that already).

We might have to apply patch only on some architectures

-- 
Cheers,
 Dmitry Smirnov.

---

If everybody is thinking alike, then somebody isn't thinking.
-- George S. Patton

---

Those young and healthy people who currently walk around with a mask on
their faces would be better off wearing a helmet instead, because the risk
of something falling on their head is greater than that of getting a
serious case of Covid-19.
"Coronavirus: Why everyone was wrong"
-- 
https://medium.com/@vernunftundrichtigkeit/coronavirus-why-everyone-was-wrong-fce6db5ba809


signature.asc
Description: This is a digitally signed message part.

Bug#956822: xpra: FTBFS on armel and armhf

[Gianfranco Costamagna]

Hello,

> xpra failed to build on armel and armhf. See
> https://buildd.debian.org/status/fetch.php?pkg=xpra=armel=3.0.8%2Bdfsg1-1=1586872010=0

based on upstream suggestion, I removed the patch, and let the program do its 
job, by adding the dependencies on xorg and xvfb (this one can probably be 
installed just on arm)

I also added xvfb on debian/tests/control, and the autopkgtest went green also 
on armhf!

--- xpra-3.0.9+dfsg1/debian/changelog   2020-04-20 02:47:55.0 +0200
+++ xpra-3.0.9+dfsg1/debian/changelog   2020-07-21 18:49:46.0 +0200
@@ -1,3 +1,11 @@
+xpra (3.0.9+dfsg1-1.1) unstable; urgency=medium
+
+  * Add xorg and xvfb to build and test deps and comment xorg patch
+- This should help detection of the right backend on arm* and elsewhere.
+  see https://xpra.org/trac/ticket/2737 and Debian bug: #956822
+
+ -- Gianfranco Costamagna   Tue, 21 Jul 2020 
18:49:46 +0200
+
 xpra (3.0.9+dfsg1-1) unstable; urgency=medium
 
   * New upstream release.
diff -Nru xpra-3.0.9+dfsg1/debian/control xpra-3.0.9+dfsg1/debian/control
--- xpra-3.0.9+dfsg1/debian/control 2020-04-14 11:52:20.0 +0200
+++ xpra-3.0.9+dfsg1/debian/control 2020-07-21 18:49:46.0 +0200
@@ -28,6 +28,8 @@
 ,python3-all-dev
 ,python3-cairo-dev
 ,python-gi-dev
+,xorg
+,xvfb
 Rules-Requires-Root: no
 Homepage: http://xpra.org/
 Vcs-Git: https://salsa.debian.org/debian/xpra.git
diff -Nru xpra-3.0.9+dfsg1/debian/patches/series 
xpra-3.0.9+dfsg1/debian/patches/series
--- xpra-3.0.9+dfsg1/debian/patches/series  2020-03-26 11:08:09.0 
+0100
+++ xpra-3.0.9+dfsg1/debian/patches/series  2020-07-21 18:49:35.0 
+0200
@@ -1,7 +1,7 @@
 
 ## Fixes
 build-hurd.patch
-fix-xvfb-path.patch
+#fix-xvfb-path.patch
 
 ## Misc.
 buildinfo.patch
diff -Nru xpra-3.0.9+dfsg1/debian/tests/control 
xpra-3.0.9+dfsg1/debian/tests/control
--- xpra-3.0.9+dfsg1/debian/tests/control   2019-04-10 03:39:32.0 
+0200
+++ xpra-3.0.9+dfsg1/debian/tests/control   2020-07-21 18:49:46.0 
+0200
@@ -3,6 +3,6 @@
 #, isolation-container
 # ,isolation-machine
 # ,needs-recommends
-Depends: @ ,coreutils ,procps ,x11-apps ,x11-xserver-utils ,xauth
+Depends: @ ,coreutils ,procps ,x11-apps ,x11-xserver-utils ,xauth, xvfb
 # ,@builddeps@
 # ,x11-common


you can see autopkgtest results here
https://autopkgtest.ubuntu.com/packages/xpra/groovy/

I know adding xorg and xvfb is far from ideal, but I agree that the 
autodetection system that upstream
provides us should work, and eventually be fixed if something is not correct, 
rather than patching it manually
downstream.

I don't plan to NMU this change, because I still feel not too confident on it

G.

Bug#956822: xpra: FTBFS on armel and armhf

[Gianfranco Costamagna]

and this is the correct link
https://autopkgtest.ubuntu.com/packages/xpra

G.

Bug#956822: xpra: FTBFS on armel and armhf

[Sebastian Ramacher]

Source: xpra
Version: 3.0.8+dfsg1-1
Severity: serious
Tags: ftbfs sid bullseye
Justification: fails to build from source (but built successfully in the past)

xpra failed to build on armel and armhf. See
https://buildd.debian.org/status/fetch.php?pkg=xpra=armel=3.0.8%2Bdfsg1-1=1586872010=0

Cheers

-- System Information:
Debian Release: bullseye/sid
  APT prefers unstable-debug
  APT policy: (650, 'unstable-debug'), (650, 'unstable'), (601, 'testing'), 
(600, 'experimental-debug'), (600, 'buildd-unstable'), (600, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.5.0-1-amd64 (SMP w/8 CPU cores)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, 
TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8), LANGUAGE=en_US:en 
(charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

-- 
Sebastian Ramacher


signature.asc
Description: PGP signature