Bug#959591: mscgen: FTBFS: dh_auto_test: error: cd _build && make -j4 check VERBOSE=1 returned exit code 2
Hi Niels, I’ll fix that in libgd2, it also causes problem in PHP. Ondřej -- Ondřej Surý > On 3 May 2020, at 16:55, Niels Thykier wrote: > > Ondřej Surý: >> Hi Lucas, >> >> this: https://github.com/libgd/libgd/issues/615 ? >> >> [...] >> > > Hi Ondřej, > > Thanks for the link. It indeed looks related and if I special case > 0-sized strings in mscgen, the error goes away (see attached patch). > > Should I apply this patch to mscgen, or should this be fixed in libgd2? > > ~Niels > >
Bug#959591: mscgen: FTBFS: dh_auto_test: error: cd _build && make -j4 check VERBOSE=1 returned exit code 2
Ondřej Surý:
> Hi Lucas,
>
> this: https://github.com/libgd/libgd/issues/615 ?
>
>[...]
>
Hi Ondřej,
Thanks for the link. It indeed looks related and if I special case
0-sized strings in mscgen, the error goes away (see attached patch).
Should I apply this patch to mscgen, or should this be fixed in libgd2?
~Niels
diff --git a/src/gd_out.c b/src/gd_out.c
index 64d82b2..34451f9 100644
--- a/src/gd_out.c
+++ b/src/gd_out.c
@@ -194,6 +194,12 @@ unsigned int gdoTextWidth(struct ADrawTag *ctx,
int rect[8] = { 0, 0, 0, 0, 0, 0, 0, 0 };
const char *r;
+/* Work around https://github.com/libgd/libgd/issues/615 */
+if (string[0] == '\0')
+{
+ return 0;
+}
+
r = gdImageStringFT(NULL,
rect,
context->pen,
@@ -297,6 +303,11 @@ void gdoTextR(struct ADrawTag *ctx,
int textWidth;
textWidth = gdoTextWidth(ctx, string);
+/* Work around https://github.com/libgd/libgd/issues/615 */
+if (textWidth == 0)
+{
+return;
+}
/* Range check since gdImageFilledRectangle() takes signed values */
if(x + textWidth <= INT_MAX && y <= INT_MAX)
Bug#959591: mscgen: FTBFS: dh_auto_test: error: cd _build && make -j4 check VERBOSE=1 returned exit code 2
Hi Lucas, this: https://github.com/libgd/libgd/issues/615 ? -- Ondřej Surý > On 3 May 2020, at 15:36, Niels Thykier wrote: > > > Lucas Nussbaum: >> Source: mscgen >> Version: 0.20-13 >> Severity: serious >> Justification: FTBFS on amd64 >> Tags: bullseye sid ftbfs >> Usertags: ftbfs-20200501 ftbfs-bullseye >> >> Hi, >> >> During a rebuild of all packages in sid, your package failed to build >> on amd64. >> > > > Hi Ondřej, > > You broke my stuff! > > :) > > Seriously though, it seems the recent libgd2 upload broke mscgen (also > visible in the autopkgtest blocking libgd2 from transitioning to testing). > > I checked the upstream changelog and cannot see an obvious change > related to the function that fails. The test case in question is a > rather lengthy string shoved into "gdImageStringFT" trying to determine > how wide the string will be (so mscgen can figure out how to render it). > > Help figuring out what broke would be nice as the error "Problem doing > text layout" is not very helpful in debugging the issue. > > ~Niels > > >> Relevant part (hopefully): >>> make[4]: Entering directory '/<>/_build/test' >>> FAIL: renderercheck.sh >>> == >>> mscgen 0.20: test/test-suite.log >>> == >>> >>> # TOTAL: 1 >>> # PASS: 0 >>> # SKIP: 0 >>> # XFAIL: 0 >>> # FAIL: 1 >>> # XPASS: 0 >>> # ERROR: 0 >>> >>> .. contents:: :depth: 2 >>> >>> FAIL: renderercheck.sh >>> == >>> >>> testinput0.msc >>> testinput1.msc >>> testinput10.msc >>> testinput11.msc >>> testinput12.msc >>> testinput13.msc >>> testinput14.msc >>> testinput15.msc >>> testinput16.msc >>> testinput17.msc >>> Error: gdoTextWidth: Problem doing text layout (GDFONTPATH=) >>> FAIL renderercheck.sh (exit status: 1) >>> >>> >>> Testsuite summary for mscgen 0.20 >>> >>> # TOTAL: 1 >>> # PASS: 0 >>> # SKIP: 0 >>> # XFAIL: 0 >>> # FAIL: 1 >>> # XPASS: 0 >>> # ERROR: 0 >>> >>> See test/test-suite.log >>> Please report to michael.mcternan.2...@cs.bris.ac.uk >>> >>> make[4]: *** [Makefile:495: test-suite.log] Error 1 >>> make[4]: Leaving directory '/<>/_build/test' >>> make[3]: *** [Makefile:603: check-TESTS] Error 2 >>> make[3]: Leaving directory '/<>/_build/test' >>> make[2]: *** [Makefile:676: check-am] Error 2 >>> make[2]: Leaving directory '/<>/_build/test' >>> make[1]: *** [Makefile:421: check-recursive] Error 1 >>> make[1]: Leaving directory '/<>/_build' >>> dh_auto_test: error: cd _build && make -j4 check VERBOSE=1 returned exit >>> code 2 >> >> The full build log is available from: >> http://qa-logs.debian.net/2020/05/01/mscgen_0.20-13_unstable.log >> >> A list of current common problems and possible solutions is available at >> http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute! >> >> About the archive rebuild: The rebuild was done on EC2 VM instances from >> Amazon Web Services, using a clean, minimal and up-to-date chroot. Every >> failed build was retried once to eliminate random failures. >> >
Bug#959591: mscgen: FTBFS: dh_auto_test: error: cd _build && make -j4 check VERBOSE=1 returned exit code 2
Lucas Nussbaum: > Source: mscgen > Version: 0.20-13 > Severity: serious > Justification: FTBFS on amd64 > Tags: bullseye sid ftbfs > Usertags: ftbfs-20200501 ftbfs-bullseye > > Hi, > > During a rebuild of all packages in sid, your package failed to build > on amd64. > Hi Ondřej, You broke my stuff! :) Seriously though, it seems the recent libgd2 upload broke mscgen (also visible in the autopkgtest blocking libgd2 from transitioning to testing). I checked the upstream changelog and cannot see an obvious change related to the function that fails. The test case in question is a rather lengthy string shoved into "gdImageStringFT" trying to determine how wide the string will be (so mscgen can figure out how to render it). Help figuring out what broke would be nice as the error "Problem doing text layout" is not very helpful in debugging the issue. ~Niels > Relevant part (hopefully): >> make[4]: Entering directory '/<>/_build/test' >> FAIL: renderercheck.sh >> == >>mscgen 0.20: test/test-suite.log >> == >> >> # TOTAL: 1 >> # PASS: 0 >> # SKIP: 0 >> # XFAIL: 0 >> # FAIL: 1 >> # XPASS: 0 >> # ERROR: 0 >> >> .. contents:: :depth: 2 >> >> FAIL: renderercheck.sh >> == >> >> testinput0.msc >> testinput1.msc >> testinput10.msc >> testinput11.msc >> testinput12.msc >> testinput13.msc >> testinput14.msc >> testinput15.msc >> testinput16.msc >> testinput17.msc >> Error: gdoTextWidth: Problem doing text layout (GDFONTPATH=) >> FAIL renderercheck.sh (exit status: 1) >> >> >> Testsuite summary for mscgen 0.20 >> >> # TOTAL: 1 >> # PASS: 0 >> # SKIP: 0 >> # XFAIL: 0 >> # FAIL: 1 >> # XPASS: 0 >> # ERROR: 0 >> >> See test/test-suite.log >> Please report to michael.mcternan.2...@cs.bris.ac.uk >> >> make[4]: *** [Makefile:495: test-suite.log] Error 1 >> make[4]: Leaving directory '/<>/_build/test' >> make[3]: *** [Makefile:603: check-TESTS] Error 2 >> make[3]: Leaving directory '/<>/_build/test' >> make[2]: *** [Makefile:676: check-am] Error 2 >> make[2]: Leaving directory '/<>/_build/test' >> make[1]: *** [Makefile:421: check-recursive] Error 1 >> make[1]: Leaving directory '/<>/_build' >> dh_auto_test: error: cd _build && make -j4 check VERBOSE=1 returned exit >> code 2 > > The full build log is available from: >http://qa-logs.debian.net/2020/05/01/mscgen_0.20-13_unstable.log > > A list of current common problems and possible solutions is available at > http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute! > > About the archive rebuild: The rebuild was done on EC2 VM instances from > Amazon Web Services, using a clean, minimal and up-to-date chroot. Every > failed build was retried once to eliminate random failures. >
Bug#959591: mscgen: FTBFS: dh_auto_test: error: cd _build && make -j4 check VERBOSE=1 returned exit code 2
Source: mscgen Version: 0.20-13 Severity: serious Justification: FTBFS on amd64 Tags: bullseye sid ftbfs Usertags: ftbfs-20200501 ftbfs-bullseye Hi, During a rebuild of all packages in sid, your package failed to build on amd64. Relevant part (hopefully): > make[4]: Entering directory '/<>/_build/test' > FAIL: renderercheck.sh > == >mscgen 0.20: test/test-suite.log > == > > # TOTAL: 1 > # PASS: 0 > # SKIP: 0 > # XFAIL: 0 > # FAIL: 1 > # XPASS: 0 > # ERROR: 0 > > .. contents:: :depth: 2 > > FAIL: renderercheck.sh > == > > testinput0.msc > testinput1.msc > testinput10.msc > testinput11.msc > testinput12.msc > testinput13.msc > testinput14.msc > testinput15.msc > testinput16.msc > testinput17.msc > Error: gdoTextWidth: Problem doing text layout (GDFONTPATH=) > FAIL renderercheck.sh (exit status: 1) > > > Testsuite summary for mscgen 0.20 > > # TOTAL: 1 > # PASS: 0 > # SKIP: 0 > # XFAIL: 0 > # FAIL: 1 > # XPASS: 0 > # ERROR: 0 > > See test/test-suite.log > Please report to michael.mcternan.2...@cs.bris.ac.uk > > make[4]: *** [Makefile:495: test-suite.log] Error 1 > make[4]: Leaving directory '/<>/_build/test' > make[3]: *** [Makefile:603: check-TESTS] Error 2 > make[3]: Leaving directory '/<>/_build/test' > make[2]: *** [Makefile:676: check-am] Error 2 > make[2]: Leaving directory '/<>/_build/test' > make[1]: *** [Makefile:421: check-recursive] Error 1 > make[1]: Leaving directory '/<>/_build' > dh_auto_test: error: cd _build && make -j4 check VERBOSE=1 returned exit code > 2 The full build log is available from: http://qa-logs.debian.net/2020/05/01/mscgen_0.20-13_unstable.log A list of current common problems and possible solutions is available at http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute! About the archive rebuild: The rebuild was done on EC2 VM instances from Amazon Web Services, using a clean, minimal and up-to-date chroot. Every failed build was retried once to eliminate random failures.
